Re: [PATCH v5 14/20] vfio: selftests: Add vfio_pci_liveupdate_uapi_test

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The selftest `vfio_pci_liveupdate_uapi_test.c` fails to compile and link due to missing headers, libraries, and undefined functions.
--

--- Patch [14]: [PATCH v5 14/20] vfio: selftests: Add vfio_pci_liveupdate_uapi_test ---
commit 4ef2d85343eb23f4f743330b67aabe0e09e08f3d
Author: David Matlack <dmatlack@google.com>

vfio: selftests: Add vfio_pci_liveupdate_uapi_test

This commit adds a selftest to exercise preserving various VFIO files
through /dev/liveupdate. It verifies that VFIO cdev device files can be
preserved while group-based device files, group files, and container files
fail.

> diff --git a/tools/testing/selftests/vfio/vfio_pci_liveupdate_uapi_test.c b/tools/testing/selftests/vfio/vfio_pci_liveupdate_uapi_test.c
> new file mode 100644
> index 0000000000000..f81c8ab21db3f
> --- /dev/null
> +++ b/tools/testing/selftests/vfio/vfio_pci_liveupdate_uapi_test.c
> @@ -0,0 +1,97 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +
> +#include <libliveupdate.h>

[Severity: Low]
Does this header file exist in the tree? The build fails because
<libliveupdate.h> cannot be found. 

Additionally, is the Makefile missing an include for
../liveupdate/lib/libliveupdate.mk to ensure the dependencies are properly
pulled in for the build?

> +#include <libvfio.h>
> +#include <kselftest_harness.h>

[ ... ]

> +TEST_F(vfio_pci_liveupdate_uapi_test, preserve_device)
> +{
> +	int ret;
> +
> +	ret = luo_session_preserve_fd(self->session_fd, self->device->fd, 0);

[Severity: Low]
Is this calling a kernel-space function from a user-space selftest?

Looking at the code, luo_session_preserve_fd() appears to be defined in
kernel/liveupdate/luo_session.c. Since this is a user-space selftest,
calling it here results in an undefined reference during compilation. 

Should this be invoking an ioctl directly, or is there a user-space library
wrapper intended to be used instead?

> +
> +	/* Preservation should only be supported for VFIO cdev files. */
> +	ASSERT_EQ(ret, self->iommu->iommufd ? 0 : -ENOENT);
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260714151505.3466855-1-vipinsh@google.com?part=14