[PATCH] dt-bindings: firmware: qcom,scm: Document SCM on Shikra SoC

[PATCH] dt-bindings: firmware: qcom,scm: Document SCM on Shikra SoC

[Komal Bajaj]

Document the SCM compatible for the Shikra SoC.

Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
index 7918d31f58b4..bb1e0a0d1d3c 100644
--- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
+++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
@@ -65,6 +65,7 @@ properties:
           - qcom,scm-sdx55
           - qcom,scm-sdx65
           - qcom,scm-sdx75
+          - qcom,scm-shikra
           - qcom,scm-sm6115
           - qcom,scm-sm6125
           - qcom,scm-sm6350
@@ -146,6 +147,7 @@ allOf:
               - qcom,scm-msm8974
               - qcom,scm-msm8976
               - qcom,scm-qcm2290
+              - qcom,scm-shikra
               - qcom,scm-sm6375
     then:
       required:
@@ -165,6 +167,7 @@ allOf:
               - qcom,scm-msm8660
               - qcom,scm-msm8960
               - qcom,scm-qcm2290
+              - qcom,scm-shikra
               - qcom,scm-sm6375
     then:
       properties:

---
base-commit: 39704f00f747aba3144289870b5fd8ac230a9aaf
change-id: 20260501-shikra-scm-binding-a7ff5fabd0f2

Best regards,
-- 
Komal Bajaj <komal.bajaj@oss.qualcomm.com>

Re: [PATCH] dt-bindings: firmware: qcom,scm: Document SCM on Shikra SoC

[Krzysztof Kozlowski]

On Fri, May 01, 2026 at 11:23:46PM +0530, Komal Bajaj wrote:
> Document the SCM compatible for the Shikra SoC.
> 
> Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> index 7918d31f58b4..bb1e0a0d1d3c 100644
> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> @@ -65,6 +65,7 @@ properties:
>            - qcom,scm-sdx55
>            - qcom,scm-sdx65
>            - qcom,scm-sdx75
> +          - qcom,scm-shikra
>            - qcom,scm-sm6115
>            - qcom,scm-sm6125
>            - qcom,scm-sm6350
> @@ -146,6 +147,7 @@ allOf:
>                - qcom,scm-msm8974
>                - qcom,scm-msm8976
>                - qcom,scm-qcm2290
> +              - qcom,scm-shikra
>                - qcom,scm-sm6375
>      then:
>        required:
> @@ -165,6 +167,7 @@ allOf:
>                - qcom,scm-msm8660
>                - qcom,scm-msm8960
>                - qcom,scm-qcm2290
> +              - qcom,scm-shikra
>                - qcom,scm-sm6375

This looks wrong or the diff hunks are confusing. Aren't you changing
one if:then: block for clocks and then second different one which
disallows clocks?

dtbs_check on your DTS would tell you...

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: firmware: qcom,scm: Document SCM on Shikra SoC

[Komal Bajaj]

On 5/4/2026 4:33 PM, Krzysztof Kozlowski wrote:
> On Fri, May 01, 2026 at 11:23:46PM +0530, Komal Bajaj wrote:
>> Document the SCM compatible for the Shikra SoC.
>>
>> Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
>> ---
>>   Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> index 7918d31f58b4..bb1e0a0d1d3c 100644
>> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
>> @@ -65,6 +65,7 @@ properties:
>>             - qcom,scm-sdx55
>>             - qcom,scm-sdx65
>>             - qcom,scm-sdx75
>> +          - qcom,scm-shikra
>>             - qcom,scm-sm6115
>>             - qcom,scm-sm6125
>>             - qcom,scm-sm6350
>> @@ -146,6 +147,7 @@ allOf:
>>                 - qcom,scm-msm8974
>>                 - qcom,scm-msm8976
>>                 - qcom,scm-qcm2290
>> +              - qcom,scm-shikra
>>                 - qcom,scm-sm6375
>>       then:
>>         required:
>> @@ -165,6 +167,7 @@ allOf:
>>                 - qcom,scm-msm8660
>>                 - qcom,scm-msm8960
>>                 - qcom,scm-qcm2290
>> +              - qcom,scm-shikra
>>                 - qcom,scm-sm6375
> This looks wrong or the diff hunks are confusing. Aren't you changing
> one if:then: block for clocks and then second different one which
> disallows clocks?
>
> dtbs_check on your DTS would tell you...

The two hunks touch two separate allOf blocks:

- Block 1 (required: [clocks, clock-names]): SoCs that need clocks at all
- Block 2 (clock-names: [core], clocks maxItems: SoCs using exactly one 
clock named core

Both hunks are intentional.
Verified with dtbs_check — no complaints.

Thanks
Komal

>
> Best regards,
> Krzysztof
>

Re: [PATCH] dt-bindings: firmware: qcom,scm: Document SCM on Shikra SoC

[Krzysztof Kozlowski]

On 01/05/2026 19:53, Komal Bajaj wrote:
> Document the SCM compatible for the Shikra SoC.
> 
> Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 3 +++
>  1 file changed, 3 insertions(+)


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: firmware: qcom,scm: Document SCM on Shikra SoC

[Krzysztof Kozlowski]

On 08/05/2026 08:24, Komal Bajaj wrote:
>>>       then:
>>>         required:
>>> @@ -165,6 +167,7 @@ allOf:
>>>                 - qcom,scm-msm8660
>>>                 - qcom,scm-msm8960
>>>                 - qcom,scm-qcm2290
>>> +              - qcom,scm-shikra
>>>                 - qcom,scm-sm6375
>> This looks wrong or the diff hunks are confusing. Aren't you changing
>> one if:then: block for clocks and then second different one which
>> disallows clocks?
>>
>> dtbs_check on your DTS would tell you...
> 
> The two hunks touch two separate allOf blocks:
> 
> - Block 1 (required: [clocks, clock-names]): SoCs that need clocks at all
> - Block 2 (clock-names: [core], clocks maxItems: SoCs using exactly one 
> clock named core
> 
> Both hunks are intentional.
> Verified with dtbs_check — no complaints.

Yes, you are right.

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: firmware: qcom,scm: Document SCM on Shikra SoC

[Komal Bajaj]

On 5/14/2026 9:21 PM, Krzysztof Kozlowski wrote:
> On 01/05/2026 19:53, Komal Bajaj wrote:
>> Document the SCM compatible for the Shikra SoC.
>>
>> Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
>> ---
>>   Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 3 +++
>>   1 file changed, 3 insertions(+)
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Gentle ping — patches have Reviewed-by.

Thanks
Komal

Re: [PATCH] dt-bindings: firmware: qcom,scm: Document SCM on Shikra SoC

[Rob Herring]

On Tue, May 26, 2026 at 12:52 PM Komal Bajaj
<komal.bajaj@oss.qualcomm.com> wrote:
>
> On 5/14/2026 9:21 PM, Krzysztof Kozlowski wrote:
> > On 01/05/2026 19:53, Komal Bajaj wrote:
> >> Document the SCM compatible for the Shikra SoC.
> >>
> >> Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
> >> ---
> >>   Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 3 +++
> >>   1 file changed, 3 insertions(+)
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
> Gentle ping — patches have Reviewed-by.

In the future, send this with the .dts files that use them to make it
easy for Bjorn to apply. IOW, don't send .dts series that are going to
add DT warnings.

I don't need to be chasing down new QCom DT warnings. Figure this shit out.

Rob

Re: [PATCH] dt-bindings: firmware: qcom,scm: Document SCM on Shikra SoC

[Rob Herring]

On Fri, May 01, 2026 at 11:23:46PM +0530, Komal Bajaj wrote:
> Document the SCM compatible for the Shikra SoC.
> 
> Signed-off-by: Komal Bajaj <komal.bajaj@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 3 +++
>  1 file changed, 3 insertions(+)

Applied.