Re: [PATCH v7 03/10] selftests: tracing: Add a basic testcase for wprobe

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The test script uses '!grep' without a space, causing a shell error that silently bypasses trace validation. Additionally, the check lacks an 'exit_fail' call.
--

--- Patch [3]: [PATCH v7 03/10] selftests: tracing: Add a basic testcase for wprobe ---
commit 430a459576b6f13049e560d4a90b2c6a987f1ad3
Author: Masami Hiramatsu (Google) <mhiramat@kernel.org>
selftests: tracing: Add a basic testcase for wprobe

This commit adds a basic selftest testcase to verify adding and removing 
wprobe dynamic events.

Link: https://lore.kernel.org/all/175859026716.374439.14852239332989324292.stgit@devnote2/

> diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_wprobe.tc b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_wprobe.tc
> new file mode 100644
> --- /dev/null
> +++ b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_wprobe.tc
[ ... ]
> +# Let some time pass to trigger the breakpoint
> +sleep 1
> +
> +# Check if we got any trace output
> +if !grep -q my_wprobe trace; then
> +    echo "wprobe event was not triggered"
> +fi
> +

[Severity: Medium]
Will this check silently bypass trace validation? When the shell evaluates
"!grep", it treats it as a single command name rather than negating the grep
command, which typically results in a 'command not found' error.

Because the shell error results in a non-zero exit code, the if condition sees
this as false and entirely skips the block. Furthermore, even if written
correctly as "! grep", the block misses an exit_fail call, so the test would
still pass if the event failed to trigger.

Could this be updated to add a space after the exclamation mark and an
exit_fail call?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/178407983818.95826.12714571928538799781.stgit@devnote2?part=3