Re: [PATCH v7 07/10] x86/hw_breakpoint: Add arch_reinstall_hw_breakpoint

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arch_reinstall_hw_breakpoint() fails to clear old DR7 length and type bits before applying new attributes, causing hardware state corruption if breakpoint parameters are modified.
--

--- Patch [7]: [PATCH v7 07/10] x86/hw_breakpoint: Add arch_reinstall_hw_breakpoint ---
commit 6bcf7b8e474f5683afc4564b0a92754b65b43406
Author: Jinchao Wang <wangjinchao600@gmail.com>

x86/hw_breakpoint: Add arch_reinstall_hw_breakpoint

This commit introduces arch_reinstall_hw_breakpoint() to allow callers to
efficiently re-establish existing hardware breakpoints in an atomic context
without needing the full free and re-allocation path.

> diff --git a/arch/x86/kernel/hw_breakpoint.c b/arch/x86/kernel/hw_breakpoint.c
> index 877509539300c..9af8d81075db7 100644
> --- a/arch/x86/kernel/hw_breakpoint.c
> +++ b/arch/x86/kernel/hw_breakpoint.c
[ ... ]
> @@ -188,6 +192,11 @@ int arch_install_hw_breakpoint(struct perf_event *bp)
>  	return arch_manage_bp(bp, BP_SLOT_ACTION_INSTALL);
>  }
>  
> +int arch_reinstall_hw_breakpoint(struct perf_event *bp)
> +{
> +	return arch_manage_bp(bp, BP_SLOT_ACTION_REINSTALL);
> +}

[Severity: Medium]
When callers use this new function to update an existing breakpoint's length
or type attributes, will this cause hardware state corruption in the DR7
control register?

The execution path goes through arch_manage_bp() and calls setup_hwbp()
with enable = true. Looking at setup_hwbp(), it appears the new control bits
are bitwise OR'ed with the existing mask:

arch/x86/kernel/hw_breakpoint.c:setup_hwbp() {
    ...
    if (enable)
        dr7 |= encode_dr7(slot, info->len, info->type);
    ...
}

Because the old DR7 configuration bits for this slot are never cleared first,
could the combination of old and new bits create an invalid breakpoint
configuration mask?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/178407983818.95826.12714571928538799781.stgit@devnote2?part=7