Re: [PATCH 1/4] arm64: dts: imx95-19x19-evk: Add CM7 node and related memory nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The virtio device buffer memory region is named `vdevbuffer` which fails the driver's hardcoded check for `vdev0buffer`, leading to it being erroneously registered as a carveout and double-mapped.
--

--- Patch [1]: [PATCH 1/4] arm64: dts: imx95-19x19-evk: Add CM7 node and related memory nodes ---
commit b818b56116c9f6f62676b904ae89c90565f8f036
Author: Peng Fan <peng.fan@nxp.com>

arm64: dts: imx95-19x19-evk: Add CM7 node and related memory nodes

This commit adds a remoteproc CM7 node and reserved memory regions to enable
the Cortex-M7 remote processor. The reserved memory includes firmware memory,
vring buffers, a resource table, and a shared DMA pool for inter-processor
communication.

> diff --git a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> --- a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
[ ... ]
> +		rsc_table: rsc-table@88220000 {
> +			reg = <0 0x88220000 0 0x1000>;
> +			no-map;
> +		};
> +
> +		vdevbuffer: vdevbuffer@88020000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0 0x88020000 0 0x100000>;
> +			no-map;
> +		};

[Severity: Medium]
Will this node name cause the region to be mapped twice?

During device probe, the driver iterates over the memory-region nodes in
imx_rproc_prepare() and attempts to skip the virtio buffer by checking:

    strstarts(res.name, "vdev0buffer")

Because this node is named vdevbuffer instead of vdev0buffer, it appears the
strstarts() check will fail. Does this cause the 1MB region to be erroneously
registered as a carveout and unnecessarily double-mapped via ioremap_wc() into
the vmalloc space?

>  	};
>  
>  	flexcan1_phy: can-phy0 {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260715-imx-rproc-dts-v1-0-d02b583c507b@nxp.com?part=1