Re: [PATCH 3/4] arm64: dts: imx943-evk: Add CM7 and CM33S nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing reserved memory regions for remoteproc firmware, breaking DDR firmware loading.
--

--- Patch [3]: [PATCH 3/4] arm64: dts: imx943-evk: Add CM7 and CM33S nodes ---
commit a58e64cf15c23fbbaba6ea1a5241a2bcdda233ef
Author: Peng Fan <peng.fan@nxp.com>

arm64: dts: imx943-evk: Add CM7 and CM33S nodes

This commit adds remoteproc nodes for Cortex-M7 (CM7-0, CM7-1) and Cortex-M33S
cores on the imx943-evk. It enables mailbox units and defines reserved memory
regions for vrings, resource tables, and shared DMA pools.

> diff --git a/arch/arm64/boot/dts/freescale/imx943-evk.dts b/arch/arm64/boot/dts/freescale/imx943-evk.dts
> index 674410e541cba..da7bfbd52e312 100644
> --- a/arch/arm64/boot/dts/freescale/imx943-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx943-evk.dts
> @@ -133,6 +133,36 @@ reg_audio_pwr: regulator-wm8962-pwr {
>  		enable-active-high;
>  	};
>  
> +	remoteproc-cm70 {
> +		compatible = "fsl,imx94-cm70";
> +		mbox-names = "tx", "rx", "rxdb";
> +		mboxes = <&mu11 0 1
> +			  &mu11 1 1
> +			  &mu11 3 1>;
> +		memory-region = <&cm70_vdevbuffer>, <&cm70_vdev0vring0>, <&cm70_vdev0vring1>,
> +				<&cm70_vdev1vring0>, <&cm70_vdev1vring1>, <&cm70_rsc_table>;

[Severity: High]
The commit message mentions adding reserved memory regions for firmware, but
are those regions missing from this memory-region list?

Without the firmware memory region defined, imx_rproc_da_to_va() will fail to
translate DDR addresses, which aborts firmware loading for segments destined
for DDR.

> +	};
> +
> +	remoteproc-cm71 {
> +		compatible = "fsl,imx94-cm71";
> +		mbox-names = "tx", "rx", "rxdb";
> +		mboxes = <&mu13 0 1
> +			  &mu13 1 1
> +			  &mu13 3 1>;
> +		memory-region = <&cm71_vdevbuffer>, <&cm71_vdev0vring0>, <&cm71_vdev0vring1>,
> +				<&cm71_vdev1vring0>, <&cm71_vdev1vring1>, <&cm71_rsc_table>;

[Severity: High]
Is the firmware memory region missing here as well?

> +	};
> +
> +	remoteproc-cm33s {
> +		compatible = "fsl,imx94-cm33s";
> +		mbox-names = "tx", "rx", "rxdb";
> +		mboxes = <&mu15 0 1
> +			  &mu15 1 1
> +			  &mu15 3 1>;
> +		memory-region = <&cm33s_vdevbuffer>, <&cm33s_vdev0vring0>, <&cm33s_vdev0vring1>,
> +				<&cm33s_vdev1vring0>, <&cm33s_vdev1vring1>, <&cm33s_rsc_table>;

[Severity: High]
And similarly, is the firmware memory region missing for the CM33S core?

> +	};
> +
>  	reserved-memory {
>  		ranges;
>  		#address-cells = <2>;
> @@ -145,6 +175,99 @@ linux,cma {
>  			size = <0 0x10000000>;
>  			linux,cma-default;
>  		};
> +
> +		cm33s_vdev0vring0: vdev0vring0@20800000 {

[Severity: High]
Does this block omit the actual firmware memory regions?

The reserved memory declarations define vrings, resource tables, and shared DMA
pools, but the firmware memory regions themselves seem to be completely missing.

There appears to be a 32MB gap in the DDR addresses (e.g., 0x80000000 to
0x81FFFFFF before cm70_vdev0vring0 at 0x82000000), which suggests the firmware
regions might have been unintentionally dropped.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260715-imx-rproc-dts-v1-0-d02b583c507b@nxp.com?part=3