From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Ryszard Knop <ryszard.knop@intel.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
linux-doc@vger.kernel.org,
Shuicheng Lin <shuicheng.lin@intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v2] scripts/kernel-doc: Suggest possible names for excess descriptions
Date: Wed, 15 Jul 2026 14:42:43 +0200 [thread overview]
Message-ID: <20260715144243.60686000@localhost> (raw)
In-Reply-To: <20260715111726.394565-1-ryszard.knop@intel.com>
On Wed, 15 Jul 2026 13:17:26 +0200
Ryszard Knop <ryszard.knop@intel.com> wrote:
> Since check_sections() now warns if a documentation tag member name is
> the same as defined in the struct, we can suggest names the checker
> knows, so that it's more obvious how to deal with the warning.
>
> v2 (rdunlap):
> - Strip whitespace from warnings, nicer when the hint is empty
>
> Signed-off-by: Ryszard Knop <ryszard.knop@intel.com>
> ---
> tools/lib/python/kdoc/kdoc_parser.py | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/tools/lib/python/kdoc/kdoc_parser.py b/tools/lib/python/kdoc/kdoc_parser.py
> index 2dedda215c22..a22c3e3182f0 100644
> --- a/tools/lib/python/kdoc/kdoc_parser.py
> +++ b/tools/lib/python/kdoc/kdoc_parser.py
> @@ -558,6 +558,13 @@ class KernelDoc:
> self.push_parameter(ln, decl_type, param, dtype,
> arg, declaration_name)
>
> + def get_suggestions_hint(self, decl_name, possible_names):
> + suggestions = set(name for name in possible_names if decl_name in name)
> + if not suggestions:
> + return ""
> +
> + return f"(did you mean one of: '{"', '".join(suggestions)}')"
> +
There is a better way to propose suggestions. See:
Documentation/sphinx/kernel_include.py
E.g. use something like:
from difflib import get_close_matches
matches = get_close_matches(decl_name, possible_names)
See: https://docs.python.org/3/library/difflib.html#difflib.get_close_matches
If the problem is due to a typo, this will likely return the
right name.
Regards,
Mauro
next prev parent reply other threads:[~2026-07-15 12:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 11:12 [PATCH] scripts/kernel-doc: Suggest possible names for excess descriptions Ryszard Knop
2026-07-14 12:21 ` ✓ CI.KUnit: success for " Patchwork
2026-07-14 13:02 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-14 18:12 ` ✓ Xe.CI.FULL: " Patchwork
2026-07-14 21:44 ` [PATCH] " Randy Dunlap
2026-07-15 11:18 ` Knop, Ryszard
2026-07-15 11:17 ` [PATCH v2] " Ryszard Knop
2026-07-15 12:42 ` Mauro Carvalho Chehab [this message]
2026-07-15 13:21 ` Knop, Ryszard
2026-07-15 13:52 ` Mauro Carvalho Chehab
2026-07-15 12:39 ` ✓ CI.KUnit: success for scripts/kernel-doc: Suggest possible names for excess descriptions (rev2) Patchwork
2026-07-15 13:19 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-15 15:01 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260715144243.60686000@localhost \
--to=mchehab+huawei@kernel.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=ryszard.knop@intel.com \
--cc=shuicheng.lin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.