All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Ryszard Knop <ryszard.knop@intel.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	linux-doc@vger.kernel.org
Cc: Shuicheng Lin <shuicheng.lin@intel.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v3] scripts/kernel-doc: Suggest possible names for excess descriptions
Date: Wed, 22 Jul 2026 10:15:30 -0600	[thread overview]
Message-ID: <87jyqnc865.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20260717125753.634550-1-ryszard.knop@intel.com>

Ryszard Knop <ryszard.knop@intel.com> writes:

> Recent check_sections() change added a warning if a documentation tag
> member name does not match the detected struct/union member names. Since
> the checker knows all possible names, we can suggest known names, so
> that it's more obvious how to deal with the warning.
>
> Signed-off-by: Ryszard Knop <ryszard.knop@intel.com>
> ---
> Changes in v1:
> - Added the suggestion hint in the warning, with basic name substring checks
> - Link: https://lore.kernel.org/linux-doc/20260714111208.323108-1-ryszard.knop@intel.com/
>
> Changes in v2:
> - Strip trailing whitespace from the warning when the generated hint is empty
> - Link: https://lore.kernel.org/linux-doc/20260715111726.394565-1-ryszard.knop@intel.com/
>
> v3:
> - Use difflib to generate suggestions even if the tag member is mistyped
> - Suggest names based on the nested struct members too
> ---
>  tools/lib/python/kdoc/kdoc_parser.py | 51 ++++++++++++++++++++++++++--
>  1 file changed, 49 insertions(+), 2 deletions(-)

Applied, thanks.

jon

  parent reply	other threads:[~2026-07-22 16:15 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14 11:12 [PATCH] scripts/kernel-doc: Suggest possible names for excess descriptions Ryszard Knop
2026-07-14 12:21 ` ✓ CI.KUnit: success for " Patchwork
2026-07-14 13:02 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-14 18:12 ` ✓ Xe.CI.FULL: " Patchwork
2026-07-14 21:44 ` [PATCH] " Randy Dunlap
2026-07-15 11:18   ` Knop, Ryszard
2026-07-15 11:17 ` [PATCH v2] " Ryszard Knop
2026-07-15 12:42   ` Mauro Carvalho Chehab
2026-07-15 13:21     ` Knop, Ryszard
2026-07-15 13:52       ` Mauro Carvalho Chehab
2026-07-17 13:17         ` Knop, Ryszard
2026-07-15 12:39 ` ✓ CI.KUnit: success for scripts/kernel-doc: Suggest possible names for excess descriptions (rev2) Patchwork
2026-07-15 13:19 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-15 15:01 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-07-16 22:40 ` [PATCH] scripts/kernel-doc: Suggest possible names for excess descriptions Jonathan Corbet
2026-07-17 13:07   ` Knop, Ryszard
2026-07-17 12:57 ` [PATCH v3] " Ryszard Knop
2026-07-17 16:28   ` Randy Dunlap
2026-07-22 16:15   ` Jonathan Corbet [this message]
2026-07-31  3:19   ` Akira Yokosawa
2026-07-31 14:45     ` Knop, Ryszard
2026-07-17 13:05 ` ✓ CI.KUnit: success for scripts/kernel-doc: Suggest possible names for excess descriptions (rev3) Patchwork
2026-07-17 13:41 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-17 20:21 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jyqnc865.fsf@trenco.lwn.net \
    --to=corbet@lwn.net \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=ryszard.knop@intel.com \
    --cc=shuicheng.lin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.