Re: [PATCH v27 2/7] dt-bindings: arm: fsl: add imx-se-fw binding doc

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The compatible string 'fsl,imx95-se-ele-hsm' is excluded from the memory-region conditional constraints, which improperly forbids its use.
--

--- Patch [2]: [PATCH v27 2/7] dt-bindings: arm: fsl: add imx-se-fw binding doc ---
commit a8dcc722ea68fab4850086d156b064a9fe58a7b9
Author: Pankaj Gupta <pankaj.gupta@nxp.com>

dt-bindings: arm: fsl: add imx-se-fw binding doc

This commit adds a new device tree binding document for NXP's hardware
secure enclave IP, such as EdgeLock Enclave and V2X. It establishes the
messaging unit interface used for communication between the application core
and the enclave firmware on processors like i.MX8ULP, i.MX93, and i.MX95.

> diff --git a/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml
> new file mode 100644
> index 0000000000000..fa81adbf9b80d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml
[ ... ]
> +allOf:
> +  # memory-region
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - fsl,imx8ulp-se-ele-hsm
> +              - fsl,imx93-se-ele-hsm
> +    then:
> +      required:
> +        - memory-region
> +    else:
> +      properties:
> +        memory-region: false

[Severity: Medium]
Does this conditional block improperly forbid the memory-region property for
the fsl,imx95-se-ele-hsm compatible string? Because fsl,imx95-se-ele-hsm is
omitted from the enum in the if clause, the else clause is evaluated and
forces memory-region to be false. If an i.MX95 device tree includes the
memory-region property, it will fail schema validation.

[ ... ]
> +examples:
> +  - |
> +    secure-enclave {
> +      compatible = "fsl,imx95-se-ele-hsm";
> +      mboxes = <&ele_mu0 0 0>, <&ele_mu0 1 0>;
> +      mbox-names = "tx", "rx";
> +    };
> +...

[Severity: Medium]
Does this example mask the omitted memory-region conditional above? The
example relies on fsl,imx95-se-ele-hsm to bypass the memory-region
requirement, which allows a potentially incomplete hardware description to
silently pass the dt_binding_check tool.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260715-imx-se-if-v27-0-bb7c45952f06@nxp.com?part=2