Re: [PATCH v27 6/7] arm64: dts: imx8ulp: add secure enclave node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing `memory-region` property causes probe failure and violates DT binding schema
--

--- Patch [6]: [PATCH v27 6/7] arm64: dts: imx8ulp: add secure enclave node ---
commit 1940854b723d6ccdefaa1704833b38d758fc0725
Author: Pankaj Gupta <pankaj.gupta@nxp.com>

arm64: dts: imx8ulp: add secure enclave node

This commit adds support for the NXP secure enclave (EdgeLock Enclave
firmware) for imx8ulp-evk by introducing the hsm0 secure-enclave node 
and a label for sram0.

> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index 1de3ad60c6aa7..a5b591add9a49 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi

[ ... ]

> @@ -185,6 +185,13 @@ scmi_sensor: protocol@15 {
>  				#thermal-sensor-cells = <1>;
>  			};
>  		};
> +
> +		hsm0: secure-enclave {
> +			compatible = "fsl,imx8ulp-se-ele-hsm";
> +			mbox-names = "tx", "rx";
> +			mboxes = <&s4muap 0 0>, <&s4muap 1 0>;
> +			sram = <&sram0>;
> +		};
>  	};

[Severity: High]
Does this node need a memory-region property?

Looking at se_if_probe() in drivers/firmware/imx/se_ctrl.c, the
reserved_dma_ranges flag is set to true for imx8ulp_se_ele_hsm. This
causes the driver to execute the following initialization:

drivers/firmware/imx/se_ctrl.c:se_if_probe() {
    ...
    if (if_node->reserved_dma_ranges) {
        ret = of_reserved_mem_device_init(dev);
        if (ret)
            return dev_err_probe(dev, ret,
                        "Failed to init reserved memory region.");
    }
    ...
}

Without a memory-region property in the device tree node, will
of_reserved_mem_device_init() fail to parse a phandle, return -ENODEV,
and cause the driver probe to abort unconditionally?

It also appears that a memory-region is expected by the fsl,imx-se.yaml
DT binding schema.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260715-imx-se-if-v27-0-bb7c45952f06@nxp.com?part=6