* [PATCH] xfs/333: require external scratch device
@ 2026-07-16 1:37 Shin'ichiro Kawasaki
2026-07-16 6:28 ` Yao Sang
2026-07-16 8:17 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Shin'ichiro Kawasaki @ 2026-07-16 1:37 UTC (permalink / raw)
To: fstests, Zorro Lang
Cc: linux-xfs, Yao Sang, Christoph Hellwig, Shin'ichiro Kawasaki
The test case xfs/333 uses the external scratch device SCRATCH_RTDEV.
When SCRATCH_RTDEV is not specified, the test case fails at
"_require_block_device $SCRATCH_RTDEV". To confirm the requirement, the
test case calls the helper function _require_realtime(). However, it
does not check SCRATCH_RTDEV when the zone type of SCRATCH_DEV is
'none'.
To avoid the failure, ensure the SCRATCH_RTDEV check by calling
_require_external_realtime_device() instead of _require_realtime(). With
this, the test case is skipped when SCRATCH_RTDEV is not specified
regardless of the zone type of SCRATCH_DEV.
Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
---
tests/xfs/333 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xfs/333 b/tests/xfs/333
index f2d4077d..7235dc24 100755
--- a/tests/xfs/333
+++ b/tests/xfs/333
@@ -16,7 +16,7 @@ _begin_fstest auto quick rw zone eio
_require_debugfs
_require_scratch_nocheck
-_require_realtime
+_require_external_realtime_device
_require_block_device $SCRATCH_RTDEV
_require_zoned_device $SCRATCH_RTDEV
_require_command "$BLKZONE_PROG" blkzone
--
2.54.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs/333: require external scratch device
2026-07-16 1:37 [PATCH] xfs/333: require external scratch device Shin'ichiro Kawasaki
@ 2026-07-16 6:28 ` Yao Sang
2026-07-16 8:17 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Yao Sang @ 2026-07-16 6:28 UTC (permalink / raw)
To: shinichiro.kawasaki; +Cc: fstests, hch, linux-xfs, sangyao, zlang
Looks good to me.
Reviewed-by: Yao Sang <sangyao@kylinos.cn>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs/333: require external scratch device
2026-07-16 1:37 [PATCH] xfs/333: require external scratch device Shin'ichiro Kawasaki
2026-07-16 6:28 ` Yao Sang
@ 2026-07-16 8:17 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2026-07-16 8:17 UTC (permalink / raw)
To: Shin'ichiro Kawasaki
Cc: fstests, Zorro Lang, linux-xfs, Yao Sang, Christoph Hellwig
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-16 8:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-16 1:37 [PATCH] xfs/333: require external scratch device Shin'ichiro Kawasaki
2026-07-16 6:28 ` Yao Sang
2026-07-16 8:17 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.