Re: [PATCH V4 1/3] arm64: dts: qcom: monaco: Move eMMC CQE support from SoC to board DT

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The 'supports-cqe' property was removed from the common SoC DTSI but was not added to the 'monaco-evk.dts' board, silently breaking its eMMC CQE support.
--

--- Patch [1]: [PATCH V4 1/3] arm64: dts: qcom: monaco: Move eMMC CQE support from SoC to board DT ---
commit 37093e152f8a2bb5db199eff4358061ebc24561c
Author: Monish Chunara <monish.chunara@oss.qualcomm.com>

arm64: dts: qcom: monaco: Move eMMC CQE support from SoC to board DT

This commit removes the supports-cqe property from the common Monaco SoC
device tree to prevent conflicts with SD card operation. It explicitly adds
the property back to the qcs8300-ride and monaco-monza-som board device
trees to maintain eMMC Command Queue Engine (CQE) support.

> diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qcom/monaco.dtsi
> index 7b1d57460f1e6..e5f316897706b 100644
> --- a/arch/arm64/boot/dts/qcom/monaco.dtsi
> +++ b/arch/arm64/boot/dts/qcom/monaco.dtsi
[ ... ]
> @@ -4828,7 +4828,6 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
>  			qcom,dll-config = <0x000f64ee>;
>  			qcom,ddr-config = <0x80040868>;
>  			bus-width = <8>;
> -			supports-cqe;

[Severity: Medium]
By removing this property from the common SoC DTSI, does the monaco-evk
board lose CQE support?

Looking at arch/arm64/boot/dts/qcom/monaco-evk.dts, it configures &sdhc_1
in strict eMMC mode:

&sdhc_1 {
        vmmc-supply = <&vreg_l8a>;
        vqmmc-supply = <&vreg_s2s>;

        no-sd;
        no-sdio;
        non-removable;

        status = "okay";
};

Since the EVK relies on the base DTSI for CQE support, and supports-cqe
was not explicitly added to monaco-evk.dts in this patch, it seems the eMMC
driver will fall back to legacy single-command mode on the EVK board.

>  			dma-coherent;
>  
>  			mmc-ddr-1_8v;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716142445.2767955-1-monish.chunara@oss.qualcomm.com?part=1