From: sashiko-bot@kernel.org
To: "Monish Chunara" <monish.chunara@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH V4 3/3] arm64: dts: qcom: monaco-evk: Add SDHCI support for eMMC via overlay
Date: Thu, 16 Jul 2026 14:35:53 +0000 [thread overview]
Message-ID: <20260716143554.3AD711F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260716142445.2767955-4-monish.chunara@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Alphabetical sorting violation in the Makefile.
--
--- Patch [3]: [PATCH V4 3/3] arm64: dts: qcom: monaco-evk: Add SDHCI support for eMMC via overlay ---
Note: The format of this report has been altered to use a free-form summary
instead of inline diff quoting due to strict recitation restrictions.
commit 9c47ebd2f8bd209fc994d382b210d2c4b6160e02
Author: Monish Chunara <monish.chunara@oss.qualcomm.com>
arm64: dts: qcom: monaco-evk: Add SDHCI support for eMMC via overlay
This commit enables the SDHCI controller for eMMC functionality on the
Monaco EVK by adding a device tree overlay.
[Severity: Low]
This isn't a bug, but does the placement of the new monaco-evk-emmc targets
in arch/arm64/boot/dts/qcom/Makefile break the alphabetical sorting?
The Makefile generally maintains DTB targets in strict alphabetical order.
The new monaco-evk-emmc targets were appended after the monaco-evk-sd-card
entries. Since 'e' comes before 'i' and 's', shouldn't the new entries be
placed before monaco-evk-ifp-mezzanine? Keeping the list sorted helps avoid
merge conflicts in the future.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260716142445.2767955-1-monish.chunara@oss.qualcomm.com?part=3
prev parent reply other threads:[~2026-07-16 14:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 14:24 [PATCH V4 0/3] arm64: dts: qcom: Monaco: Enable SDHCI storage support Monish Chunara
2026-07-16 14:24 ` [PATCH V4 1/3] arm64: dts: qcom: monaco: Move eMMC CQE support from SoC to board DT Monish Chunara
2026-07-16 14:35 ` sashiko-bot
2026-07-16 14:24 ` [PATCH V4 2/3] arm64: dts: qcom: monaco-evk: Enable SDHCI for SD Card via overlay Monish Chunara
2026-07-16 14:40 ` sashiko-bot
2026-07-16 14:24 ` [PATCH V4 3/3] arm64: dts: qcom: monaco-evk: Add SDHCI support for eMMC " Monish Chunara
2026-07-16 14:35 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260716143554.3AD711F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=monish.chunara@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.