Re: [PATCH v6 3/6] arm64: dts: qcom: Add device tree for Nord Embedded variant

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Invalid device tree `status` property value "enabled" prevents the `&crypto` node from probing.
--

--- Patch [3]: [PATCH v6 3/6] arm64: dts: qcom: Add device tree for Nord Embedded variant ---
commit bb92e843e0b413bc8193740b6bfb7dcde39b45b0
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>

arm64: dts: qcom: Add device tree for Nord Embedded variant

This commit adds a new device tree file nord-embedded.dtsi for the Nord
Embedded variant. It extends the base nord.dtsi with specific platform
resources and peripheral wiring directly controlled by the OS.

> diff --git a/arch/arm64/boot/dts/qcom/nord-embedded.dtsi b/arch/arm64/boot/dts/qcom/nord-embedded.dtsi
> new file mode 100644
> index 0000000000000..1ec32c2f2308a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/nord-embedded.dtsi

[ ... ]

> +&crypto {
> +	interconnects = <&aggre1_noc_tile MASTER_CRYPTO_CORE0 QCOM_ICC_TAG_ALWAYS
> +			 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
> +	interconnect-names = "memory";
> +
> +	status = "enabled";

[Severity: Medium]
Is this status value correct? The Linux OF core (__of_device_is_available)
strictly expects "okay" or "ok" for the status property to consider a device
available.

Using "enabled" here will cause the node to be treated as disabled, and the
crypto device will be ignored by the kernel. Should this be changed to
"okay"?

> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716142605.2398433-1-shengchao.guo@oss.qualcomm.com?part=3