All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: linux-kernel-dev@aliel.fr
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Andi Shyti <andi.shyti@kernel.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Beniamino Galvani <b.galvani@gmail.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@kernel.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Lukasz Luba <lukasz.luba@arm.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v8 0/8] Add VIM4 MCU/FAN support
Date: Thu, 16 Jul 2026 16:24:20 +0100	[thread overview]
Message-ID: <20260716152420.GA1424265@google.com> (raw)
In-Reply-To: <20260702-add-mcu-fan-khadas-vim4-v8-0-244feee91a36@aliel.fr>

On Thu, 02 Jul 2026, Ronald Claveau via B4 Relay wrote:

> The Khadas VIM4 board features a different MCU variant compared to
> previous VIM boards.
> While it shares the same I2C-based communication model,
> it differs in some ways:
> 
>   - A distinct register map with its own volatile/writeable register set
>   - A fan control with 0–100 levels instead of the 0–3 levels previously
>   - A fan power supply gated through a regulator
> 
> This series adds support for this new variant by:
> 
>   1. Refactoring the khadas-mcu MFD driver to use per-variant data
>      structures (regmap config, cells, fan platform data),
>      and adding the khadas,vim4-mcu compatible string.
> 
>   2. Extending the fan thermal driver to retrieve the fan register
>      and maximum level from platform_data,
>      and to optionally manage a power regulator for the fan supply.
> 
>   3. Adding the corresponding DTS node for the VIM4, wiring the MCU to
>      the I2C AO_A bus and exposing it as a thermal cooling device.
> 
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>

The MFD parts look okay.

I think the Thermal driver has a dep on us, right?

If so, let me know when you have the Acks and I'll merge it.

-- 
Lee Jones

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: linux-kernel-dev@aliel.fr
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Andi Shyti <andi.shyti@kernel.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Beniamino Galvani <b.galvani@gmail.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@kernel.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Lukasz Luba <lukasz.luba@arm.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v8 0/8] Add VIM4 MCU/FAN support
Date: Thu, 16 Jul 2026 16:24:20 +0100	[thread overview]
Message-ID: <20260716152420.GA1424265@google.com> (raw)
In-Reply-To: <20260702-add-mcu-fan-khadas-vim4-v8-0-244feee91a36@aliel.fr>

On Thu, 02 Jul 2026, Ronald Claveau via B4 Relay wrote:

> The Khadas VIM4 board features a different MCU variant compared to
> previous VIM boards.
> While it shares the same I2C-based communication model,
> it differs in some ways:
> 
>   - A distinct register map with its own volatile/writeable register set
>   - A fan control with 0–100 levels instead of the 0–3 levels previously
>   - A fan power supply gated through a regulator
> 
> This series adds support for this new variant by:
> 
>   1. Refactoring the khadas-mcu MFD driver to use per-variant data
>      structures (regmap config, cells, fan platform data),
>      and adding the khadas,vim4-mcu compatible string.
> 
>   2. Extending the fan thermal driver to retrieve the fan register
>      and maximum level from platform_data,
>      and to optionally manage a power regulator for the fan supply.
> 
>   3. Adding the corresponding DTS node for the VIM4, wiring the MCU to
>      the I2C AO_A bus and exposing it as a thermal cooling device.
> 
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>

The MFD parts look okay.

I think the Thermal driver has a dep on us, right?

If so, let me know when you have the Acks and I'll merge it.

-- 
Lee Jones

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  parent reply	other threads:[~2026-07-16 15:24 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02  9:55 [PATCH v8 0/8] Add VIM4 MCU/FAN support Ronald Claveau via B4 Relay
2026-07-02  9:55 ` Ronald Claveau
2026-07-02  9:55 ` Ronald Claveau via B4 Relay
2026-07-02  9:55 ` [PATCH v8 1/8] dt-bindings: mfd: khadas: Add new compatible for Khadas VIM4 MCU Ronald Claveau via B4 Relay
2026-07-02  9:55   ` Ronald Claveau
2026-07-02  9:55   ` Ronald Claveau via B4 Relay
2026-07-02  9:55 ` [PATCH v8 2/8] dt-bindings: i2c: amlogic: Add compatible for T7 SOC Ronald Claveau via B4 Relay
2026-07-02  9:55   ` Ronald Claveau
2026-07-02  9:55   ` Ronald Claveau via B4 Relay
2026-07-02  9:55 ` [PATCH v8 3/8] mfd: khadas-mcu: Add per-variant configuration infrastructure and VIM4 support Ronald Claveau via B4 Relay
2026-07-02  9:55   ` Ronald Claveau
2026-07-02  9:55   ` Ronald Claveau via B4 Relay
2026-07-02  9:55 ` [PATCH v8 4/8] mfd: khadas-mcu: Add support for VIM4 MCU variant Ronald Claveau via B4 Relay
2026-07-02  9:55   ` Ronald Claveau
2026-07-02  9:55   ` Ronald Claveau via B4 Relay
2026-07-02  9:55 ` [PATCH v8 5/8] thermal: khadas-mcu-fan: Add fan config from platform data Add regulator support Ronald Claveau via B4 Relay
2026-07-02  9:55   ` Ronald Claveau
2026-07-02  9:55   ` Ronald Claveau via B4 Relay
2026-07-02  9:55 ` [PATCH v8 6/8] arm64: dts: amlogic: t7: Add i2c pinctrl node Ronald Claveau via B4 Relay
2026-07-02  9:55   ` Ronald Claveau
2026-07-02  9:55   ` Ronald Claveau via B4 Relay
2026-07-02  9:56 ` [PATCH v8 7/8] arm64: dts: amlogic: t7: Add i2c controller node Ronald Claveau via B4 Relay
2026-07-02  9:56   ` Ronald Claveau
2026-07-02  9:56   ` Ronald Claveau via B4 Relay
2026-07-07 19:43   ` Martin Blumenstingl
2026-07-07 19:43     ` Martin Blumenstingl
2026-07-02  9:56 ` [PATCH v8 8/8] arm64: dts: amlogic: t7: khadas-vim4: Add i2c MCU fan node Ronald Claveau via B4 Relay
2026-07-02  9:56   ` Ronald Claveau
2026-07-02  9:56   ` Ronald Claveau via B4 Relay
2026-07-07 19:44   ` Martin Blumenstingl
2026-07-07 19:44     ` Martin Blumenstingl
2026-07-08 13:42 ` [PATCH v8 0/8] Add VIM4 MCU/FAN support Daniel Lezcano
2026-07-08 13:42   ` Daniel Lezcano
2026-07-16 15:24 ` Lee Jones [this message]
2026-07-16 15:24   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260716152420.GA1424265@google.com \
    --to=lee@kernel.org \
    --cc=andi.shyti@kernel.org \
    --cc=b.galvani@gmail.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=daniel.lezcano@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel-dev@aliel.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.