* [android-common:android-mainline 0/1] drivers/staging/android/ashmem-legacy.c:397:31: warning: variable 'inode' set but not used
@ 2026-07-16 8:56 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-07-16 8:56 UTC (permalink / raw)
To: cros-kernel-buildreports; +Cc: oe-kbuild-all
Hi Isaac,
FYI, the error/warning still remains.
tree: https://android.googlesource.com/kernel/common android-mainline
head: 2a04d824962f1bf2703a8ff94d7c5ee5f6b541b7
commit: 97f1681cbca0ccce07e5c9ef0b450ea340867291 [0/1] ANDROID: staging: ashmem: Cleanup kconfig options and rename source files
config: i386-buildonly-randconfig-001 (https://download.01.org/0day-ci/archive/20260716/202607161631.0n2wMAjo-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260716/202607161631.0n2wMAjo-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202607161631.0n2wMAjo-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/staging/android/ashmem-legacy.c: In function 'ashmem_mmap':
>> drivers/staging/android/ashmem-legacy.c:397:31: warning: variable 'inode' set but not used [-Wunused-but-set-variable]
397 | struct inode *inode;
| ^~~~~
vim +/inode +397 drivers/staging/android/ashmem-legacy.c
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 365
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 366 static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 367 {
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 368 static struct file_operations vmfile_fops;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 369 struct ashmem_area *asma = file->private_data;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 370 int ret = 0;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 371
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 372 mutex_lock(&ashmem_mutex);
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 373
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 374 /* user needs to SET_SIZE before mapping */
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 375 if (!asma->size) {
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 376 ret = -EINVAL;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 377 goto out;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 378 }
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 379
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 380 /* requested mapping size larger than object size */
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 381 if (vma->vm_end - vma->vm_start > PAGE_ALIGN(asma->size)) {
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 382 ret = -EINVAL;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 383 goto out;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 384 }
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 385
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 386 /* requested protection bits must match our allowed protection mask */
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 387 if ((vma->vm_flags & ~calc_vm_prot_bits(asma->prot_mask, 0)) &
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 388 calc_vm_prot_bits(PROT_MASK, 0)) {
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 389 ret = -EPERM;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 390 goto out;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 391 }
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 392 vm_flags_clear(vma, calc_vm_may_flags(~asma->prot_mask));
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 393
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 394 if (!asma->file) {
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 395 char *name = ASHMEM_NAME_DEF;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 396 struct file *vmfile;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 @397 struct inode *inode;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 398
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 399 if (asma->name[ASHMEM_NAME_PREFIX_LEN] != '\0')
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 400 name = asma->name;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 401
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 402 /* ... and allocate the backing shmem file */
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 403 vmfile = shmem_file_setup(name, asma->size, vma->vm_flags);
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 404 if (IS_ERR(vmfile)) {
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 405 ret = PTR_ERR(vmfile);
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 406 goto out;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 407 }
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 408 vmfile->f_mode |= FMODE_LSEEK;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 409 inode = file_inode(vmfile);
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 410 lockdep_set_class(&inode->i_rwsem, &backing_shmem_inode_class);
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 411 asma->file = vmfile;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 412 /*
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 413 * override mmap operation of the vmfile so that it can't be
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 414 * remapped which would lead to creation of a new vma with no
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 415 * asma permission checks. Have to override get_unmapped_area
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 416 * as well to prevent VM_BUG_ON check for f_ops modification.
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 417 */
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 418 if (!vmfile_fops.mmap) {
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 419 vmfile_fops = *vmfile->f_op;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 420 vmfile_fops.mmap = ashmem_vmfile_mmap;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 421 vmfile_fops.get_unmapped_area = mm_get_unmapped_area;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 422 }
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 423 vmfile->f_op = &vmfile_fops;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 424 }
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 425 get_file(asma->file);
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 426
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 427 /*
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 428 * XXX - Reworked to use shmem_zero_setup() instead of
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 429 * shmem_set_file while we're in staging. -jstultz
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 430 */
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 431 if (vma->vm_flags & VM_SHARED) {
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 432 ret = shmem_zero_setup(vma);
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 433 if (ret) {
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 434 fput(asma->file);
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 435 goto out;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 436 }
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 437 } else {
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 438 vma_set_anonymous(vma);
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 439 }
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 440
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 441 vma_set_file(vma, asma->file);
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 442 /* XXX: merge this with the get_file() above if possible */
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 443 fput(asma->file);
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 444
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 445 out:
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 446 mutex_unlock(&ashmem_mutex);
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 447 return ret;
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 448 }
4b3275bbb3dda0 drivers/staging/android/ashmem.c Isaac J. Manjarres 2026-03-26 449
:::::: The code at line 397 was first introduced by commit
:::::: 4b3275bbb3dda0062c3ba6146b6f56a9234c64da Revert "ANDROID: ashmem: Remove C version of the ashmem driver"
:::::: TO: Isaac J. Manjarres <isaacmanjarres@google.com>
:::::: CC: Treehugger Robot <android-test-infra-autosubmit@system.gserviceaccount.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-07-16 8:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-16 8:56 [android-common:android-mainline 0/1] drivers/staging/android/ashmem-legacy.c:397:31: warning: variable 'inode' set but not used kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.