All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
	"Yixun Lan" <dlan@kernel.org>,
	"Ping-Ke Shih" <pkshih@realtek.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Inochi Amaoto" <inochiama@gmail.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI: Move Spacemit vendor and device ID to linux/pci_Ids.h
Date: Thu, 16 Jul 2026 11:43:36 -0500	[thread overview]
Message-ID: <20260716164336.GA40813@bhelgaas> (raw)
In-Reply-To: <20260715-rtw89-spacemit-k3-v1-1-e577bc63706b@oss.tenstorrent.com>

On Wed, Jul 15, 2026 at 10:21:54PM -0500, Anirudh Srinivasan wrote:
> Move the vendor and device IDs for Spacemit PCIe Root Complexes to
> include/linux/pci_ids.h so that they can be referenced elsewhere.
> 
> Signed-off-by: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

To help motivate this patch, it would be nice to say specifically
where PCI_VENDOR_ID_SPACEMIT will be used.

In subject line, s/pci_Ids.h/pci_ids.h/

> ---
>  drivers/pci/controller/dwc/pcie-spacemit-k1.c | 4 ----
>  include/linux/pci_ids.h                       | 4 ++++
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-spacemit-k1.c b/drivers/pci/controller/dwc/pcie-spacemit-k1.c
> index 680acc93f5395..7b0bc1802954a 100644
> --- a/drivers/pci/controller/dwc/pcie-spacemit-k1.c
> +++ b/drivers/pci/controller/dwc/pcie-spacemit-k1.c
> @@ -21,10 +21,6 @@
>  
>  #include "pcie-designware.h"
>  
> -#define PCI_VENDOR_ID_SPACEMIT		0x201f
> -#define PCI_DEVICE_ID_SPACEMIT_K1	0x0001
> -#define PCI_DEVICE_ID_SPACEMIT_K3	0x0002
> -
>  /* Offsets and field definitions for link management registers */
>  #define K1_PHY_AHB_IRQ_EN			0x0000
>  #define PCIE_INTERRUPT_EN		BIT(0)
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 1c9d40e09107d..d6f26cacc8e35 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2640,6 +2640,10 @@
>  #define PCI_VENDOR_ID_SUNIX		0x1fd4
>  #define PCI_DEVICE_ID_SUNIX_1999	0x1999
>  
> +#define PCI_VENDOR_ID_SPACEMIT		0x201f
> +#define PCI_DEVICE_ID_SPACEMIT_K1	0x0001
> +#define PCI_DEVICE_ID_SPACEMIT_K3	0x0002
> +
>  #define PCI_VENDOR_ID_HINT             0x3388
>  #define PCI_DEVICE_ID_HINT_VXPROII_IDE 0x8013
>  
> 
> -- 
> 2.43.0
> 

WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
	"Yixun Lan" <dlan@kernel.org>,
	"Ping-Ke Shih" <pkshih@realtek.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Inochi Amaoto" <inochiama@gmail.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI: Move Spacemit vendor and device ID to linux/pci_Ids.h
Date: Thu, 16 Jul 2026 11:43:36 -0500	[thread overview]
Message-ID: <20260716164336.GA40813@bhelgaas> (raw)
In-Reply-To: <20260715-rtw89-spacemit-k3-v1-1-e577bc63706b@oss.tenstorrent.com>

On Wed, Jul 15, 2026 at 10:21:54PM -0500, Anirudh Srinivasan wrote:
> Move the vendor and device IDs for Spacemit PCIe Root Complexes to
> include/linux/pci_ids.h so that they can be referenced elsewhere.
> 
> Signed-off-by: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

To help motivate this patch, it would be nice to say specifically
where PCI_VENDOR_ID_SPACEMIT will be used.

In subject line, s/pci_Ids.h/pci_ids.h/

> ---
>  drivers/pci/controller/dwc/pcie-spacemit-k1.c | 4 ----
>  include/linux/pci_ids.h                       | 4 ++++
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-spacemit-k1.c b/drivers/pci/controller/dwc/pcie-spacemit-k1.c
> index 680acc93f5395..7b0bc1802954a 100644
> --- a/drivers/pci/controller/dwc/pcie-spacemit-k1.c
> +++ b/drivers/pci/controller/dwc/pcie-spacemit-k1.c
> @@ -21,10 +21,6 @@
>  
>  #include "pcie-designware.h"
>  
> -#define PCI_VENDOR_ID_SPACEMIT		0x201f
> -#define PCI_DEVICE_ID_SPACEMIT_K1	0x0001
> -#define PCI_DEVICE_ID_SPACEMIT_K3	0x0002
> -
>  /* Offsets and field definitions for link management registers */
>  #define K1_PHY_AHB_IRQ_EN			0x0000
>  #define PCIE_INTERRUPT_EN		BIT(0)
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 1c9d40e09107d..d6f26cacc8e35 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2640,6 +2640,10 @@
>  #define PCI_VENDOR_ID_SUNIX		0x1fd4
>  #define PCI_DEVICE_ID_SUNIX_1999	0x1999
>  
> +#define PCI_VENDOR_ID_SPACEMIT		0x201f
> +#define PCI_DEVICE_ID_SPACEMIT_K1	0x0001
> +#define PCI_DEVICE_ID_SPACEMIT_K3	0x0002
> +
>  #define PCI_VENDOR_ID_HINT             0x3388
>  #define PCI_DEVICE_ID_HINT_VXPROII_IDE 0x8013
>  
> 
> -- 
> 2.43.0
> 

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2026-07-16 16:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16  3:21 [PATCH 0/2] Enable WiFi on Spacemit K3 Pico ITX Anirudh Srinivasan
2026-07-16  3:21 ` Anirudh Srinivasan
2026-07-16  3:21 ` [PATCH 1/2] PCI: Move Spacemit vendor and device ID to linux/pci_Ids.h Anirudh Srinivasan
2026-07-16  3:21   ` Anirudh Srinivasan
2026-07-16 16:43   ` Bjorn Helgaas [this message]
2026-07-16 16:43     ` Bjorn Helgaas
2026-07-16  3:21 ` [PATCH 2/2] wifi: rtw89: pci: enable 36-bit DMA on spacemit K3 Anirudh Srinivasan
2026-07-16  3:21   ` Anirudh Srinivasan
2026-07-16  9:22   ` Ping-Ke Shih
2026-07-16  9:22     ` Ping-Ke Shih
2026-07-16 22:23     ` Inochi Amaoto
2026-07-16 22:23       ` Inochi Amaoto
2026-07-16 22:27       ` Anirudh Srinivasan
2026-07-16 22:27         ` Anirudh Srinivasan
2026-07-16 21:34   ` Aurelien Jarno
2026-07-16 21:34     ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260716164336.GA40813@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=asrinivasan@oss.tenstorrent.com \
    --cc=bhelgaas@google.com \
    --cc=dlan@kernel.org \
    --cc=inochiama@gmail.com \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=pkshih@realtek.com \
    --cc=robh@kernel.org \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.