Re: [PATCH 13/24] KVM: Introduce kvm_check_gen()/kvm_memslots_check_gen()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The refactoring to use the new `kvm_check_gen()` helper was not applied to `arch/loongarch/kvm/vcpu.c`.
--

--- Patch [13]: [PATCH 13/24] KVM: Introduce kvm_check_gen()/kvm_memslots_check_gen() ---
commit 80a164bf326fe8a6112aa42a54b4beddb26e73c6
Author: Paolo Bonzini <pbonzini@redhat.com>

KVM: Introduce kvm_check_gen()/kvm_memslots_check_gen()

This commit introduces kvm_check_gen() and kvm_memslots_check_gen() helper
functions to combine retrieving kvm_memslots and checking the generation of
the slots. It refactors several sites in x86 and core KVM code to use the
new helpers.

> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index e2240f817c22e..58f544df47e14 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -2032,7 +2032,6 @@ static void record_steal_time(struct kvm_vcpu *vcpu)
[ ... ]
> -	slots = kvm_memslots(vcpu->kvm);
> -
> -	if (unlikely(slots->generation != ghc->generation ||
> +	if (unlikely(!kvm_check_gen(vcpu->kvm, ghc->generation) ||
>  		     gpa != ghc->gpa ||
>  		     kvm_is_error_hva(ghc->hva) || !ghc->memslot)) {

[Severity: Low]
Should arch/loongarch/kvm/vcpu.c also be updated to use this new helper?

It looks like kvm_update_stolen_time() and kvm_vcpu_set_pv_preempted() in
that file still use the old pattern:

arch/loongarch/kvm/vcpu.c:kvm_update_stolen_time() {
    ...
    slots = kvm_memslots(vcpu->kvm);
    if (slots->generation != ghc->generation || gpa != ghc->gpa) {
    ...
}

Does LoongArch need similar updates to maintain consistency across the
codebase?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716181456.402786-1-pbonzini@redhat.com?part=13