* drivers/firmware/efi/ovmf-debug-log.c:94 ovmf_log_probe() warn: missing unwind goto?
@ 2025-08-13 6:44 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2025-08-13 6:44 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Gerd Hoffmann <kraxel@redhat.com>
CC: Ard Biesheuvel <ardb@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 8742b2d8935f476449ef37e263bc4da3295c7b58
commit: f393a761763c542761abcf978252d431269366d6 efi: add ovmf debug log driver
date: 5 weeks ago
:::::: branch date: 11 hours ago
:::::: commit date: 5 weeks ago
config: x86_64-randconfig-161-20250813 (https://download.01.org/0day-ci/archive/20250813/202508131440.KXL63uuM-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202508131440.KXL63uuM-lkp@intel.com/
smatch warnings:
drivers/firmware/efi/ovmf-debug-log.c:94 ovmf_log_probe() warn: missing unwind goto?
vim +94 drivers/firmware/efi/ovmf-debug-log.c
f393a761763c54 Gerd Hoffmann 2025-07-08 66
f393a761763c54 Gerd Hoffmann 2025-07-08 67 int __init ovmf_log_probe(unsigned long ovmf_debug_log_table)
f393a761763c54 Gerd Hoffmann 2025-07-08 68 {
f393a761763c54 Gerd Hoffmann 2025-07-08 69 int ret = -EINVAL;
f393a761763c54 Gerd Hoffmann 2025-07-08 70 u64 size;
f393a761763c54 Gerd Hoffmann 2025-07-08 71
f393a761763c54 Gerd Hoffmann 2025-07-08 72 /* map + verify header */
f393a761763c54 Gerd Hoffmann 2025-07-08 73 hdr = memremap(ovmf_debug_log_table, sizeof(*hdr), MEMREMAP_WB);
f393a761763c54 Gerd Hoffmann 2025-07-08 74 if (!hdr) {
f393a761763c54 Gerd Hoffmann 2025-07-08 75 pr_err("OVMF debug log: header map failed\n");
f393a761763c54 Gerd Hoffmann 2025-07-08 76 return -EINVAL;
f393a761763c54 Gerd Hoffmann 2025-07-08 77 }
f393a761763c54 Gerd Hoffmann 2025-07-08 78
f393a761763c54 Gerd Hoffmann 2025-07-08 79 if (hdr->magic1 != OVMF_DEBUG_LOG_MAGIC1 ||
f393a761763c54 Gerd Hoffmann 2025-07-08 80 hdr->magic2 != OVMF_DEBUG_LOG_MAGIC2) {
f393a761763c54 Gerd Hoffmann 2025-07-08 81 printk(KERN_ERR "OVMF debug log: magic mismatch\n");
f393a761763c54 Gerd Hoffmann 2025-07-08 82 goto err_unmap;
f393a761763c54 Gerd Hoffmann 2025-07-08 83 }
f393a761763c54 Gerd Hoffmann 2025-07-08 84
f393a761763c54 Gerd Hoffmann 2025-07-08 85 size = hdr->hdr_size + hdr->log_size;
f393a761763c54 Gerd Hoffmann 2025-07-08 86 pr_info("OVMF debug log: firmware version: \"%s\"\n", hdr->fw_version);
f393a761763c54 Gerd Hoffmann 2025-07-08 87 pr_info("OVMF debug log: buffer size: %lluk\n", size / 1024);
f393a761763c54 Gerd Hoffmann 2025-07-08 88
f393a761763c54 Gerd Hoffmann 2025-07-08 89 /* map complete log buffer */
f393a761763c54 Gerd Hoffmann 2025-07-08 90 memunmap(hdr);
f393a761763c54 Gerd Hoffmann 2025-07-08 91 hdr = memremap(ovmf_debug_log_table, size, MEMREMAP_WB);
f393a761763c54 Gerd Hoffmann 2025-07-08 92 if (!hdr) {
f393a761763c54 Gerd Hoffmann 2025-07-08 93 pr_err("OVMF debug log: buffer map failed\n");
f393a761763c54 Gerd Hoffmann 2025-07-08 @94 return -EINVAL;
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* drivers/firmware/efi/ovmf-debug-log.c:94 ovmf_log_probe() warn: missing unwind goto?
@ 2026-07-16 11:15 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2026-07-16 11:15 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Gerd Hoffmann <kraxel@redhat.com>
CC: Ard Biesheuvel <ardb@kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 58717b2a1365d06c8c64b72aa948541b53fe31eb
commit: f393a761763c542761abcf978252d431269366d6 efi: add ovmf debug log driver
date: 1 year ago
:::::: branch date: 2 days ago
:::::: commit date: 1 year ago
config: x86_64-randconfig-161-20260716 (https://download.01.org/0day-ci/archive/20260716/202607161915.8leT0vlf-lkp@intel.com/config)
compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211)
smatch: v0.5.0-9185-gbcc58b9c
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: f393a761763c ("efi: add ovmf debug log driver")
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202607161915.8leT0vlf-lkp@intel.com/
smatch warnings:
drivers/firmware/efi/ovmf-debug-log.c:94 ovmf_log_probe() warn: missing unwind goto?
vim +94 drivers/firmware/efi/ovmf-debug-log.c
f393a761763c54 Gerd Hoffmann 2025-07-08 66
f393a761763c54 Gerd Hoffmann 2025-07-08 67 int __init ovmf_log_probe(unsigned long ovmf_debug_log_table)
f393a761763c54 Gerd Hoffmann 2025-07-08 68 {
f393a761763c54 Gerd Hoffmann 2025-07-08 69 int ret = -EINVAL;
f393a761763c54 Gerd Hoffmann 2025-07-08 70 u64 size;
f393a761763c54 Gerd Hoffmann 2025-07-08 71
f393a761763c54 Gerd Hoffmann 2025-07-08 72 /* map + verify header */
f393a761763c54 Gerd Hoffmann 2025-07-08 73 hdr = memremap(ovmf_debug_log_table, sizeof(*hdr), MEMREMAP_WB);
f393a761763c54 Gerd Hoffmann 2025-07-08 74 if (!hdr) {
f393a761763c54 Gerd Hoffmann 2025-07-08 75 pr_err("OVMF debug log: header map failed\n");
f393a761763c54 Gerd Hoffmann 2025-07-08 76 return -EINVAL;
f393a761763c54 Gerd Hoffmann 2025-07-08 77 }
f393a761763c54 Gerd Hoffmann 2025-07-08 78
f393a761763c54 Gerd Hoffmann 2025-07-08 79 if (hdr->magic1 != OVMF_DEBUG_LOG_MAGIC1 ||
f393a761763c54 Gerd Hoffmann 2025-07-08 80 hdr->magic2 != OVMF_DEBUG_LOG_MAGIC2) {
f393a761763c54 Gerd Hoffmann 2025-07-08 81 printk(KERN_ERR "OVMF debug log: magic mismatch\n");
f393a761763c54 Gerd Hoffmann 2025-07-08 82 goto err_unmap;
f393a761763c54 Gerd Hoffmann 2025-07-08 83 }
f393a761763c54 Gerd Hoffmann 2025-07-08 84
f393a761763c54 Gerd Hoffmann 2025-07-08 85 size = hdr->hdr_size + hdr->log_size;
f393a761763c54 Gerd Hoffmann 2025-07-08 86 pr_info("OVMF debug log: firmware version: \"%s\"\n", hdr->fw_version);
f393a761763c54 Gerd Hoffmann 2025-07-08 87 pr_info("OVMF debug log: buffer size: %lluk\n", size / 1024);
f393a761763c54 Gerd Hoffmann 2025-07-08 88
f393a761763c54 Gerd Hoffmann 2025-07-08 89 /* map complete log buffer */
f393a761763c54 Gerd Hoffmann 2025-07-08 90 memunmap(hdr);
f393a761763c54 Gerd Hoffmann 2025-07-08 91 hdr = memremap(ovmf_debug_log_table, size, MEMREMAP_WB);
f393a761763c54 Gerd Hoffmann 2025-07-08 92 if (!hdr) {
f393a761763c54 Gerd Hoffmann 2025-07-08 93 pr_err("OVMF debug log: buffer map failed\n");
f393a761763c54 Gerd Hoffmann 2025-07-08 @94 return -EINVAL;
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-16 11:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-16 11:15 drivers/firmware/efi/ovmf-debug-log.c:94 ovmf_log_probe() warn: missing unwind goto? kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2025-08-13 6:44 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.