Re: [PATCH 3/3] arm64: dts: rockchip: Keep rk3399-roc-pc-plus work LED on

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message describes the work LED as a "prominent blue front-panel status LED", but the patch fails to override the inherited "green:work" label, resulting in a code and commit message mismatch.
--

--- Patch [3]: [PATCH 3/3] arm64: dts: rockchip: Keep rk3399-roc-pc-plus work LED on ---
commit 7bd9a09829c15f03ac88e155bb13da9235dada8c
Author: Fabio Estevam <festevam@nabladev.com>

arm64: dts: rockchip: Keep rk3399-roc-pc-plus work LED on
    
This commit overrides the default LED trigger for the rk3399-roc-pc-plus
work LED to default-on. It changes the behavior from a distracting continuous
blink to a steady status indication.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts
> index f87bc7b6afc14..7e8039b19be7e 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts
> @@ -93,6 +93,10 @@ leds {
>  	};
>  };
>  
> +&work_led {
> +	linux,default-trigger = "default-on";
> +};

[Severity: Medium]
The commit message mentions this is the prominent blue front-panel status LED.
Since the board inherits from rk3399-roc-pc.dtsi where the work LED is
typically configured with the green:work label, does this node also need a
color or label override?

If the inherited label is not overridden here, the sysfs interface might
misrepresent the physical blue LED as green, causing a mismatch between the
commit message's description and the resulting device tree.

> +
>  &fusb0 {
>  	vbus-supply = <&vcc_vbus_typec1>;
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260717010736.578419-1-festevam@gmail.com?part=3