Re: [PATCH 2/3] arm64: dts: rockchip: Enable wireless on rk3399-roc-pc-plus

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Removing the shared 32kHz LPO clock from the SDIO power sequencer breaks Wi-Fi initialization when Bluetooth is disabled or probes later.
--

--- Patch [2]: [PATCH 2/3] arm64: dts: rockchip: Enable wireless on rk3399-roc-pc-plus ---
commit d6496a6030e5f440c56fb715094eff4f9078ed81
Author: Fabio Estevam <festevam@nabladev.com>

arm64: dts: rockchip: Enable wireless on rk3399-roc-pc-plus

This commit enables the Ampak AP6256 Wi-Fi/Bluetooth module on the
rk3399-roc-pc-plus board. It describes the SDIO and UART interfaces, adds
power sequencing delays, and removes the clock from the SDIO power sequencer
to allow the Bluetooth node to request it directly.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts
> index f6d62ee51f1b9..f87bc7b6afc14 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts

[ ... ]

> @@ -180,6 +198,28 @@ i2s_8ch_mclk_pin: i2s-8ch-mclk-pin {
>  	};
>  };
>  
> +&sdio_pwrseq {
> +	/delete-property/ clocks;
> +	/delete-property/ clock-names;

[Severity: High]
Will removing the shared 32kHz LPO clock from the SDIO power sequencer break
Wi-Fi initialization when Bluetooth is disabled or probes later?

If the MMC/SDIO subsystem initiates its power-on sequence before the Bluetooth
driver probes, or if Bluetooth is disabled, the LPO clock will not be enabled.
Without this clock, the Wi-Fi module cannot start its state machine and will
fail to respond to the initial CMD5 enumeration from the MMC core.

Additionally, if Bluetooth enters runtime suspend and gates the clock, could
this crash the active Wi-Fi firmware?

> +	post-power-on-delay-ms = <100>;
> +	power-off-delay-us = <500000>;
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260717010736.578419-1-festevam@gmail.com?part=2