Re: [PATCH v5 07/14] dmaengine: dw-edma-pcie: Add capability match data

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Missing pci_free_irq_vectors() cleanup on error paths in the probe function.
--

--- Patch [7]: [PATCH v5 07/14] dmaengine: dw-edma-pcie: Add capability match data ---
commit 352070c0889b8cd6fe579fca832e28f5f50ba2e5
Author: Koichiro Den <den@valinux.co.jp>

dmaengine: dw-edma-pcie: Add capability match data

This commit moves device-specific capability parsing behind per-device
match data to avoid mixing static templates with vendor checks. It splits
these decisions so device-specific discovery can be added through match
data instead of adding more vendor checks.

> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c

[ ... ]

> @@ -441,8 +477,8 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev,
>  			return -ENOMEM;

[Severity: High]
This is a pre-existing issue, but does this error path leak the IRQ vectors
allocated earlier in dw_edma_pcie_probe()?

If pcim_iomap_table() fails, we return -ENOMEM directly without calling
pci_free_irq_vectors(). Failing to free them can permanently reduce the
system's available IRQ capacity. Should these error paths be updated to
properly clean up the allocated IRQ vectors?

>  
>  		ll_region->vaddr.io += ll_block->off;
> -		ll_region->paddr = dw_edma_get_phys_addr(pdev, vsec_data,
> -							 ll_block->bar);
> +		ll_region->paddr = dw_edma_get_phys_addr(pdev, match,
> +							 vsec_data, ll_block->bar);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260717050308.2144108-1-den@valinux.co.jp?part=7