From: Rohitashv Kumar <rohit.kuma1313@gmail.com>
To: qemu-devel@nongnu.org
Cc: Fabiano Rosas <farosas@suse.de>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Rohitashv Kumar <roohiit@amazon.de>
Subject: [PATCH 0/3] tests/qtest: make PCI tests resilient to a compiled-out i440fx/pc machine
Date: Fri, 17 Jul 2026 08:18:33 +0000 [thread overview]
Message-ID: <20260717081845.2439849-1-rohit.kuma1313@gmail.com> (raw)
From: Rohitashv Kumar <roohiit@amazon.de>
QEMU can be built with the i440fx/pc machine type compiled out (for
example via a custom --with-devices-<arch> configuration that only keeps
the q35 machine). In that configuration a few qtests fail because they
hard-code "-machine pc" instead of checking whether the machine is
available.
This series makes the affected tests skip the pc-specific paths when the
"pc" machine is not compiled in, using the existing qtest_has_machine()
helper. There is intentionally NO behaviour change for a normal build
that includes i440fx/pc: the guards only take effect when "pc" is absent,
so existing CI coverage is unchanged.
For device-plug-test and drive_del-test the guard is placed inside the
x86-only branch that adds "-machine pc", so coverage on other
architectures (which use the default machine) is preserved, and x86
coverage is still provided by the existing q35 variants. For pxe-test the
per-row check mirrors the existing per-row qtest_has_device() guard, so
q35 rows keep running when pc is gone.
Tested by building QEMU with and without the i440fx/pc machine: with it
present all affected tests run as before; with CONFIG_I440FX=n the pc
cases skip instead of failing.
Rohitashv Kumar (3):
tests/qtest/device-plug-test: skip pc tests when 'pc' machine is
unavailable
tests/qtest/drive_del-test: skip pc tests when 'pc' machine is
unavailable
tests/qtest/pxe-test: skip per-row cases whose machine is unavailable
tests/qtest/device-plug-test.c | 8 ++++++++
tests/qtest/drive_del-test.c | 16 ++++++++++++++++
tests/qtest/pxe-test.c | 4 ++++
3 files changed, 28 insertions(+)
--
2.47.3
next reply other threads:[~2026-07-17 8:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 8:18 Rohitashv Kumar [this message]
2026-07-17 8:18 ` [PATCH 1/3] tests/qtest/device-plug-test: skip pc tests when 'pc' machine is unavailable Rohitashv Kumar
2026-07-17 8:18 ` [PATCH 2/3] tests/qtest/drive_del-test: " Rohitashv Kumar
2026-07-17 8:18 ` [PATCH 3/3] tests/qtest/pxe-test: skip per-row cases whose " Rohitashv Kumar
2026-08-19 13:12 ` [PATCH 0/3] tests/qtest: make PCI tests resilient to a compiled-out i440fx/pc machine Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717081845.2439849-1-rohit.kuma1313@gmail.com \
--to=rohit.kuma1313@gmail.com \
--cc=farosas@suse.de \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=roohiit@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.