From: Rohitashv Kumar <rohit.kuma1313@gmail.com>
To: qemu-devel@nongnu.org
Cc: Fabiano Rosas <farosas@suse.de>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Rohitashv Kumar <roohiit@amazon.de>
Subject: [PATCH 2/3] tests/qtest/drive_del-test: skip pc tests when 'pc' machine is unavailable
Date: Fri, 17 Jul 2026 08:18:35 +0000 [thread overview]
Message-ID: <20260717081845.2439849-3-rohit.kuma1313@gmail.com> (raw)
In-Reply-To: <20260717081845.2439849-1-rohit.kuma1313@gmail.com>
From: Rohitashv Kumar <roohiit@amazon.de>
test_cli_device_del(), test_device_add_and_del(),
test_drive_add_device_add_and_del() and
test_blockdev_add_device_add_and_del() use "-machine pc" on i386/x86_64.
When QEMU is built without the i440fx/pc machine, these fail with
"unsupported machine type 'pc'".
Skip the x86 case when 'pc' is not available. Non-x86 architectures use
the default machine and are unaffected, and the corresponding _q35
variants already cover x86 under qtest_has_machine("q35").
Signed-off-by: Rohitashv Kumar <roohiit@amazon.de>
---
tests/qtest/drive_del-test.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/tests/qtest/drive_del-test.c b/tests/qtest/drive_del-test.c
index 30d9451d..4c32da59 100644
--- a/tests/qtest/drive_del-test.c
+++ b/tests/qtest/drive_del-test.c
@@ -258,6 +258,10 @@ static void test_cli_device_del(void)
}
if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
+ if (!qtest_has_machine("pc")) {
+ g_test_skip("Machine 'pc' is not available");
+ return;
+ }
machine_addition = "-machine pc";
}
@@ -332,6 +336,10 @@ static void test_device_add_and_del(void)
}
if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
+ if (!qtest_has_machine("pc")) {
+ g_test_skip("Machine 'pc' is not available");
+ return;
+ }
machine_addition = "-machine pc";
}
@@ -403,6 +411,10 @@ static void test_drive_add_device_add_and_del(void)
}
if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
+ if (!qtest_has_machine("pc")) {
+ g_test_skip("Machine 'pc' is not available");
+ return;
+ }
machine_addition = "-machine pc";
}
@@ -456,6 +468,10 @@ static void test_blockdev_add_device_add_and_del(void)
}
if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
+ if (!qtest_has_machine("pc")) {
+ g_test_skip("Machine 'pc' is not available");
+ return;
+ }
machine_addition = "-machine pc";
}
--
2.47.3
next prev parent reply other threads:[~2026-07-17 8:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 8:18 [PATCH 0/3] tests/qtest: make PCI tests resilient to a compiled-out i440fx/pc machine Rohitashv Kumar
2026-07-17 8:18 ` [PATCH 1/3] tests/qtest/device-plug-test: skip pc tests when 'pc' machine is unavailable Rohitashv Kumar
2026-07-17 8:18 ` Rohitashv Kumar [this message]
2026-07-17 8:18 ` [PATCH 3/3] tests/qtest/pxe-test: skip per-row cases whose " Rohitashv Kumar
2026-08-19 13:12 ` [PATCH 0/3] tests/qtest: make PCI tests resilient to a compiled-out i440fx/pc machine Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717081845.2439849-3-rohit.kuma1313@gmail.com \
--to=rohit.kuma1313@gmail.com \
--cc=farosas@suse.de \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=roohiit@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.