From: Hongfu Li <hongfu.li@linux.dev>
To: ljs@kernel.org
Cc: akpm@linux-foundation.org, david@kernel.org, hongfu.li@linux.dev,
liam@infradead.org, lihongfu@kylinos.cn,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
mhocko@suse.com, rppt@kernel.org, surenb@google.com,
vbabka@kernel.org
Subject: Re: [PATCH] mm/folio-compat: Drop superfluous return statements in void compat wrappers
Date: Fri, 17 Jul 2026 18:31:13 +0800 [thread overview]
Message-ID: <20260717103113.95239-1-hongfu.li@linux.dev> (raw)
In-Reply-To: <alnpTDGBUqMOps1P@lucifer>
> > From: Hongfu Li <lihongfu@kylinos.cn>
> >
> > unlock_page(), end_page_writeback() and wait_on_page_writeback()
> > are void wrappers forwarding to folio-based functions which also
> > return void. Explicit return statements here are syntactically valid
> > but unnecessary, and inconsistent with other nearby compat helpers
> > such as mark_page_accessed() and set_page_writeback().
> >
> > Drop all these superfluous return keywords.
> >
> > Signed-off-by: Hongfu Li <lihongfu@kylinos.cn>
>
> LGTM so:
>
> Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
>
> I would ask that you maybe slow down on the flow of patches lately :) review is
> pretty overwhelmed atm.
Sorry about the heavy patch stream recently.
I'll space out my patch submissions to reduce review pressure.
Really appreciate your time and careful review.
Best regards,
Hongfu
prev parent reply other threads:[~2026-07-17 10:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 7:20 [PATCH] mm/folio-compat: Drop superfluous return statements in void compat wrappers Hongfu Li
2026-07-17 8:42 ` Lorenzo Stoakes (ARM)
2026-07-17 8:55 ` David Hildenbrand (Arm)
2026-07-17 10:31 ` Hongfu Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717103113.95239-1-hongfu.li@linux.dev \
--to=hongfu.li@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=liam@infradead.org \
--cc=lihongfu@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.