From: Jason Gunthorpe <jgg@nvidia.com>
To: sashiko-reviews@lists.linux.dev
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH v3 09/11] vfio: selftests: Add mlx5 driver - HW init and command interface
Date: Fri, 17 Jul 2026 14:41:55 -0300 [thread overview]
Message-ID: <20260717174155.GC699082@nvidia.com> (raw)
In-Reply-To: <20260717170401.B637B1F00A3A@smtp.kernel.org>
On Fri, Jul 17, 2026 at 05:04:01PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 8 potential issue(s) to consider:
> - [Medium] Valid hardware IDs like 0 are incorrectly treated as unallocated resources, leading to resource leaks during teardown.
> - [Medium] Stale command data read due to missing ownership bit poll in async command completion.
> - [Medium] Asynchronous MANAGE_PAGES reclaim loses track of remaining pages if firmware claims fewer pages than requested.
> - [Medium] Heap buffer overflow when processing unvalidated `num_claimed` count from firmware.
> - [Medium] Out-of-bounds MMIO pointer derivation using unvalidated `uar_page` index.
> - [Medium] Undefined behavior due to bitwise shift exceeding integer width.
> - [Medium] Spurious failure during HCA teardown when the firmware temporarily returns 0 reclaimed pages.
> - [Medium] Unconditional RoCE capability query crashes the selftest on devices where RoCE is disabled or unsupported.
I think these are bogus - we don't have a model where we don't trust
the HW/FW in this driver.
Jason
next prev parent reply other threads:[~2026-07-17 17:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 17:03 [PATCH v3 00/11] mlx5 support for VFIO self test Jason Gunthorpe
2026-07-16 17:03 ` [PATCH v3 01/11] net/mlx5: Add IFC structures for CQE and WQE Jason Gunthorpe
2026-07-16 17:03 ` [PATCH v3 02/11] net/mlx5: Move HW constant groups from device.h/cq.h to mlx5_ifc.h Jason Gunthorpe
2026-07-16 17:03 ` [PATCH v3 03/11] net/mlx5: Extract MLX5_SET/GET macros into mlx5_ifc_macros.h Jason Gunthorpe
2026-07-16 17:03 ` [PATCH v3 04/11] net/mlx5: Add ONCE and MMIO accessor variants to mlx5_ifc_macros.h Jason Gunthorpe
2026-07-16 17:03 ` [PATCH v3 05/11] selftests: Add additional kernel functions to tools/include/ Jason Gunthorpe
2026-07-16 17:03 ` [PATCH v3 06/11] selftests: Fix arm64 IO barriers to match kernel Jason Gunthorpe
2026-07-16 23:22 ` Nathan Chancellor
2026-07-17 0:36 ` Jason Gunthorpe
2026-07-16 17:03 ` [PATCH v3 07/11] vfio: selftests: Allow drivers to specify required region size Jason Gunthorpe
2026-07-17 17:04 ` sashiko-bot
2026-07-16 17:03 ` [PATCH v3 08/11] vfio: selftests: Add dev_dbg Jason Gunthorpe
2026-07-16 17:03 ` [PATCH v3 09/11] vfio: selftests: Add mlx5 driver - HW init and command interface Jason Gunthorpe
2026-07-17 17:04 ` sashiko-bot
2026-07-17 17:41 ` Jason Gunthorpe [this message]
2026-07-16 17:03 ` [PATCH v3 10/11] vfio: selftests: Add mlx5 driver - data path and memcpy ops Jason Gunthorpe
2026-07-16 17:03 ` [PATCH v3 11/11] vfio: selftests: mlx5 driver - add send_msi support Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717174155.GC699082@nvidia.com \
--to=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.