All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mm/migrate: add missing kernel-doc for @migrate_info
@ 2026-07-17  2:21 Randy Dunlap
  2026-07-18  0:08 ` SJ Park
  2026-07-18  8:03 ` Garg, Shivank
  0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2026-07-17  2:21 UTC (permalink / raw)
  To: linux-mm; +Cc: Randy Dunlap, Shivank Garg, Andrew Morton

Add a kernel-doc comment for @migrate_info so that kernel-doc won't
produce a warning about it:

WARNING: include/linux/mm_types.h:507 struct member 'migrate_info' not described in 'folio'

Fixes: f3768940afdc ("mm/migrate: use migrate_info field instead of private")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Shivank Garg <shivankg@amd.com>
Cc: Andrew Morton <akpm@linux-foundation.org>

 include/linux/mm_types.h |    2 ++
 1 file changed, 2 insertions(+)

--- linux-next-20260715.orig/include/linux/mm_types.h
+++ linux-next-20260715/include/linux/mm_types.h
@@ -368,6 +368,8 @@ typedef unsigned short mm_id_t;
  *    dax_associate_entry.
  * @private: Filesystem per-folio data (see folio_attach_private()).
  * @swap: Used for swp_entry_t if folio_test_swapcache().
+ * @migrate_info: Stores migration state (anon_vma pointer and
+ *    FOLIO_WAS_* markers).
  * @_mapcount: Do not access this member directly.  Use folio_mapcount() to
  *    find out how many times this folio is mapped by userspace.
  * @_refcount: Do not access this member directly.  Use folio_ref_count()


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mm/migrate: add missing kernel-doc for @migrate_info
  2026-07-17  2:21 [PATCH] mm/migrate: add missing kernel-doc for @migrate_info Randy Dunlap
@ 2026-07-18  0:08 ` SJ Park
  2026-07-18  8:03 ` Garg, Shivank
  1 sibling, 0 replies; 3+ messages in thread
From: SJ Park @ 2026-07-18  0:08 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: SJ Park, linux-mm, Shivank Garg, Andrew Morton

On Thu, 16 Jul 2026 19:21:46 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:

> Add a kernel-doc comment for @migrate_info so that kernel-doc won't
> produce a warning about it:
> 
> WARNING: include/linux/mm_types.h:507 struct member 'migrate_info' not described in 'folio'

Nice catch!

> 
> Fixes: f3768940afdc ("mm/migrate: use migrate_info field instead of private")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Reviewed-by: SJ Park <sj@kernel.org>


Btw, get_maintainer.pl suggests adding below more recipients to this patch.  I
guess they were intentionally not Cc-ed since this is a simple change.  And I
think that's fair enough.  Just wanted to call out for a case.

- David Hildenbrand <david@kernel.org>
- Lorenzo Stoakes <ljs@kernel.org>
- "Liam R. Howlett" <liam@infradead.org>
- Vlastimil Babka <vbabka@kernel.org>
- Mike Rapoport <rppt@kernel.org>
- Suren Baghdasaryan <surenb@google.com>
- Michal Hocko <mhocko@suse.com>
- Huang Ying <ying.huang@linux.alibaba.com>
- Zi Yan <ziy@nvidia.com>
- Jonathan Cameron <jic23@kernel.org>
- linux-kernel@vger.kernel.org


Thanks,
SJ

[...]


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mm/migrate: add missing kernel-doc for @migrate_info
  2026-07-17  2:21 [PATCH] mm/migrate: add missing kernel-doc for @migrate_info Randy Dunlap
  2026-07-18  0:08 ` SJ Park
@ 2026-07-18  8:03 ` Garg, Shivank
  1 sibling, 0 replies; 3+ messages in thread
From: Garg, Shivank @ 2026-07-18  8:03 UTC (permalink / raw)
  To: Randy Dunlap, linux-mm; +Cc: Andrew Morton



On 7/17/2026 7:51 AM, Randy Dunlap wrote:
> Add a kernel-doc comment for @migrate_info so that kernel-doc won't
> produce a warning about it:
> 
> WARNING: include/linux/mm_types.h:507 struct member 'migrate_info' not described in 'folio'
> 
> Fixes: f3768940afdc ("mm/migrate: use migrate_info field instead of private")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Shivank Garg <shivankg@amd.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> 
>  include/linux/mm_types.h |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- linux-next-20260715.orig/include/linux/mm_types.h
> +++ linux-next-20260715/include/linux/mm_types.h
> @@ -368,6 +368,8 @@ typedef unsigned short mm_id_t;
>   *    dax_associate_entry.
>   * @private: Filesystem per-folio data (see folio_attach_private()).
>   * @swap: Used for swp_entry_t if folio_test_swapcache().
> + * @migrate_info: Stores migration state (anon_vma pointer and
> + *    FOLIO_WAS_* markers).
>   * @_mapcount: Do not access this member directly.  Use folio_mapcount() to
>   *    find out how many times this folio is mapped by userspace.
>   * @_refcount: Do not access this member directly.  Use folio_ref_count()

Thanks for fixing this.

Reviewed-by: Shivank Garg <shivankg@amd.com>

Best regards,
Shivank


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-07-18  8:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-17  2:21 [PATCH] mm/migrate: add missing kernel-doc for @migrate_info Randy Dunlap
2026-07-18  0:08 ` SJ Park
2026-07-18  8:03 ` Garg, Shivank

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.