* [android-common:android16-6.12-kminext 1/1] drivers/usb/gadget/function/f_hid.c:1276 hidg_bind() warn: missing error code 'status'
@ 2026-07-20 10:24 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2026-07-19 2:25 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: cros-kernel-buildreports@googlegroups.com
tree: https://android.googlesource.com/kernel/common android16-6.12-kminext
head: 2bfc8fe4015fcf2e39fc5989b95d20d6b5f7b566
commit: c6c0d13db5d0f8d465eabc14bd23d2b6a7247a43 [1/1] usb: gadget: f_hid: don't call cdev_init while cdev in use
:::::: branch date: 2 days ago
:::::: commit date: 3 months ago
config: i386-randconfig-141 (https://download.01.org/0day-ci/archive/20260719/202607191041.mUlJ0LSw-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
smatch: v0.5.0-9185-gbcc58b9c
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202607191041.mUlJ0LSw-lkp@intel.com/
smatch warnings:
drivers/usb/gadget/function/f_hid.c:1276 hidg_bind() warn: missing error code 'status'
vim +/status +1276 drivers/usb/gadget/function/f_hid.c
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1161
cb382536052fcc7 drivers/usb/gadget/function/f_hid.c Andrzej Pietrasiewicz 2014-11-06 1162 static int hidg_bind(struct usb_configuration *c, struct usb_function *f)
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1163 {
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1164 struct usb_ep *ep;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1165 struct f_hidg *hidg = func_to_hidg(f);
5ca8d3ec9970f47 drivers/usb/gadget/function/f_hid.c Andrzej Pietrasiewicz 2014-11-06 1166 struct usb_string *us;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1167 int status;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1168
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1169 hidg->get_req = usb_ep_alloc_request(c->cdev->gadget->ep0, GFP_ATOMIC);
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1170 if (!hidg->get_req)
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1171 return -ENOMEM;
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1172
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1173 hidg->get_req->zero = 0;
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1174 hidg->get_req->complete = hidg_get_report_complete;
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1175 hidg->get_req->context = hidg;
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1176 hidg->get_report_returned = true;
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1177
cb382536052fcc7 drivers/usb/gadget/function/f_hid.c Andrzej Pietrasiewicz 2014-11-06 1178 /* maybe allocate device-global string IDs, and patch descriptors */
5ca8d3ec9970f47 drivers/usb/gadget/function/f_hid.c Andrzej Pietrasiewicz 2014-11-06 1179 us = usb_gstrings_attach(c->cdev, ct_func_strings,
5ca8d3ec9970f47 drivers/usb/gadget/function/f_hid.c Andrzej Pietrasiewicz 2014-11-06 1180 ARRAY_SIZE(ct_func_string_defs));
5ca8d3ec9970f47 drivers/usb/gadget/function/f_hid.c Andrzej Pietrasiewicz 2014-11-06 1181 if (IS_ERR(us))
5ca8d3ec9970f47 drivers/usb/gadget/function/f_hid.c Andrzej Pietrasiewicz 2014-11-06 1182 return PTR_ERR(us);
5ca8d3ec9970f47 drivers/usb/gadget/function/f_hid.c Andrzej Pietrasiewicz 2014-11-06 1183 hidg_interface_desc.iInterface = us[CT_FUNC_HID_IDX].id;
cb382536052fcc7 drivers/usb/gadget/function/f_hid.c Andrzej Pietrasiewicz 2014-11-06 1184
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1185 /* allocate instance-specific interface IDs, and patch descriptors */
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1186 status = usb_interface_id(c, f);
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1187 if (status < 0)
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1188 goto fail;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1189 hidg_interface_desc.bInterfaceNumber = status;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1190
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1191 /* allocate instance-specific endpoints */
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1192 status = -ENODEV;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1193 ep = usb_ep_autoconfig(c->cdev->gadget, &hidg_fs_in_ep_desc);
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1194 if (!ep)
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1195 goto fail;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1196 hidg->in_ep = ep;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1197
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1198 hidg->out_ep = NULL;
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1199 if (hidg->use_out_ep) {
99c515005857ff7 drivers/usb/gadget/f_hid.c Daniel Mack 2012-06-13 1200 ep = usb_ep_autoconfig(c->cdev->gadget, &hidg_fs_out_ep_desc);
99c515005857ff7 drivers/usb/gadget/f_hid.c Daniel Mack 2012-06-13 1201 if (!ep)
99c515005857ff7 drivers/usb/gadget/f_hid.c Daniel Mack 2012-06-13 1202 goto fail;
99c515005857ff7 drivers/usb/gadget/f_hid.c Daniel Mack 2012-06-13 1203 hidg->out_ep = ep;
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1204 }
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1205
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1206 /* used only if use_out_ep == 1 */
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1207 hidg->set_report_buf = NULL;
99c515005857ff7 drivers/usb/gadget/f_hid.c Daniel Mack 2012-06-13 1208
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1209 /* set descriptor dynamic values */
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1210 hidg_interface_desc.bInterfaceSubClass = hidg->bInterfaceSubClass;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1211 hidg_interface_desc.bInterfaceProtocol = hidg->bInterfaceProtocol;
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1212 hidg_interface_desc.bNumEndpoints = hidg->use_out_ep ? 2 : 1;
b3c4ec71ec413c2 drivers/usb/gadget/function/f_hid.c Abdulhadi Mohamed 2017-07-19 1213 hidg->protocol = HID_REPORT_PROTOCOL;
afcff6dc690e24d drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-07-21 1214 hidg->idle = 1;
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1215 hidg_ss_in_ep_desc.wMaxPacketSize = cpu_to_le16(hidg->report_length);
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1216 hidg_ss_in_comp_desc.wBytesPerInterval =
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1217 cpu_to_le16(hidg->report_length);
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1218 hidg_hs_in_ep_desc.wMaxPacketSize = cpu_to_le16(hidg->report_length);
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1219 hidg_fs_in_ep_desc.wMaxPacketSize = cpu_to_le16(hidg->report_length);
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1220 hidg_ss_out_ep_desc.wMaxPacketSize = cpu_to_le16(hidg->report_length);
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1221 hidg_ss_out_comp_desc.wBytesPerInterval =
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1222 cpu_to_le16(hidg->report_length);
99c515005857ff7 drivers/usb/gadget/f_hid.c Daniel Mack 2012-06-13 1223 hidg_hs_out_ep_desc.wMaxPacketSize = cpu_to_le16(hidg->report_length);
99c515005857ff7 drivers/usb/gadget/f_hid.c Daniel Mack 2012-06-13 1224 hidg_fs_out_ep_desc.wMaxPacketSize = cpu_to_le16(hidg->report_length);
f286d487e9283a4 drivers/usb/gadget/function/f_hid.c Krzysztof Opasiak 2015-03-27 1225 /*
f286d487e9283a4 drivers/usb/gadget/function/f_hid.c Krzysztof Opasiak 2015-03-27 1226 * We can use hidg_desc struct here but we should not relay
f286d487e9283a4 drivers/usb/gadget/function/f_hid.c Krzysztof Opasiak 2015-03-27 1227 * that its content won't change after returning from this function.
f286d487e9283a4 drivers/usb/gadget/function/f_hid.c Krzysztof Opasiak 2015-03-27 1228 */
74388368927e9c5 drivers/usb/gadget/function/f_hid.c Terry Junge 2025-03-12 1229 hidg_desc.rpt_desc.bDescriptorType = HID_DT_REPORT;
74388368927e9c5 drivers/usb/gadget/function/f_hid.c Terry Junge 2025-03-12 1230 hidg_desc.rpt_desc.wDescriptorLength =
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1231 cpu_to_le16(hidg->report_desc_length);
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1232
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1233 hidg_hs_in_ep_desc.bEndpointAddress =
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1234 hidg_fs_in_ep_desc.bEndpointAddress;
99c515005857ff7 drivers/usb/gadget/f_hid.c Daniel Mack 2012-06-13 1235 hidg_hs_out_ep_desc.bEndpointAddress =
99c515005857ff7 drivers/usb/gadget/f_hid.c Daniel Mack 2012-06-13 1236 hidg_fs_out_ep_desc.bEndpointAddress;
10287baec761d33 drivers/usb/gadget/f_hid.c Sebastian Andrzej Siewior 2012-10-22 1237
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1238 hidg_ss_in_ep_desc.bEndpointAddress =
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1239 hidg_fs_in_ep_desc.bEndpointAddress;
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1240 hidg_ss_out_ep_desc.bEndpointAddress =
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1241 hidg_fs_out_ep_desc.bEndpointAddress;
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1242
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1243 if (hidg->use_out_ep)
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1244 status = usb_assign_descriptors(f,
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1245 hidg_fs_descriptors_intout,
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1246 hidg_hs_descriptors_intout,
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1247 hidg_ss_descriptors_intout,
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1248 hidg_ss_descriptors_intout);
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1249 else
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1250 status = usb_assign_descriptors(f,
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1251 hidg_fs_descriptors_ssreport,
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1252 hidg_hs_descriptors_ssreport,
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1253 hidg_ss_descriptors_ssreport,
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1254 hidg_ss_descriptors_ssreport);
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1255
10287baec761d33 drivers/usb/gadget/f_hid.c Sebastian Andrzej Siewior 2012-10-22 1256 if (status)
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1257 goto fail;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1258
749494b6bdbbaf0 drivers/usb/gadget/function/f_hid.c Krzysztof Opasiak 2017-01-24 1259 hidg->write_pending = 1;
749494b6bdbbaf0 drivers/usb/gadget/function/f_hid.c Krzysztof Opasiak 2017-01-24 1260 hidg->req = NULL;
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1261
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1262 INIT_WORK(&hidg->work, get_report_workqueue_handler);
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1263 hidg->workqueue = alloc_workqueue("report_work",
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1264 WQ_FREEZABLE |
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1265 WQ_MEM_RECLAIM,
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1266 1);
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1267
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1268 if (!hidg->workqueue) {
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1269 status = -ENOMEM;
0ab3ae768c48472 drivers/usb/gadget/function/f_hid.c Yuhao Jiang 2025-06-23 1270 goto fail_free_descs;
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1271 }
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1272
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1273 /* create char device */
c6c0d13db5d0f8d drivers/usb/gadget/function/f_hid.c Michael Zimmermann 2026-03-27 1274 hidg->cdev = cdev_alloc();
c6c0d13db5d0f8d drivers/usb/gadget/function/f_hid.c Michael Zimmermann 2026-03-27 1275 if (!hidg->cdev)
c6c0d13db5d0f8d drivers/usb/gadget/function/f_hid.c Michael Zimmermann 2026-03-27 @1276 goto fail_free_all;
c6c0d13db5d0f8d drivers/usb/gadget/function/f_hid.c Michael Zimmermann 2026-03-27 1277 hidg->cdev->ops = &f_hidg_fops;
c6c0d13db5d0f8d drivers/usb/gadget/function/f_hid.c Michael Zimmermann 2026-03-27 1278
c6c0d13db5d0f8d drivers/usb/gadget/function/f_hid.c Michael Zimmermann 2026-03-27 1279 status = cdev_device_add(hidg->cdev, &hidg->dev);
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1280 if (status)
0ab3ae768c48472 drivers/usb/gadget/function/f_hid.c Yuhao Jiang 2025-06-23 1281 goto fail_free_all;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1282
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1283 return 0;
0ab3ae768c48472 drivers/usb/gadget/function/f_hid.c Yuhao Jiang 2025-06-23 1284 fail_free_all:
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1285 destroy_workqueue(hidg->workqueue);
0ab3ae768c48472 drivers/usb/gadget/function/f_hid.c Yuhao Jiang 2025-06-23 1286 fail_free_descs:
d12a8727171c770 drivers/usb/gadget/function/f_hid.c Pavitrakumar Managutte 2014-10-22 1287 usb_free_all_descriptors(f);
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1288 fail:
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1289 ERROR(f->config->cdev, "hidg_bind FAILED\n");
14794d7133d0f16 drivers/usb/gadget/function/f_hid.c Felipe F. Tonello 2016-08-23 1290 if (hidg->req != NULL)
14794d7133d0f16 drivers/usb/gadget/function/f_hid.c Felipe F. Tonello 2016-08-23 1291 free_ep_req(hidg->in_ep, hidg->req);
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1292
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1293 usb_ep_free_request(c->cdev->gadget->ep0, hidg->get_req);
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1294 hidg->get_req = NULL;
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1295
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1296 return status;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1297 }
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1298
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* [android-common:android16-6.12-kminext 1/1] drivers/usb/gadget/function/f_hid.c:1276 hidg_bind() warn: missing error code 'status'
@ 2026-07-20 10:24 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2026-07-20 10:24 UTC (permalink / raw)
To: oe-kbuild, cros-kernel-buildreports; +Cc: lkp, oe-kbuild-all
tree: https://android.googlesource.com/kernel/common android16-6.12-kminext
head: 2bfc8fe4015fcf2e39fc5989b95d20d6b5f7b566
commit: c6c0d13db5d0f8d465eabc14bd23d2b6a7247a43 [1/1] usb: gadget: f_hid: don't call cdev_init while cdev in use
config: i386-randconfig-141 (https://download.01.org/0day-ci/archive/20260719/202607191041.mUlJ0LSw-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
smatch: v0.5.0-9185-gbcc58b9c
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202607191041.mUlJ0LSw-lkp@intel.com/
smatch warnings:
drivers/usb/gadget/function/f_hid.c:1276 hidg_bind() warn: missing error code 'status'
vim +/status +1276 drivers/usb/gadget/function/f_hid.c
cb382536052fcc7 drivers/usb/gadget/function/f_hid.c Andrzej Pietrasiewicz 2014-11-06 1162 static int hidg_bind(struct usb_configuration *c, struct usb_function *f)
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1163 {
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1164 struct usb_ep *ep;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1165 struct f_hidg *hidg = func_to_hidg(f);
5ca8d3ec9970f47 drivers/usb/gadget/function/f_hid.c Andrzej Pietrasiewicz 2014-11-06 1166 struct usb_string *us;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1167 int status;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1168
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1169 hidg->get_req = usb_ep_alloc_request(c->cdev->gadget->ep0, GFP_ATOMIC);
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1170 if (!hidg->get_req)
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1171 return -ENOMEM;
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1172
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1173 hidg->get_req->zero = 0;
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1174 hidg->get_req->complete = hidg_get_report_complete;
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1175 hidg->get_req->context = hidg;
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1176 hidg->get_report_returned = true;
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1177
cb382536052fcc7 drivers/usb/gadget/function/f_hid.c Andrzej Pietrasiewicz 2014-11-06 1178 /* maybe allocate device-global string IDs, and patch descriptors */
5ca8d3ec9970f47 drivers/usb/gadget/function/f_hid.c Andrzej Pietrasiewicz 2014-11-06 1179 us = usb_gstrings_attach(c->cdev, ct_func_strings,
5ca8d3ec9970f47 drivers/usb/gadget/function/f_hid.c Andrzej Pietrasiewicz 2014-11-06 1180 ARRAY_SIZE(ct_func_string_defs));
5ca8d3ec9970f47 drivers/usb/gadget/function/f_hid.c Andrzej Pietrasiewicz 2014-11-06 1181 if (IS_ERR(us))
5ca8d3ec9970f47 drivers/usb/gadget/function/f_hid.c Andrzej Pietrasiewicz 2014-11-06 1182 return PTR_ERR(us);
5ca8d3ec9970f47 drivers/usb/gadget/function/f_hid.c Andrzej Pietrasiewicz 2014-11-06 1183 hidg_interface_desc.iInterface = us[CT_FUNC_HID_IDX].id;
cb382536052fcc7 drivers/usb/gadget/function/f_hid.c Andrzej Pietrasiewicz 2014-11-06 1184
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1185 /* allocate instance-specific interface IDs, and patch descriptors */
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1186 status = usb_interface_id(c, f);
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1187 if (status < 0)
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1188 goto fail;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1189 hidg_interface_desc.bInterfaceNumber = status;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1190
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1191 /* allocate instance-specific endpoints */
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1192 status = -ENODEV;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1193 ep = usb_ep_autoconfig(c->cdev->gadget, &hidg_fs_in_ep_desc);
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1194 if (!ep)
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1195 goto fail;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1196 hidg->in_ep = ep;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1197
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1198 hidg->out_ep = NULL;
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1199 if (hidg->use_out_ep) {
99c515005857ff7 drivers/usb/gadget/f_hid.c Daniel Mack 2012-06-13 1200 ep = usb_ep_autoconfig(c->cdev->gadget, &hidg_fs_out_ep_desc);
99c515005857ff7 drivers/usb/gadget/f_hid.c Daniel Mack 2012-06-13 1201 if (!ep)
99c515005857ff7 drivers/usb/gadget/f_hid.c Daniel Mack 2012-06-13 1202 goto fail;
99c515005857ff7 drivers/usb/gadget/f_hid.c Daniel Mack 2012-06-13 1203 hidg->out_ep = ep;
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1204 }
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1205
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1206 /* used only if use_out_ep == 1 */
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1207 hidg->set_report_buf = NULL;
99c515005857ff7 drivers/usb/gadget/f_hid.c Daniel Mack 2012-06-13 1208
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1209 /* set descriptor dynamic values */
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1210 hidg_interface_desc.bInterfaceSubClass = hidg->bInterfaceSubClass;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1211 hidg_interface_desc.bInterfaceProtocol = hidg->bInterfaceProtocol;
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1212 hidg_interface_desc.bNumEndpoints = hidg->use_out_ep ? 2 : 1;
b3c4ec71ec413c2 drivers/usb/gadget/function/f_hid.c Abdulhadi Mohamed 2017-07-19 1213 hidg->protocol = HID_REPORT_PROTOCOL;
afcff6dc690e24d drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-07-21 1214 hidg->idle = 1;
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1215 hidg_ss_in_ep_desc.wMaxPacketSize = cpu_to_le16(hidg->report_length);
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1216 hidg_ss_in_comp_desc.wBytesPerInterval =
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1217 cpu_to_le16(hidg->report_length);
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1218 hidg_hs_in_ep_desc.wMaxPacketSize = cpu_to_le16(hidg->report_length);
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1219 hidg_fs_in_ep_desc.wMaxPacketSize = cpu_to_le16(hidg->report_length);
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1220 hidg_ss_out_ep_desc.wMaxPacketSize = cpu_to_le16(hidg->report_length);
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1221 hidg_ss_out_comp_desc.wBytesPerInterval =
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1222 cpu_to_le16(hidg->report_length);
99c515005857ff7 drivers/usb/gadget/f_hid.c Daniel Mack 2012-06-13 1223 hidg_hs_out_ep_desc.wMaxPacketSize = cpu_to_le16(hidg->report_length);
99c515005857ff7 drivers/usb/gadget/f_hid.c Daniel Mack 2012-06-13 1224 hidg_fs_out_ep_desc.wMaxPacketSize = cpu_to_le16(hidg->report_length);
f286d487e9283a4 drivers/usb/gadget/function/f_hid.c Krzysztof Opasiak 2015-03-27 1225 /*
f286d487e9283a4 drivers/usb/gadget/function/f_hid.c Krzysztof Opasiak 2015-03-27 1226 * We can use hidg_desc struct here but we should not relay
f286d487e9283a4 drivers/usb/gadget/function/f_hid.c Krzysztof Opasiak 2015-03-27 1227 * that its content won't change after returning from this function.
f286d487e9283a4 drivers/usb/gadget/function/f_hid.c Krzysztof Opasiak 2015-03-27 1228 */
74388368927e9c5 drivers/usb/gadget/function/f_hid.c Terry Junge 2025-03-12 1229 hidg_desc.rpt_desc.bDescriptorType = HID_DT_REPORT;
74388368927e9c5 drivers/usb/gadget/function/f_hid.c Terry Junge 2025-03-12 1230 hidg_desc.rpt_desc.wDescriptorLength =
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1231 cpu_to_le16(hidg->report_desc_length);
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1232
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1233 hidg_hs_in_ep_desc.bEndpointAddress =
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1234 hidg_fs_in_ep_desc.bEndpointAddress;
99c515005857ff7 drivers/usb/gadget/f_hid.c Daniel Mack 2012-06-13 1235 hidg_hs_out_ep_desc.bEndpointAddress =
99c515005857ff7 drivers/usb/gadget/f_hid.c Daniel Mack 2012-06-13 1236 hidg_fs_out_ep_desc.bEndpointAddress;
10287baec761d33 drivers/usb/gadget/f_hid.c Sebastian Andrzej Siewior 2012-10-22 1237
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1238 hidg_ss_in_ep_desc.bEndpointAddress =
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1239 hidg_fs_in_ep_desc.bEndpointAddress;
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1240 hidg_ss_out_ep_desc.bEndpointAddress =
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1241 hidg_fs_out_ep_desc.bEndpointAddress;
dbf499cf720a009 drivers/usb/gadget/function/f_hid.c Janusz Dziedzic 2016-11-03 1242
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1243 if (hidg->use_out_ep)
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1244 status = usb_assign_descriptors(f,
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1245 hidg_fs_descriptors_intout,
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1246 hidg_hs_descriptors_intout,
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1247 hidg_ss_descriptors_intout,
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1248 hidg_ss_descriptors_intout);
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1249 else
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1250 status = usb_assign_descriptors(f,
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1251 hidg_fs_descriptors_ssreport,
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1252 hidg_hs_descriptors_ssreport,
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1253 hidg_ss_descriptors_ssreport,
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1254 hidg_ss_descriptors_ssreport);
d7428bc26fc7679 drivers/usb/gadget/function/f_hid.c Maxim Devaev 2021-08-21 1255
10287baec761d33 drivers/usb/gadget/f_hid.c Sebastian Andrzej Siewior 2012-10-22 1256 if (status)
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1257 goto fail;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1258
749494b6bdbbaf0 drivers/usb/gadget/function/f_hid.c Krzysztof Opasiak 2017-01-24 1259 hidg->write_pending = 1;
749494b6bdbbaf0 drivers/usb/gadget/function/f_hid.c Krzysztof Opasiak 2017-01-24 1260 hidg->req = NULL;
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1261
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1262 INIT_WORK(&hidg->work, get_report_workqueue_handler);
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1263 hidg->workqueue = alloc_workqueue("report_work",
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1264 WQ_FREEZABLE |
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1265 WQ_MEM_RECLAIM,
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1266 1);
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1267
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1268 if (!hidg->workqueue) {
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1269 status = -ENOMEM;
0ab3ae768c48472 drivers/usb/gadget/function/f_hid.c Yuhao Jiang 2025-06-23 1270 goto fail_free_descs;
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1271 }
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1272
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1273 /* create char device */
c6c0d13db5d0f8d drivers/usb/gadget/function/f_hid.c Michael Zimmermann 2026-03-27 1274 hidg->cdev = cdev_alloc();
c6c0d13db5d0f8d drivers/usb/gadget/function/f_hid.c Michael Zimmermann 2026-03-27 1275 if (!hidg->cdev)
c6c0d13db5d0f8d drivers/usb/gadget/function/f_hid.c Michael Zimmermann 2026-03-27 @1276 goto fail_free_all;
status = -ENOMEM. Probably this is fixed upstream?
c6c0d13db5d0f8d drivers/usb/gadget/function/f_hid.c Michael Zimmermann 2026-03-27 1277 hidg->cdev->ops = &f_hidg_fops;
c6c0d13db5d0f8d drivers/usb/gadget/function/f_hid.c Michael Zimmermann 2026-03-27 1278
c6c0d13db5d0f8d drivers/usb/gadget/function/f_hid.c Michael Zimmermann 2026-03-27 1279 status = cdev_device_add(hidg->cdev, &hidg->dev);
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1280 if (status)
0ab3ae768c48472 drivers/usb/gadget/function/f_hid.c Yuhao Jiang 2025-06-23 1281 goto fail_free_all;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1282
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1283 return 0;
0ab3ae768c48472 drivers/usb/gadget/function/f_hid.c Yuhao Jiang 2025-06-23 1284 fail_free_all:
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1285 destroy_workqueue(hidg->workqueue);
0ab3ae768c48472 drivers/usb/gadget/function/f_hid.c Yuhao Jiang 2025-06-23 1286 fail_free_descs:
d12a8727171c770 drivers/usb/gadget/function/f_hid.c Pavitrakumar Managutte 2014-10-22 1287 usb_free_all_descriptors(f);
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1288 fail:
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1289 ERROR(f->config->cdev, "hidg_bind FAILED\n");
14794d7133d0f16 drivers/usb/gadget/function/f_hid.c Felipe F. Tonello 2016-08-23 1290 if (hidg->req != NULL)
14794d7133d0f16 drivers/usb/gadget/function/f_hid.c Felipe F. Tonello 2016-08-23 1291 free_ep_req(hidg->in_ep, hidg->req);
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1292
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1293 usb_ep_free_request(c->cdev->gadget->ep0, hidg->get_req);
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1294 hidg->get_req = NULL;
a139c98f760efa1 drivers/usb/gadget/function/f_hid.c Chris Wulff 2024-08-17 1295
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1296 return status;
71adf1189469578 drivers/usb/gadget/f_hid.c Fabien Chouteau 2010-04-08 1297 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-20 10:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-19 2:25 [android-common:android16-6.12-kminext 1/1] drivers/usb/gadget/function/f_hid.c:1276 hidg_bind() warn: missing error code 'status' kernel test robot
2026-07-20 10:24 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.