Re: [PATCH v6 08/16] media: v4l2-subdev: Move op check to sub-device op wrappers

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

On Mon, Jul 20, 2026 at 10:22:38AM +0300, Sakari Ailus wrote:
> On Mon, Jul 20, 2026 at 09:45:59AM +0300, Laurent Pinchart wrote:
> > On Mon, Jul 20, 2026 at 09:45:22AM +0300, Laurent Pinchart wrote:
> > > On Wed, Jul 01, 2026 at 03:26:25PM +0300, Sakari Ailus wrote:
> > > > In anticipation of performing work for sub-device operation when the
> > > > driver doesn't implement one, move the check of operation existence to the
> > > > wrapper itself.
> > > > 
> > > > No functional change intended.
> > > > 
> > > > Many drivers implement set_fmt() pad op that simply returns the format
> > > > just as get_fmt() would do, usually because the driver only supports a
> > > > single one. The arguments to set_fmt() and get_fmt() are about to get
> > > > differentiated so call get_fmt() always if set_fmt() isn't supported by
> > > > the driver. This avoids changing drivers now and allows removing
> > > > boilerplate code from existing drivers.
> > > 
> > > I don't see this change in the patch. Am I missing something ?
> > 
> > Patch 09/16 answers my question. With this paragraph dropped from the
> > commit message,
> 
> If you think the first paragraph is enough to explain why this is done, I'm
> fine with dropping this one.

The second paragraph states "call get_fmt() always if set_fmt() isn't
supported by the driver", which is done in patch 09/16, not here.

> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Thanks!

-- 
Regards,

Laurent Pinchart