All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/panel: osd101t2587: migrate to newer mipi_dsi* functions
@ 2026-07-20 11:51 Robert-Andrei Mercea
  2026-07-20 12:37 ` Neil Armstrong
  0 siblings, 1 reply; 2+ messages in thread
From: Robert-Andrei Mercea @ 2026-07-20 11:51 UTC (permalink / raw)
  To: Neil Armstrong
  Cc: Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
	linux-kernel, Robert-Andrei Mercea

Migrate osd101t2587-53ts panel driver from deprecated mipi_dsi*
functions to their *_multi variants for improved error handling, as
specified in the GPU subsystem TODO list.

Link: https://docs.kernel.org/gpu/todo.html#transition-away-from-using-deprecated-mipi-dsi-functions

Signed-off-by: Robert-Andrei Mercea <robertandreimercea@gmail.com>
---
 drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
index 2334b77f348c..63ae9dc5712f 100644
--- a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
+++ b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
@@ -32,11 +32,11 @@ static inline struct osd101t2587_panel *ti_osd_panel(struct drm_panel *panel)
 static int osd101t2587_panel_disable(struct drm_panel *panel)
 {
 	struct osd101t2587_panel *osd101t2587 = ti_osd_panel(panel);
-	int ret;
+	struct mipi_dsi_multi_context ctx = { .dsi = osd101t2587->dsi };
 
-	ret = mipi_dsi_shutdown_peripheral(osd101t2587->dsi);
+	mipi_dsi_shutdown_peripheral_multi(&ctx);
 
-	return ret;
+	return ctx.accum_err;
 }
 
 static int osd101t2587_panel_unprepare(struct drm_panel *panel)
@@ -58,13 +58,11 @@ static int osd101t2587_panel_prepare(struct drm_panel *panel)
 static int osd101t2587_panel_enable(struct drm_panel *panel)
 {
 	struct osd101t2587_panel *osd101t2587 = ti_osd_panel(panel);
-	int ret;
+	struct mipi_dsi_multi_context ctx = { .dsi = osd101t2587->dsi };
 
-	ret = mipi_dsi_turn_on_peripheral(osd101t2587->dsi);
-	if (ret)
-		return ret;
+	mipi_dsi_turn_on_peripheral_multi(&ctx);
 
-	return ret;
+	return ctx.accum_err;
 }
 
 static const struct drm_display_mode default_mode_osd101t2587 = {
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/panel: osd101t2587: migrate to newer mipi_dsi* functions
  2026-07-20 11:51 [PATCH] drm/panel: osd101t2587: migrate to newer mipi_dsi* functions Robert-Andrei Mercea
@ 2026-07-20 12:37 ` Neil Armstrong
  0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2026-07-20 12:37 UTC (permalink / raw)
  To: Robert-Andrei Mercea
  Cc: Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
	linux-kernel

On 7/20/26 13:51, Robert-Andrei Mercea wrote:
> Migrate osd101t2587-53ts panel driver from deprecated mipi_dsi*
> functions to their *_multi variants for improved error handling, as
> specified in the GPU subsystem TODO list.
> 
> Link: https://docs.kernel.org/gpu/todo.html#transition-away-from-using-deprecated-mipi-dsi-functions
> 
> Signed-off-by: Robert-Andrei Mercea <robertandreimercea@gmail.com>
> ---
>   drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c | 14 ++++++--------
>   1 file changed, 6 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
> index 2334b77f348c..63ae9dc5712f 100644
> --- a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
> +++ b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c
> @@ -32,11 +32,11 @@ static inline struct osd101t2587_panel *ti_osd_panel(struct drm_panel *panel)
>   static int osd101t2587_panel_disable(struct drm_panel *panel)
>   {
>   	struct osd101t2587_panel *osd101t2587 = ti_osd_panel(panel);
> -	int ret;
> +	struct mipi_dsi_multi_context ctx = { .dsi = osd101t2587->dsi };
>   
> -	ret = mipi_dsi_shutdown_peripheral(osd101t2587->dsi);
> +	mipi_dsi_shutdown_peripheral_multi(&ctx);
>   
> -	return ret;
> +	return ctx.accum_err;
>   }
>   
>   static int osd101t2587_panel_unprepare(struct drm_panel *panel)
> @@ -58,13 +58,11 @@ static int osd101t2587_panel_prepare(struct drm_panel *panel)
>   static int osd101t2587_panel_enable(struct drm_panel *panel)
>   {
>   	struct osd101t2587_panel *osd101t2587 = ti_osd_panel(panel);
> -	int ret;
> +	struct mipi_dsi_multi_context ctx = { .dsi = osd101t2587->dsi };
>   
> -	ret = mipi_dsi_turn_on_peripheral(osd101t2587->dsi);
> -	if (ret)
> -		return ret;
> +	mipi_dsi_turn_on_peripheral_multi(&ctx);
>   
> -	return ret;
> +	return ctx.accum_err;
>   }
>   
>   static const struct drm_display_mode default_mode_osd101t2587 = {

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-07-20 12:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-20 11:51 [PATCH] drm/panel: osd101t2587: migrate to newer mipi_dsi* functions Robert-Andrei Mercea
2026-07-20 12:37 ` Neil Armstrong

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.