Re: [PATCH v3 08/18] dt-bindings: clock: mediatek: Add MT8189 system/base clocks and resets

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `allOf` conditional block uses `enum:` instead of `contains: enum:` to match the `compatible` property array, breaking schema validation for nodes using `#reset-cells`.
--

--- Patch [8]: [PATCH v3 08/18] dt-bindings: clock: mediatek: Add MT8189 system/base clocks and resets ---
commit 616648b8742d465d98b3a1aab07efa4362f930aa
Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

dt-bindings: clock: mediatek: Add MT8189 system/base clocks and resets
    
Add compatible and binding headers files for system and base clock
controllers and reset controllers support of MediaTek MT8189 SoC.
Also, add compatible for frequency hopping and spread spectrum clock
functionality.

> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
> index ab9f8cb7dd6ee..380dab8f4e983 100644
> --- a/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
[ ... ]
> @@ -133,6 +146,8 @@ allOf:
>              - mediatek,mt8188-imgsys1-dip-nr
>              - mediatek,mt8188-imgsys1-dip-top
>              - mediatek,mt8188-ipesys
> +            - mediatek,mt8189-ufscfg-ao
> +            - mediatek,mt8189-ufscfg-pdn
>      then:
>        required:
>          - '#reset-cells'

[Severity: Medium]
Does adding these compatibles to an enum block instead of a contains: enum
block break schema validation for nodes using #reset-cells?

Because the compatible property is evaluated as a JSON array, checking it
with enum attempts to match a string against an array, which always fails.

Will this cause device trees that correctly specify #reset-cells for
MT8189 (and existing MT8188) clock/reset controllers to be improperly
rejected by dtbs_check when the condition evaluates to false and applies
an else clause that unconditionally sets #reset-cells: false?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260720-mt8189-clocks-system-base-v3-0-8e6d99ab3ad2@collabora.com?part=8