* [PATCH] arm64: dts: rockchip: Remove invalid rk3566-bigtreetech-cb2 property
@ 2026-07-21 13:34 ` Fabio Estevam
0 siblings, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2026-07-21 13:34 UTC (permalink / raw)
To: heiko
Cc: robh, krzk+dt, conor+dt, devicetree, linux-arm-kernel,
linux-rockchip, Fabio Estevam
Remove the 'ti,rt-thr' property because it is not used nor documented
anywhere.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
index b6cf03a7ba66..542269c338da 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
@@ -569,7 +569,6 @@ tft_tp: touchscreen@48 {
reg = <0x48>;
status = "okay";
ti,x-plate-ohms = <660>;
- ti,rt-thr = <3000>;
ti,fuzzx = <32>;
ti,fuzzy = <16>;
};
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] arm64: dts: rockchip: Remove invalid rk3566-bigtreetech-cb2 property
@ 2026-07-21 13:34 ` Fabio Estevam
0 siblings, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2026-07-21 13:34 UTC (permalink / raw)
To: heiko
Cc: robh, krzk+dt, conor+dt, devicetree, linux-arm-kernel,
linux-rockchip, Fabio Estevam
Remove the 'ti,rt-thr' property because it is not used nor documented
anywhere.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
index b6cf03a7ba66..542269c338da 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
@@ -569,7 +569,6 @@ tft_tp: touchscreen@48 {
reg = <0x48>;
status = "okay";
ti,x-plate-ohms = <660>;
- ti,rt-thr = <3000>;
ti,fuzzx = <32>;
ti,fuzzy = <16>;
};
--
2.43.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Remove invalid rk3566-bigtreetech-cb2 property
2026-07-21 13:34 ` Fabio Estevam
(?)
@ 2026-07-21 13:40 ` sashiko-bot
-1 siblings, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-07-21 13:40 UTC (permalink / raw)
To: Fabio Estevam; +Cc: devicetree, robh, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch incorrectly removes the 'ti,rt-thr' property instead of correcting it to 'ti,max-rt', permanently discarding the board designer's intended touchscreen resistance threshold.
--
--- Patch [1]: [PATCH] arm64: dts: rockchip: Remove invalid rk3566-bigtreetech-cb2 property ---
commit f09729b87ec6a8e1dd741bb9d8987b1590909b19
Author: Fabio Estevam <festevam@gmail.com>
arm64: dts: rockchip: Remove invalid rk3566-bigtreetech-cb2 property
This commit removes the ti,rt-thr property from the rk3566-bigtreetech-cb2
device tree because it is undocumented.
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi b/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
> index b6cf03a7ba66b..542269c338daf 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi
> @@ -569,7 +569,6 @@ tft_tp: touchscreen@48 {
> reg = <0x48>;
> status = "okay";
> ti,x-plate-ohms = <660>;
> - ti,rt-thr = <3000>;
[Severity: Medium]
Should this property be corrected to ti,max-rt rather than being removed?
While ti,rt-thr is indeed invalid and ignored (falling back to the default
max resistance of 4095), deleting it entirely discards the board designer's
intended touchscreen resistance threshold (3000) instead of fixing the typo.
The tsc2007 driver documents ti,max-rt for this purpose, which would
preserve the configuration intent.
> ti,fuzzx = <32>;
> ti,fuzzy = <16>;
> };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260721133408.44240-1-festevam@gmail.com?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-21 13:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-21 13:34 [PATCH] arm64: dts: rockchip: Remove invalid rk3566-bigtreetech-cb2 property Fabio Estevam
2026-07-21 13:34 ` Fabio Estevam
2026-07-21 13:40 ` sashiko-bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.