[PATCH] graph: fix xstats of cloned nodes

[PATCH] graph: fix xstats of cloned nodes

[Andrey Yudin]

When cloning a node with xstats enabled, xstat_desc entries are copied
into the rte_node_register structure, but the nb_xstats field is not.

As a result, the cloned node reports zero available xstats,
making xstats unusable.

Copy the nb_xstats field when cloning the node so that cloned nodes
preserve the xstats configuration of the original node.

Fixes: 070db97e017b ("graph: support node xstats")
Cc: stable@dpdk.org
Signed-off-by: Andrey Yudin <Andrey.Yudin@infotecs.ru>
---
 lib/graph/node.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/graph/node.c b/lib/graph/node.c
index 1fce3e6632..bb39c616de 100644
--- a/lib/graph/node.c
+++ b/lib/graph/node.c
@@ -208,6 +208,7 @@ node_clone(struct node *node, const char *name)
 			goto free;
 		}
 
+		reg->xstats->nb_xstats = node->xstats->nb_xstats;
 		for (i = 0; i < node->xstats->nb_xstats; i++)
 			if (rte_strscpy(reg->xstats->xstat_desc[i], node->xstats->xstat_desc[i],
 					RTE_NODE_XSTAT_DESC_SIZE) < 0)
-- 
2.47.3

Re: [PATCH] graph: fix xstats of cloned nodes

[Robin Jarry]

Andrey Yudin, Jul 08, 2026 at 10:14:
> When cloning a node with xstats enabled, xstat_desc entries are copied
> into the rte_node_register structure, but the nb_xstats field is not.
>
> As a result, the cloned node reports zero available xstats,
> making xstats unusable.
>
> Copy the nb_xstats field when cloning the node so that cloned nodes
> preserve the xstats configuration of the original node.
>
> Fixes: 070db97e017b ("graph: support node xstats")
> Cc: stable@dpdk.org
> Signed-off-by: Andrey Yudin <Andrey.Yudin@infotecs.ru>
> ---
>  lib/graph/node.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/graph/node.c b/lib/graph/node.c
> index 1fce3e6632..bb39c616de 100644
> --- a/lib/graph/node.c
> +++ b/lib/graph/node.c
> @@ -208,6 +208,7 @@ node_clone(struct node *node, const char *name)
>  			goto free;
>  		}
>  
> +		reg->xstats->nb_xstats = node->xstats->nb_xstats;
>  		for (i = 0; i < node->xstats->nb_xstats; i++)
>  			if (rte_strscpy(reg->xstats->xstat_desc[i], node->xstats->xstat_desc[i],
>  					RTE_NODE_XSTAT_DESC_SIZE) < 0)

Reviewed-by: Robin Jarry <rjarry@redhat.com>

Re: [PATCH] graph: fix xstats of cloned nodes

[kirankumark]

On Wed, Jul 08, 2026 at 11:14:19AM +0300, Andrey Yudin wrote:
> When cloning a node with xstats enabled, xstat_desc entries are copied
> into the rte_node_register structure, but the nb_xstats field is not.
>
> As a result, the cloned node reports zero available xstats,
> making xstats unusable.
>
> Copy the nb_xstats field when cloning the node so that cloned nodes
> preserve the xstats configuration of the original node.
>
> Fixes: 070db97e017b ("graph: support node xstats")
> Cc: stable@dpdk.org
> Signed-off-by: Andrey Yudin <Andrey.Yudin@infotecs.ru>
> ---
>  lib/graph/node.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/graph/node.c b/lib/graph/node.c
> index 1fce3e6632..bb39c616de 100644
> --- a/lib/graph/node.c
> +++ b/lib/graph/node.c
> @@ -208,6 +208,7 @@ node_clone(struct node *node, const char *name)
>  			goto free;
>  		}
>
> +		reg->xstats->nb_xstats = node->xstats->nb_xstats;
>  		for (i = 0; i < node->xstats->nb_xstats; i++)
>  			if (rte_strscpy(reg->xstats->xstat_desc[i], node->xstats->xstat_desc[i],
>  					RTE_NODE_XSTAT_DESC_SIZE) < 0)
> --
> 2.47.3
>

Acked-by: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>

Re: [PATCH] graph: fix xstats of cloned nodes

[Stephen Hemminger]

On Wed, 8 Jul 2026 11:14:19 +0300
Andrey Yudin <Andrey.Yudin@infotecs.ru> wrote:

> When cloning a node with xstats enabled, xstat_desc entries are copied
> into the rte_node_register structure, but the nb_xstats field is not.
> 
> As a result, the cloned node reports zero available xstats,
> making xstats unusable.
> 
> Copy the nb_xstats field when cloning the node so that cloned nodes
> preserve the xstats configuration of the original node.
> 
> Fixes: 070db97e017b ("graph: support node xstats")
> Cc: stable@dpdk.org
> Signed-off-by: Andrey Yudin <Andrey.Yudin@infotecs.ru>
> ---

This patch is technically correct, and I have no issues with the code itself.

However, the submitter's mail domain (infotecs.ru) belongs to JSC
InfoTeCS, which is on the EU consolidated sanctions list. Whether a
contribution from a sanctioned entity can be accepted is a legal
question, and not one a maintainer has the authority to decide.

Holding off on merging this patch until there is direction from LF
legal and/or the DPDK governing board.