From: Rob Herring <robh@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: "Krzysztof Kozlowski" <krzk@kernel.org>,
"Jassi Brar" <jassisinghbrar@gmail.com>,
"Joonwon Kang" <joonwonkang@google.com>,
"Subhash Jadavani" <sjadavani@google.com>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Lucas Wei" <lucaswei@google.com>,
"Brian Norris" <briannorris@chromium.org>,
"Peter Griffin" <peter.griffin@linaro.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 6/7] dt-bindings: mailbox: goog-mba: Add goog-mba mailbox bindings
Date: Wed, 22 Jul 2026 09:10:04 -0500 [thread overview]
Message-ID: <20260722141004.GB548057-robh@kernel.org> (raw)
In-Reply-To: <CAD=FV=Vrd9AxO-NY_CP2h+f21qt4uGY2pOoFgacV+G5bnfd32Q@mail.gmail.com>
On Wed, Jul 15, 2026 at 09:49:14AM -0700, Doug Anderson wrote:
> Hi,
>
> On Tue, Jul 14, 2026 at 9:51 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On 15/07/2026 00:21, Douglas Anderson wrote:
> > > Introduce bindings for the MailBox Array IP block present in Laguna
> > > SoCs (AKA "lga", AKA "Google Tensor G5").
> > >
> > > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > > ---
> > >
> > > .../bindings/mailbox/google,mba.yaml | 216 ++++++++++++++++++
> >
> > Filename must match compatible.
>
> Whoops! Will fix in v2.
>
>
> > > +properties:
> > > + compatible:
> > > + items:
> > > + - enum:
> > > + - google,lga-mailbox-array
> > > + - const: google,mailbox-array
> >
> > Don't use generic fallback. Just the SoCs.
>
> Sure, if you insist.
>
> In general the "mba" hardware is designed with enough identification
> registers that we should be able to autodetect which variant we're on.
> Thus, my hope is to not ever need to reference the SoC-specific
> variant in the driver itself. It's not the end of the world to use the
> "google,lga-mailbox-array" as the generic, I guess...
>
> I don't suppose I can change your mind here? If we take
> "google,lga-mailbox-array" as the generic, then going foward a few
> generations we end up with:
>
> properties:
> compatible:
> oneOf:
> - const: google,lga-mailbox-array
> - items:
> - enum:
> - google,next-mailbox-array
> - google,nextnext-mailbox-array
> - google,another-mailbox-array
> - const: google,lga-mailbox-array
>
> If we keep "google,mailbox-array" as the generic, then going forward a
> few generations we end up with this, which seems nicer / less
> confusing:
>
> properties:
> compatible:
> items:
> - enum:
> - google,lga-mailbox-array
> - google,next-mailbox-array
> - google,nextnext-mailbox-array
> - google,another-mailbox-array
> - const: google,mailbox-array
I find 4 strings nicer than 5 strings.
> Sure, it means that if someone unexpectedly makes a new Google
> mailbox-array that's totally incompatible then the
> "google,mailbox-array" sounds too generic, but that doesn't feel like
> the end of the world. You could call the new mailbox array designed in
> the year 2037 the "google,2037-mailbox-array" and things would overall
> be less confusing than using the "google,lga-mailbox-array" as the
> generic.
What exactly do we need to do to stop having this conversation? We've
done this scheme and version numbers and it never ends well.
The reality is the h/w folks can't help themselves from changing things,
so nothing remains unchanged for very many generations.
Rob
next prev parent reply other threads:[~2026-07-22 14:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 22:21 [PATCH 0/7] mailbox: Improve the mbox core then introduce the goog-mba driver Douglas Anderson
2026-07-14 22:21 ` [PATCH 1/7] dt-bindings: mailbox: Don't require #mbox-cells to be 1 Douglas Anderson
2026-07-14 22:32 ` sashiko-bot
2026-07-22 14:02 ` Rob Herring
2026-07-14 22:21 ` [PATCH 2/7] mailbox: Allow #mbox-cells = <0> without specifying a custom xlate Douglas Anderson
2026-07-14 22:21 ` [PATCH 3/7] mailbox: Find a matching mailbox by fwnode rather than device Douglas Anderson
2026-07-14 22:21 ` [PATCH 4/7] mailbox: Simplify circular queue math with mod arithmetic Douglas Anderson
2026-07-14 22:21 ` [PATCH 5/7] mailbox: Add support for mailbox controllers that can queue Douglas Anderson
2026-07-14 22:21 ` [PATCH 6/7] dt-bindings: mailbox: goog-mba: Add goog-mba mailbox bindings Douglas Anderson
2026-07-15 4:51 ` Krzysztof Kozlowski
2026-07-15 16:49 ` Doug Anderson
2026-07-16 5:46 ` Krzysztof Kozlowski
2026-07-16 16:31 ` Doug Anderson
2026-07-22 17:11 ` Doug Anderson
2026-07-22 14:10 ` Rob Herring [this message]
2026-07-22 16:57 ` Doug Anderson
2026-07-14 22:21 ` [PATCH 7/7] mailbox: goog-mba: Introduce the goog-mba mailbox driver Douglas Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722141004.GB548057-robh@kernel.org \
--to=robh@kernel.org \
--cc=andre.draszik@linaro.org \
--cc=briannorris@chromium.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=jassisinghbrar@gmail.com \
--cc=joonwonkang@google.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lucaswei@google.com \
--cc=peter.griffin@linaro.org \
--cc=sjadavani@google.com \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.