Re: [PATCH v2 13/33] ibmvfc: add helper to check NVMe/FC support with active channels

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces a new static function `ibmvfc_nvme_active` but does not add any callers for it, resulting in a `-Wunused-function` compiler warning.
--

--- Patch [13]: [PATCH v2 13/33] ibmvfc: add helper to check NVMe/FC support with active channels ---
commit b0d2f58cb79cae1f9014312c2de6b5f52ab4b38e
Author: Tyrel Datwyler <tyreld@linux.ibm.com>

ibmvfc: add helper to check NVMe/FC support with active channels

This commit adds a new helper function to check if NVMe over Fibre Channel
is supported and whether it has active configured queues, aiming to bypass
unnecessary NVMe target discovery when no queues are present.

> --- a/drivers/scsi/ibmvscsi/ibmvfc-core.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc-core.c
> @@ -207,6 +207,12 @@ static int ibmvfc_check_caps(struct ibmvfc_host *vhost, unsigned long cap_flags)
>  	return (host_caps & cap_flags) ? 1 : 0;
>  }
>  
> +static int ibmvfc_nvme_active(struct ibmvfc_host *vhost)

[Severity: Low]
Is this new static function used anywhere in this patch?

Adding a static function without any callers introduces a -Wunused-function
compiler warning. This can break builds that have CONFIG_WERROR enabled and
negatively impact bisectability. Should the usage of this helper be included
in this commit, or perhaps dropped if it is no longer needed?

> +{
> +	return (ibmvfc_check_caps(vhost, IBMVFC_SUPPORT_NVMEOF) &&
> +		vhost->nvme_scrqs.active_queues);
> +}
> +
>  static struct ibmvfc_fcp_cmd_iu *ibmvfc_get_fcp_iu(struct ibmvfc_host *vhost,
>  						   struct ibmvfc_cmd *vfc_cmd)
>  {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260723000149.969416-1-tyreld@linux.ibm.com?part=13