Re: [PATCH v2 19/33] ibmvfc: add NVMe/FC Query Target support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The target's protocol field is never initialized to IBMVFC_PROTO_NVME, causing the driver to send SCSI Query Target MADs even for NVMe targets.
--

--- Patch [19]: [PATCH v2 19/33] ibmvfc: add NVMe/FC Query Target support ---
commit 8e5ca6c48a7f422d595d70e30b62d3daf80b7c82
Author: Tyrel Datwyler <tyreld@linux.ibm.com>

ibmvfc: add NVMe/FC Query Target support

This commit adds protocol-specific query-target support for NVMe/FC targets.
It uses the NVMe query-target specific MAD when querying an NVMe target and
updates the associated logging.

> diff --git a/drivers/scsi/ibmvscsi/ibmvfc-core.c b/drivers/scsi/ibmvscsi/ibmvfc-core.c
> index 5950f143e9a12..b479537e9e78c 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc-core.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc-core.c
[ ... ]
> @@ -4923,7 +4923,10 @@ static void ibmvfc_tgt_query_target(struct ibmvfc_target *tgt)
>  	query_tgt = &evt->iu.query_tgt;
>  	memset(query_tgt, 0, sizeof(*query_tgt));
>  	query_tgt->common.version = cpu_to_be32(1);
> -	query_tgt->common.opcode = cpu_to_be32(IBMVFC_QUERY_TARGET);
> +	if (tgt->protocol == IBMVFC_PROTO_SCSI)
> +		query_tgt->common.opcode = cpu_to_be32(IBMVFC_QUERY_TARGET);
> +	else
> +		query_tgt->common.opcode = cpu_to_be32(IBMVFC_NVMF_QUERY_TARGET);

[Severity: High]
Is this NVMe branch reachable?

Looking at ibmvfc_alloc_target(), the target is allocated and zero-initialized
using memset(), but the protocol field is never assigned. Because
IBMVFC_PROTO_SCSI evaluates to 0, the target implicitly and permanently
becomes a SCSI target:

drivers/scsi/ibmvscsi/ibmvfc-core.c:ibmvfc_alloc_target() {
	...
	tgt = mempool_alloc(vhost->tgt_pool, GFP_NOIO);
	memset(tgt, 0, sizeof(*tgt));
	tgt->scsi_id = scsi_id;
	tgt->wwpn = wwpn;
	tgt->vhost = vhost;
	tgt->need_login = 1;
	...
}

Does the protocol field need to be explicitly initialized to IBMVFC_PROTO_NVME
somewhere so that NVMe targets don't incorrectly send SCSI Query Target MADs?

>  	query_tgt->common.length = cpu_to_be16(sizeof(*query_tgt));
>  	query_tgt->wwpn = cpu_to_be64(tgt->ids.port_name);
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260723000149.969416-1-tyreld@linux.ibm.com?part=19