* [PATCH 0/3] media: cec: Remove redundant error messages on IRQ request failure
@ 2026-07-23 9:54 ` Pan Chuang
0 siblings, 0 replies; 7+ messages in thread
From: Pan Chuang @ 2026-07-23 9:54 UTC (permalink / raw)
To: Neil Armstrong, Hans Verkuil, Mauro Carvalho Chehab, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl, Ettore Chimenti,
Thierry Reding, Jonathan Hunter,
open list:MESON AO CEC DRIVER FOR AMLOGIC SOCS,
open list:MESON AO CEC DRIVER FOR AMLOGIC SOCS,
moderated list:ARM/Amlogic Meson SoC support, open list,
open list:ARM/TEGRA HDMI CEC SUBSYSTEM SUPPORT
Cc: Pan Chuang
devm_request_threaded_irq() and devm_request_any_context_irq()
automatically log detailed error messages on failure via
the devm_request_result() helper, which prints device
name, IRQ number, handler functions, and error code.
Since devm_request_irq() is a static inline wrapper around
devm_request_threaded_irq(), it also benefits from this
automatic logging.
Remove the now-redundant dev_err() and dev_err_probe() calls
in cec drivers that follow these devm_request_*_irq()
functions, as the core now provides more detailed diagnostic
information on failure.
Pan Chuang (3):
media: cec: ao-cec: Remove redundant dev_err()
media: cec: seco: Remove redundant dev_err()
media: cec: tegra: Remove redundant dev_err()
drivers/media/cec/platform/meson/ao-cec-g12a.c | 4 +---
drivers/media/cec/platform/meson/ao-cec.c | 4 +---
drivers/media/cec/platform/seco/seco-cec.c | 1 -
drivers/media/cec/platform/tegra/tegra_cec.c | 5 +----
4 files changed, 3 insertions(+), 11 deletions(-)
--
2.34.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/3] media: cec: ao-cec: Remove redundant dev_err()
2026-07-23 9:54 ` Pan Chuang
@ 2026-07-23 9:54 ` Pan Chuang
-1 siblings, 0 replies; 7+ messages in thread
From: Pan Chuang @ 2026-07-23 9:54 UTC (permalink / raw)
To: Neil Armstrong, Hans Verkuil, Mauro Carvalho Chehab, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl,
open list:MESON AO CEC DRIVER FOR AMLOGIC SOCS,
open list:MESON AO CEC DRIVER FOR AMLOGIC SOCS,
moderated list:ARM/Amlogic Meson SoC support, open list
Cc: Pan Chuang
Since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
devm_request_threaded_irq() automatically logs detailed error messages on
failure. Remove the now-redundant driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/media/cec/platform/meson/ao-cec-g12a.c | 4 +---
drivers/media/cec/platform/meson/ao-cec.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/media/cec/platform/meson/ao-cec-g12a.c b/drivers/media/cec/platform/meson/ao-cec-g12a.c
index 2c914f0008b5..b175be3f2bf4 100644
--- a/drivers/media/cec/platform/meson/ao-cec-g12a.c
+++ b/drivers/media/cec/platform/meson/ao-cec-g12a.c
@@ -689,10 +689,8 @@ static int meson_ao_cec_g12a_probe(struct platform_device *pdev)
meson_ao_cec_g12a_irq,
meson_ao_cec_g12a_irq_thread,
0, NULL, ao_cec);
- if (ret) {
- dev_err(&pdev->dev, "irq request failed\n");
+ if (ret)
goto out_probe_adapter;
- }
ao_cec->oscin = devm_clk_get(&pdev->dev, "oscin");
if (IS_ERR(ao_cec->oscin)) {
diff --git a/drivers/media/cec/platform/meson/ao-cec.c b/drivers/media/cec/platform/meson/ao-cec.c
index 145efd9af6ac..2df0d3743077 100644
--- a/drivers/media/cec/platform/meson/ao-cec.c
+++ b/drivers/media/cec/platform/meson/ao-cec.c
@@ -636,10 +636,8 @@ static int meson_ao_cec_probe(struct platform_device *pdev)
meson_ao_cec_irq,
meson_ao_cec_irq_thread,
0, NULL, ao_cec);
- if (ret) {
- dev_err(&pdev->dev, "irq request failed\n");
+ if (ret)
goto out_probe_adapter;
- }
ao_cec->core = devm_clk_get(&pdev->dev, "core");
if (IS_ERR(ao_cec->core)) {
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 1/3] media: cec: ao-cec: Remove redundant dev_err()
@ 2026-07-23 9:54 ` Pan Chuang
0 siblings, 0 replies; 7+ messages in thread
From: Pan Chuang @ 2026-07-23 9:54 UTC (permalink / raw)
To: Neil Armstrong, Hans Verkuil, Mauro Carvalho Chehab, Kevin Hilman,
Jerome Brunet, Martin Blumenstingl,
open list:MESON AO CEC DRIVER FOR AMLOGIC SOCS,
open list:MESON AO CEC DRIVER FOR AMLOGIC SOCS,
moderated list:ARM/Amlogic Meson SoC support, open list
Cc: Pan Chuang
Since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
devm_request_threaded_irq() automatically logs detailed error messages on
failure. Remove the now-redundant driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/media/cec/platform/meson/ao-cec-g12a.c | 4 +---
drivers/media/cec/platform/meson/ao-cec.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/media/cec/platform/meson/ao-cec-g12a.c b/drivers/media/cec/platform/meson/ao-cec-g12a.c
index 2c914f0008b5..b175be3f2bf4 100644
--- a/drivers/media/cec/platform/meson/ao-cec-g12a.c
+++ b/drivers/media/cec/platform/meson/ao-cec-g12a.c
@@ -689,10 +689,8 @@ static int meson_ao_cec_g12a_probe(struct platform_device *pdev)
meson_ao_cec_g12a_irq,
meson_ao_cec_g12a_irq_thread,
0, NULL, ao_cec);
- if (ret) {
- dev_err(&pdev->dev, "irq request failed\n");
+ if (ret)
goto out_probe_adapter;
- }
ao_cec->oscin = devm_clk_get(&pdev->dev, "oscin");
if (IS_ERR(ao_cec->oscin)) {
diff --git a/drivers/media/cec/platform/meson/ao-cec.c b/drivers/media/cec/platform/meson/ao-cec.c
index 145efd9af6ac..2df0d3743077 100644
--- a/drivers/media/cec/platform/meson/ao-cec.c
+++ b/drivers/media/cec/platform/meson/ao-cec.c
@@ -636,10 +636,8 @@ static int meson_ao_cec_probe(struct platform_device *pdev)
meson_ao_cec_irq,
meson_ao_cec_irq_thread,
0, NULL, ao_cec);
- if (ret) {
- dev_err(&pdev->dev, "irq request failed\n");
+ if (ret)
goto out_probe_adapter;
- }
ao_cec->core = devm_clk_get(&pdev->dev, "core");
if (IS_ERR(ao_cec->core)) {
--
2.34.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/3] media: cec: ao-cec: Remove redundant dev_err()
2026-07-23 9:54 ` Pan Chuang
(?)
@ 2026-07-23 10:01 ` sashiko-bot
-1 siblings, 0 replies; 7+ messages in thread
From: sashiko-bot @ 2026-07-23 10:01 UTC (permalink / raw)
To: Pan Chuang; +Cc: neil.armstrong, linux-amlogic, media-ci
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Missing check for `platform_get_irq()` returning a negative error code causes failures like `-EPROBE_DEFER` to be lost and converted into `-EINVAL`.
--
--- Patch [1]: [PATCH 1/3] media: cec: ao-cec: Remove redundant dev_err() ---
commit 1f47d2ef0ba63ca2af1f7aacf1d74819b91ea940
Author: Pan Chuang <panchuang@vivo.com>
media: cec: ao-cec: Remove redundant dev_err()
This commit removes redundant dev_err() calls after
devm_request_threaded_irq() in the Meson AO CEC drivers, as the core irq
code now logs these errors.
> diff --git a/drivers/media/cec/platform/meson/ao-cec-g12a.c b/drivers/media/cec/platform/meson/ao-cec-g12a.c
> --- a/drivers/media/cec/platform/meson/ao-cec-g12a.c
> +++ b/drivers/media/cec/platform/meson/ao-cec-g12a.c
> @@ -689,10 +689,8 @@ static int meson_ao_cec_g12a_probe(struct platform_device *pdev)
> meson_ao_cec_g12a_irq,
> meson_ao_cec_g12a_irq_thread,
> 0, NULL, ao_cec);
[Severity: High]
This isn't a bug introduced by this patch, but since you are modifying the
error handling here, is there a missing check for irq < 0 before calling
devm_request_threaded_irq() in meson_ao_cec_g12a_probe()?
platform_get_irq() can return negative error codes like -EPROBE_DEFER.
Because devm_request_threaded_irq() takes an unsigned int for the IRQ number,
a negative value gets cast to a large positive integer and fails with -EINVAL.
This masks the original -EPROBE_DEFER and causes the probe to fail permanently
instead of deferring.
> - if (ret) {
> - dev_err(&pdev->dev, "irq request failed\n");
> + if (ret)
> goto out_probe_adapter;
> - }
[ ... ]
> diff --git a/drivers/media/cec/platform/meson/ao-cec.c b/drivers/media/cec/platform/meson/ao-cec.c
> --- a/drivers/media/cec/platform/meson/ao-cec.c
> +++ b/drivers/media/cec/platform/meson/ao-cec.c
> @@ -636,10 +636,8 @@ static int meson_ao_cec_probe(struct platform_device *pdev)
> meson_ao_cec_irq,
> meson_ao_cec_irq_thread,
> 0, NULL, ao_cec);
[Severity: High]
This is the same pre-existing issue as above, but in meson_ao_cec_probe().
Does this irq value need to be checked for < 0 before it gets implicitly cast
to an unsigned int by devm_request_threaded_irq(), masking -EPROBE_DEFER?
> - if (ret) {
> - dev_err(&pdev->dev, "irq request failed\n");
> + if (ret)
> goto out_probe_adapter;
> - }
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260723095500.523448-1-panchuang@vivo.com?part=1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/3] media: cec: seco: Remove redundant dev_err()
2026-07-23 9:54 ` Pan Chuang
(?)
(?)
@ 2026-07-23 9:54 ` Pan Chuang
-1 siblings, 0 replies; 7+ messages in thread
From: Pan Chuang @ 2026-07-23 9:54 UTC (permalink / raw)
To: Ettore Chimenti, Hans Verkuil, Mauro Carvalho Chehab,
open list:CEC FRAMEWORK, open list
Cc: Pan Chuang
Since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
devm_request_threaded_irq() automatically logs detailed error messages on
failure. Remove the now-redundant driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/media/cec/platform/seco/seco-cec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/cec/platform/seco/seco-cec.c b/drivers/media/cec/platform/seco/seco-cec.c
index 654c70503dd5..12db6dca602b 100644
--- a/drivers/media/cec/platform/seco/seco-cec.c
+++ b/drivers/media/cec/platform/seco/seco-cec.c
@@ -619,7 +619,6 @@ static int secocec_probe(struct platform_device *pdev)
dev_name(&pdev->dev), secocec);
if (ret) {
- dev_err(dev, "Cannot request IRQ %d\n", secocec->irq);
ret = -EIO;
goto err;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 3/3] media: cec: tegra: Remove redundant dev_err()
2026-07-23 9:54 ` Pan Chuang
` (2 preceding siblings ...)
(?)
@ 2026-07-23 9:54 ` Pan Chuang
-1 siblings, 0 replies; 7+ messages in thread
From: Pan Chuang @ 2026-07-23 9:54 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, Thierry Reding,
Jonathan Hunter, open list:ARM/TEGRA HDMI CEC SUBSYSTEM SUPPORT,
open list:ARM/TEGRA HDMI CEC SUBSYSTEM SUPPORT, open list
Cc: Pan Chuang
Since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
devm_request_threaded_irq() automatically logs detailed error messages on
failure. Remove the now-redundant driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/media/cec/platform/tegra/tegra_cec.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/media/cec/platform/tegra/tegra_cec.c b/drivers/media/cec/platform/tegra/tegra_cec.c
index e22a4625f192..d64e1662249e 100644
--- a/drivers/media/cec/platform/tegra/tegra_cec.c
+++ b/drivers/media/cec/platform/tegra/tegra_cec.c
@@ -411,11 +411,8 @@ static int tegra_cec_probe(struct platform_device *pdev)
tegra_cec_irq_handler, tegra_cec_irq_thread_handler,
0, "cec_irq", &pdev->dev);
- if (ret) {
- dev_err(&pdev->dev,
- "Unable to request interrupt for device\n");
+ if (ret)
goto err_clk;
- }
cec->adap = cec_allocate_adapter(&tegra_cec_ops, cec, TEGRA_CEC_NAME,
CEC_CAP_DEFAULTS | CEC_CAP_MONITOR_ALL |
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread