All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Zhentao Guo" <zhentao.guo@amlogic.com>
Cc: linux-amlogic@lists.infradead.org, media-ci@linuxtv.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	neil.armstrong@linaro.org, robh@kernel.org
Subject: Re: [PATCH v6 1/6] firmware: meson: sm: Add video firmware loading SMC call
Date: Fri, 24 Jul 2026 07:16:07 +0000	[thread overview]
Message-ID: <20260724071608.5ACC41F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260724-b4-s4-vdec-upstream-v6-1-6072a7ee7428@amlogic.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The command index `SM_LOAD_VIDEO_FW` is used in the command table but is never declared, resulting in a compilation error.
--

--- Patch [1]: [PATCH v6 1/6] firmware: meson: sm: Add video firmware loading SMC call ---
commit 4e1de8a3e47aa991a20a91f21ed6881a59dc9c49
Author: Zhentao Guo <zhentao.guo@amlogic.com>

firmware: meson: sm: Add video firmware loading SMC call

This commit adds a new Secure Monitor Call (SMC) ID for loading video
firmware on Amlogic Meson chips.

> diff --git a/drivers/firmware/meson/meson_sm.c b/drivers/firmware/meson/meson_sm.c
> index ab9751a59b552..887caa5c625db 100644
> --- a/drivers/firmware/meson/meson_sm.c
> +++ b/drivers/firmware/meson/meson_sm.c
> @@ -48,6 +48,7 @@ static const struct meson_sm_chip gxbb_chip = {
>  		CMD(SM_THERMAL_CALIB_READ,	0x82000047),
>  		CMD(SM_A1_PWRC_SET,		0x82000093),
>  		CMD(SM_A1_PWRC_GET,		0x82000095),
> +		CMD(SM_LOAD_VIDEO_FW,		0xb200000f),

[Severity: Low]
Is SM_LOAD_VIDEO_FW declared anywhere? It looks like it was missed in the
command enum in include/linux/firmware/meson/meson_sm.h alongside the other
SM commands, which would cause a compilation error when building the driver.

>  		{ /* sentinel */ },
>  	},
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260724-b4-s4-vdec-upstream-v6-0-6072a7ee7428@amlogic.com?part=1

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Zhentao Guo" <zhentao.guo@amlogic.com>
Cc: linux-amlogic@lists.infradead.org, media-ci@linuxtv.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	neil.armstrong@linaro.org, robh@kernel.org
Subject: Re: [PATCH v6 1/6] firmware: meson: sm: Add video firmware loading SMC call
Date: Fri, 24 Jul 2026 07:16:07 +0000	[thread overview]
Message-ID: <20260724071608.5ACC41F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260724-b4-s4-vdec-upstream-v6-1-6072a7ee7428@amlogic.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The command index `SM_LOAD_VIDEO_FW` is used in the command table but is never declared, resulting in a compilation error.
--

--- Patch [1]: [PATCH v6 1/6] firmware: meson: sm: Add video firmware loading SMC call ---
commit 4e1de8a3e47aa991a20a91f21ed6881a59dc9c49
Author: Zhentao Guo <zhentao.guo@amlogic.com>

firmware: meson: sm: Add video firmware loading SMC call

This commit adds a new Secure Monitor Call (SMC) ID for loading video
firmware on Amlogic Meson chips.

> diff --git a/drivers/firmware/meson/meson_sm.c b/drivers/firmware/meson/meson_sm.c
> index ab9751a59b552..887caa5c625db 100644
> --- a/drivers/firmware/meson/meson_sm.c
> +++ b/drivers/firmware/meson/meson_sm.c
> @@ -48,6 +48,7 @@ static const struct meson_sm_chip gxbb_chip = {
>  		CMD(SM_THERMAL_CALIB_READ,	0x82000047),
>  		CMD(SM_A1_PWRC_SET,		0x82000093),
>  		CMD(SM_A1_PWRC_GET,		0x82000095),
> +		CMD(SM_LOAD_VIDEO_FW,		0xb200000f),

[Severity: Low]
Is SM_LOAD_VIDEO_FW declared anywhere? It looks like it was missed in the
command enum in include/linux/firmware/meson/meson_sm.h alongside the other
SM commands, which would cause a compilation error when building the driver.

>  		{ /* sentinel */ },
>  	},
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260724-b4-s4-vdec-upstream-v6-0-6072a7ee7428@amlogic.com?part=1

  reply	other threads:[~2026-07-24  7:16 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24  7:04 [PATCH v6 0/6] Add Amlogic stateless H.264 video decoder for S4 Zhentao Guo via B4 Relay
2026-07-24  7:04 ` Zhentao Guo
2026-07-24  7:04 ` Zhentao Guo via B4 Relay
2026-07-24  7:04 ` [PATCH v6 1/6] firmware: meson: sm: Add video firmware loading SMC call Zhentao Guo via B4 Relay
2026-07-24  7:04   ` Zhentao Guo
2026-07-24  7:04   ` Zhentao Guo via B4 Relay
2026-07-24  7:16   ` sashiko-bot [this message]
2026-07-24  7:16     ` sashiko-bot
2026-07-24  7:04 ` [PATCH v6 2/6] firmware: meson: sm: video firmware loading via secure monitor Zhentao Guo via B4 Relay
2026-07-24  7:04   ` Zhentao Guo
2026-07-24  7:04   ` Zhentao Guo via B4 Relay
2026-07-24  7:24   ` sashiko-bot
2026-07-24  7:24     ` sashiko-bot
2026-07-24 10:22   ` Ferass El Hafidi
2026-07-24 10:22     ` Ferass El Hafidi
2026-07-24  7:04 ` [PATCH v6 3/6] media: dt-bindings: Add Amlogic V4L2 video decoder Zhentao Guo via B4 Relay
2026-07-24  7:04   ` Zhentao Guo
2026-07-24  7:04   ` Zhentao Guo via B4 Relay
2026-07-24  7:13   ` sashiko-bot
2026-07-24  7:13     ` sashiko-bot
2026-07-24  7:04 ` [PATCH v6 4/6] decoder: Add V4L2 stateless H.264 decoder driver Zhentao Guo via B4 Relay
2026-07-24  7:04   ` Zhentao Guo
2026-07-24  7:04   ` Zhentao Guo via B4 Relay
2026-07-24  7:28   ` sashiko-bot
2026-07-24  7:28     ` sashiko-bot
2026-07-24  7:04 ` [PATCH v6 5/6] arm64: dts: amlogic: Add video decoder driver support for S4 SOCs Zhentao Guo via B4 Relay
2026-07-24  7:04   ` Zhentao Guo
2026-07-24  7:04   ` Zhentao Guo via B4 Relay
2026-07-24  7:16   ` sashiko-bot
2026-07-24  7:16     ` sashiko-bot
2026-07-24  7:04 ` [PATCH v6 6/6] arm64: defconfig: Enable CONFIG_VIDEO_AMLOGIC_VDEC Zhentao Guo via B4 Relay
2026-07-24  7:04   ` Zhentao Guo
2026-07-24  7:04   ` Zhentao Guo via B4 Relay
2026-07-24 10:13 ` [PATCH v6 0/6] Add Amlogic stateless H.264 video decoder for S4 Ferass El Hafidi
2026-07-24 10:13   ` Ferass El Hafidi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260724071608.5ACC41F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=media-ci@linuxtv.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=zhentao.guo@amlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.