Re: [PATCH v2 4/6] dt-bindings: iio: dac: ad5696: extend device support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing driver implementation for newly added compatible strings.
--

--- Patch [4]: [PATCH v2 4/6] dt-bindings: iio: dac: ad5696: extend device support ---
commit 4e58650f8c4c07db88580b9ce728f26ca5b2ce81
Author: Rodrigo Alencar <rodrigo.alencar@analog.com>

dt-bindings: iio: dac: ad5696: extend device support

This commit updates the AD5696 DAC device tree bindings to include the
AD5316R, AD5675, and AD5697R devices. It specifically notes that no fallback
compatibles are used due to differing bit resolutions and channel counts.

> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> @@ -16,10 +16,12 @@ properties:
>    compatible:
>      enum:
>        - adi,ad5311r
> +      - adi,ad5316r

[Severity: Medium]
Are there driver changes intended to be paired with this binding update?

The commit message states that no fallback compatibles are used, meaning the
driver needs an exact match to bind. However, looking at the driver source,
the entries for these new compatible strings appear to be missing:

drivers/iio/dac/ad5696-i2c.c:ad5686_of_match[] {
    /* Missing entries for adi,ad5316r, adi,ad5675, and adi,ad5697r */
};

Will this prevent the newly added devices from successfully probing, since
the driver core won't find a matching driver to bind against when parsing
the device tree?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260724-ad5686-extend-dev-support-v2-0-cfc2b30ce988@analog.com?part=4