Re: [PATCH v2 1/6] dt-bindings: iio: dac: ad5696: add AD5673R/AD5677R support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Missing 'adi,ad5673r' and 'adi,ad5677r' in the ad5696-i2c driver's of_device_id table breaks module autoloading.
--

--- Patch [1]: [PATCH v2 1/6] dt-bindings: iio: dac: ad5696: add AD5673R/AD5677R support ---
commit 0615f695e24a3ce3cbdf232377b1a0e2894200a2
Author: Rodrigo Alencar <rodrigo.alencar@analog.com>

dt-bindings: iio: dac: ad5696: add AD5673R/AD5677R support

Add compatible entries for the AD5673R and AD5677R devices to the ad5696
device tree bindings. These 16-channel devices use different bit resolutions
so no fallback compatibles are used.

> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> index e10f8596f9d3f..5a93edc976f01 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> @@ -19,7 +19,9 @@ properties:
>        - adi,ad5337r
>        - adi,ad5338r
>        - adi,ad5671r
> +      - adi,ad5673r
>        - adi,ad5675r
> +      - adi,ad5677r

[Severity: High]
This isn't a bug introduced by this patch, but does the driver also need
to be updated to match these new compatible strings?

Looking at drivers/iio/dac/ad5696-i2c.c:ad5686_of_match():

static const struct of_device_id ad5686_of_match[] = {
	{ .compatible = "adi,ad5311r", .data = &ad5311r_chip_info },
    ...

It appears 'adi,ad5673r' and 'adi,ad5677r' are missing from this table.

When the system boots and the I2C core generates an of: modalias for 
DT-instantiated devices, could the lack of these entries cause module
autoloading to silently fail for the ad5696-i2c driver?

>        - adi,ad5691r
>        - adi,ad5692r
>        - adi,ad5693

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260724-ad5686-extend-dev-support-v2-0-cfc2b30ce988@analog.com?part=1