Re: [PATCH 3/6] PCI/AER: Deduplicate logging of Error Source Identification

[sashiko-bot@kernel.org]

> aer_print_source() already logs the Error Source Identification Register:
> 
>   AER: Multiple Correctable error message received from 0000:b7:02.0
> 
> However aer_print_error() subsequently identifies the Error Source once
> more by emitting an "Error of this Agent is reported first" message.
> 
> The additional message was introduced by commit 0d465f23502e ("PCI: pcie,
> aer: fix report of multiple errors") because it deemed the message emitted
> by aer_print_source() confusing:  When the Multiple ERR_COR Received or
> Multiple ERR_FATAL/NONFATAL Received bit in the Root Error Status Register
> is set, it doesn't mean that all errors originated from the device in the
> Error Source Identification Register.  Rather, the errors may have come
> from multiple distinct devices.  The commit sought to make that clearer.
> 
> Achieve the commit's objective by rephrasing the message emitted by
> aer_print_source() and drop the additional message logged by
> aer_print_error() to reduce dmesg noisiness and simplify the code.
> 
> While modifying the log message anyway, fix minor grammatical issues:
> Append a plural "s" to "message", add a missing closing brace to "(no
> details found" and capitalize "Error" to match the spec.
> 
> Signed-off-by: Lukas Wunner <lukas@wunner.de>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1784905909.git.lukas@wunner.de?part=3