All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Lukas Wunner" <lukas@wunner.de>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/6] PCI/AER: Fix mapping of errors to agent & layer
Date: Fri, 24 Jul 2026 16:12:48 +0000	[thread overview]
Message-ID: <20260724161248.D36461F000E9@smtp.kernel.org> (raw)
In-Reply-To: <aec4820a75e949b332585a08cb1808fda7f40ea4.1784905909.git.lukas@wunner.de>

> PCIe r7.0 sec 6.2.7 documents the agent and layer of each Correctable and
> Uncorrectable Error.  Based on this spec section, the AER driver maps
> detected errors to an agent and layer using a set of macros and logs them.
> 
> Most errors listed in sec 6.2.7 map to the "Receiver" agent and
> "Transaction Layer", so the macros use these as defaults unless an error
> maps to something else.
> 
> However the macros have not been amended since their introduction in 2006
> with commit 6c2b374d7485 ("PCI-Express AER implemetation: AER core and
> aerdriver").  They are still based on PCIe r1.0 sec 7.2.5 (renumbered to
> 6.2.7 in PCIe r1.1 and newer).
> 
> Amend the macros to map errors introduced since then to the appropriate
> agent and layer.
> [ ... ]
> also a layout erratum in the REPLAY_NUM Rollover row wherein columns are
> shifted to the left, but that's already corrected in the PCIe r7.1 draft
> as of 2026-04-07.)
> 
> Signed-off-by: Lukas Wunner <lukas@wunner.de>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1784905909.git.lukas@wunner.de?part=1


  reply	other threads:[~2026-07-24 16:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24 15:24 [PATCH 0/6] PCI/AER: Support Advisory Non-Fatal Errors Lukas Wunner
2026-07-24 15:24 ` [PATCH 1/6] PCI/AER: Fix mapping of errors to agent & layer Lukas Wunner
2026-07-24 16:12   ` sashiko-bot [this message]
2026-07-24 15:24 ` [PATCH 2/6] PCI/AER: Log agent & layer for each individual error Lukas Wunner
2026-07-24 16:19   ` sashiko-bot
2026-07-24 15:24 ` [PATCH 3/6] PCI/AER: Deduplicate logging of Error Source Identification Lukas Wunner
2026-07-24 16:10   ` sashiko-bot
2026-07-24 15:24 ` [PATCH 4/6] PCI/AER: Emit TLP Log only for unmasked errors Lukas Wunner
2026-07-24 16:21   ` sashiko-bot
2026-07-24 15:24 ` [PATCH 5/6] PCI/AER: Move retrieval of FEP and TLP Log into helper Lukas Wunner
2026-07-24 16:12   ` sashiko-bot
2026-07-24 15:24 ` [PATCH 6/6] PCI/AER: Support Advisory Non-Fatal Errors Lukas Wunner
2026-07-24 16:27   ` sashiko-bot
2026-07-24 22:39 ` [PATCH 0/6] " Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260724161248.D36461F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.