Re: [PATCH bpf-next v2 3/7] parisc: Fix memory leak in bpf_jit_free

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces a build failure due to the use of an incomplete type (`struct bpf_jit_data`) and an undeclared static inline function (`bpf_jit_binary_hdr`).
--

--- Patch [3]: [PATCH bpf-next v2 3/7] parisc: Fix memory leak in bpf_jit_free ---
commit 8b0b5655843da846b247fa021046070e5875f56c
Author: Pu Lehui <pulehui@huawei.com>

parisc: Fix memory leak in bpf_jit_free

This commit implements a custom bpf_jit_free() for the parisc architecture
to free leftover JIT data when a subprogram fails to JIT.

> diff --git a/arch/parisc/net/bpf_jit_core.c b/arch/parisc/net/bpf_jit_core.c
> index 172770132440d..11e13ad6bc509 100644
> --- a/arch/parisc/net/bpf_jit_core.c
> +++ b/arch/parisc/net/bpf_jit_core.c
> @@ -178,6 +178,25 @@ struct bpf_prog *bpf_int_jit_compile(struct bpf_verifier_env *env, struct bpf_pr
>  	goto out_offset;
>  }
>  
> +void bpf_jit_free(struct bpf_prog *fp)
> +{
> +	if (fp->jited) {
> +		struct bpf_jit_data *jit_data = fp->aux->jit_data;
> +		struct bpf_binary_header *hdr = bpf_jit_binary_hdr(fp);
> +
> +		/* Cleanup for earlier subprogs if jit_subprogs() aborts */
> +		if (jit_data) {
> +			kfree(jit_data->ctx.offset);

[Severity: Low]
Will this cause a build failure on parisc?

It looks like struct bpf_jit_data is an incomplete type not defined anywhere
in the kernel, and the correct type used elsewhere in this file is struct
hppa_jit_data.

Additionally, is it possible to call bpf_jit_binary_hdr() here? It appears
to be a static inline function local to kernel/bpf/core.c and is not exported.

> +			kfree(jit_data);
> +		}
> +
> +		bpf_jit_binary_free(hdr);
> +		WARN_ON_ONCE(!bpf_prog_kallsyms_verify_off(fp));
> +	}
> +
> +	bpf_prog_unlock_free(fp);
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260725102020.2287770-1-pulehui@huaweicloud.com?part=3