Re: [PATCH bpf-next v2 4/7] bpf, sparc64: Fix memory leak in bpf_jit_free

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces fatal compilation errors by dereferencing an undefined struct `struct bpf_jit_data` and calling an undeclared function `bpf_jit_binary_hdr`.
--

--- Patch [4]: [PATCH bpf-next v2 4/7] bpf, sparc64: Fix memory leak in bpf_jit_free ---
commit 85bc88f184eccb691d35e9449a95fcc1e9059dca
Author: Pu Lehui <pulehui@huawei.com>

bpf, sparc64: Fix memory leak in bpf_jit_free

If a subprogram fails to JIT in jit_subprogs(), previously JITed
subprograms are freed. However, the generic bpf_jit_free() fails to
free their leftover jit_data, causing a memory leak.

> diff --git a/arch/sparc/net/bpf_jit_comp_64.c b/arch/sparc/net/bpf_jit_comp_64.c
> index 2fa0e93751276..3b72ff2dba9ce 100644
> --- a/arch/sparc/net/bpf_jit_comp_64.c
> +++ b/arch/sparc/net/bpf_jit_comp_64.c
> @@ -1611,3 +1611,22 @@ struct bpf_prog *bpf_int_jit_compile(struct bpf_verifier_env *env, struct bpf_pr
>  	}
>  	goto out_off;
>  }
> +
> +void bpf_jit_free(struct bpf_prog *fp)
> +{
> +	if (fp->jited) {
> +		struct bpf_jit_data *jit_data = fp->aux->jit_data;
> +		struct bpf_binary_header *hdr = bpf_jit_binary_hdr(fp);

[Severity: Low]
Does this code introduce a build regression for sparc64? The
architecture-specific struct appears to be struct sparc64_jit_data rather
than struct bpf_jit_data, which would cause an incomplete type error when
dereferencing jit_data->ctx.offset below.

Also, is bpf_jit_binary_hdr() available in this context? It appears to be a
static inline function defined locally in kernel/bpf/core.c, which would cause
an implicit declaration error during compilation here in
arch/sparc/net/bpf_jit_comp_64.c.

> +
> +		/* Cleanup for earlier subprogs if jit_subprogs() aborts */
> +		if (jit_data) {
> +			kfree(jit_data->ctx.offset);
> +			kfree(jit_data);
> +		}
> +
> +		bpf_jit_binary_free(hdr);
> +		WARN_ON_ONCE(!bpf_prog_kallsyms_verify_off(fp));
> +	}
> +
> +	bpf_prog_unlock_free(fp);
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260725102020.2287770-1-pulehui@huaweicloud.com?part=4