Re: [PATCH 1/7] dt-bindings: spmi: apple,spmi: Add t603x

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The binding adds interrupt controller capabilities but fails to add `interrupt-controller` and `#interrupt-cells` to the `required` list and example.
--

--- Patch [1]: [PATCH 1/7] dt-bindings: spmi: apple,spmi: Add t603x ---
commit 66ad58d37c9aac7f4dc961a6e2efa29feb72a053
Author: Sasha Finkelstein <k@chaosmail.tech>

dt-bindings: spmi: apple,spmi: Add t603x

This commit adds t603x compatibles, interrupt support, and support for SPMI
controllers that are not always-on.

> diff --git a/Documentation/devicetree/bindings/spmi/apple,spmi.yaml b/Documentation/devicetree/bindings/spmi/apple,spmi.yaml
> index 3e5b14bc8c317..9fc511bb0cb88 100644
> --- a/Documentation/devicetree/bindings/spmi/apple,spmi.yaml
> +++ b/Documentation/devicetree/bindings/spmi/apple,spmi.yaml

[ ... ]

> @@ -34,6 +36,18 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  interrupts:
> +    maxItems: 1
> +    description: Optional, operates in polled mode if not present
> +
> +  interrupt-controller: true
> +
> +  "#interrupt-cells":
> +    const: 2
> +
> +  power-domains:
> +    maxItems: 1
> +
>  required:
>    - compatible
>    - reg

[Severity: Medium]
Should interrupt-controller and #interrupt-cells be added to the required
list here, either globally or conditionally in an allOf block if they only
apply to certain variants?

When hardware gains new provider capabilities, the corresponding properties
must be added to the required list to prevent incomplete device tree nodes
from silently passing schema validation.

Additionally, does the example node need to be updated to include these
new properties?

Documentation/devicetree/bindings/spmi/apple,spmi.yaml:examples() {
    ...
    spmi@920a1300 {
        compatible = "apple,t6000-spmi", "apple,spmi";
        reg = <0x920a1300 0x100>;
        #address-cells = <2>;
        #size-cells = <0>;
    ...
}

If the properties become required, omitting them from the example will cause
the example to fail schema validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260725-t603x-spmi-v1-0-e1a29fcd2d38@chaosmail.tech?part=1