[PATCH 0/2] iio: light: veml3328: minor cleanup fixes

[PATCH 0/2] iio: light: veml3328: minor cleanup fixes

[Joshua Crofts]

This is a very small set of cleanup fixes for the VEML3328 driver.

Changes include:
- removing an extra blank line
- removing an unneeded i2c_set_clientdata() call

No functional change.

Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
Joshua Crofts (2):
      iio: light: veml3328: remove unused i2c_set_clientdata()
      iio: light: veml3328: remove extra blank line

 drivers/iio/light/veml3328.c | 2 --
 1 file changed, 2 deletions(-)
---
base-commit: 036d96ceec6d966339aea34d034420991e24cfac
change-id: 20260723-veml3328-cleanup-de9b0761c091

Best regards,
-- 
Kind regards,
Joshua Crofts

[PATCH 1/2] iio: light: veml3328: remove unused i2c_set_clientdata()

[Joshua Crofts]

The I2C client data is set but never used. Remove the unnecessary
function call.

No functional change.

Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
 drivers/iio/light/veml3328.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/light/veml3328.c b/drivers/iio/light/veml3328.c
index 7ff1753925c4..a65748466116 100644
--- a/drivers/iio/light/veml3328.c
+++ b/drivers/iio/light/veml3328.c
@@ -318,7 +318,6 @@ static int veml3328_probe(struct i2c_client *client)
 		return -ENOMEM;
 
 	data = iio_priv(indio_dev);
-	i2c_set_clientdata(client, indio_dev);
 
 	data->regmap = devm_regmap_init_i2c(client, &veml3328_regmap_config);
 	if (IS_ERR(data->regmap))

-- 
2.55.0

Re: [PATCH 1/2] iio: light: veml3328: remove unused i2c_set_clientdata()

[Jonathan Cameron]

On Fri, 24 Jul 2026 00:07:08 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:

> The I2C client data is set but never used. Remove the unnecessary
> function call.
Yes it is.  Take another look at how that works and how else the resulting
data is accessed (or just look at Sashiko)

I was hoping it would catch this one :)

The combination of different interfaces to access the same data has
been much debated over time but we never came to a conclusion on whether
it was worth the effort of stopping doing so given i2c driver reviewers
are far too familiar with this particular hole.

J

> 
> No functional change.
> 
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
> ---
>  drivers/iio/light/veml3328.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/light/veml3328.c b/drivers/iio/light/veml3328.c
> index 7ff1753925c4..a65748466116 100644
> --- a/drivers/iio/light/veml3328.c
> +++ b/drivers/iio/light/veml3328.c
> @@ -318,7 +318,6 @@ static int veml3328_probe(struct i2c_client *client)
>  		return -ENOMEM;
>  
>  	data = iio_priv(indio_dev);
> -	i2c_set_clientdata(client, indio_dev);
>  
>  	data->regmap = devm_regmap_init_i2c(client, &veml3328_regmap_config);
>  	if (IS_ERR(data->regmap))
> 

[PATCH 2/2] iio: light: veml3328: remove extra blank line

[Joshua Crofts]

Remove an extra blank line in the iio_chan_spec[] assignment.

No functional change.

Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
 drivers/iio/light/veml3328.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/light/veml3328.c b/drivers/iio/light/veml3328.c
index a65748466116..7884c8250590 100644
--- a/drivers/iio/light/veml3328.c
+++ b/drivers/iio/light/veml3328.c
@@ -70,7 +70,6 @@ static const struct regmap_config veml3328_regmap_config = {
 static const struct iio_chan_spec veml3328_channels[] = {
 	{
 		.type = IIO_LIGHT,
-
 		.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
 		.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE),
 		.info_mask_shared_by_type_available = BIT(IIO_CHAN_INFO_SCALE),

-- 
2.55.0

Re: [PATCH 2/2] iio: light: veml3328: remove extra blank line

[Jonathan Cameron]

On Fri, 24 Jul 2026 00:07:09 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:

> Remove an extra blank line in the iio_chan_spec[] assignment.
> 
> No functional change.

I don't mind this at one end of a series doing something more substantial
but patch 1 is going away anyway and this on it's own is too much
churn / noise.

Jonathan

> 
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
> ---
>  drivers/iio/light/veml3328.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/light/veml3328.c b/drivers/iio/light/veml3328.c
> index a65748466116..7884c8250590 100644
> --- a/drivers/iio/light/veml3328.c
> +++ b/drivers/iio/light/veml3328.c
> @@ -70,7 +70,6 @@ static const struct regmap_config veml3328_regmap_config = {
>  static const struct iio_chan_spec veml3328_channels[] = {
>  	{
>  		.type = IIO_LIGHT,
> -
>  		.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
>  		.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE),
>  		.info_mask_shared_by_type_available = BIT(IIO_CHAN_INFO_SCALE),
>