Re: [PATCH v3 2/3] dt-bindings: remoteproc: qcom,nord-pas: Document Nord PAS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The example defines the macro `IPCC_MPROC_ADSP0` without a value, which results in an empty token replacement and corrupts the cell counts for `interrupts-extended` and `mboxes`.
--

--- Patch [2]: [PATCH v3 2/3] dt-bindings: remoteproc: qcom,nord-pas: Document Nord PAS ---
commit 512d0175c2386f0e4a6fa83886169981b42b9b9a
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>

dt-bindings: remoteproc: qcom,nord-pas: Document Nord PAS

This commit adds a new device tree binding for the Qualcomm Nord SoC
Peripheral Authentication Service (PAS). It defines the required properties,
power domains, and interrupts for the ADSP and CDSP devices, and provides an
example device tree node.

> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml
> new file mode 100644
> index 0000000000000..e90d2953ba692
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,nord-pas.yaml
[ ... ]
> +examples:
> +  - |
> +    #include <dt-bindings/clock/qcom,rpmh.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/mailbox/qcom-ipcc.h>
> +    #include <dt-bindings/power/qcom,rpmhpd.h>
> +    #define IPCC_MPROC_ADSP0

[Severity: Low]
Does this empty macro definition corrupt the cell counts later in the example?

Because IPCC_MPROC_ADSP0 is defined without a value here, it evaluates to
nothing. This causes both the interrupts-extended and mboxes properties in the
glink-edge node below to silently drop the required client ID cell. The IPCC
mailbox controller expects 3 cells for interrupts and 2 cells for mboxes.

> +
> +    remoteproc@4c00000 {
> +        compatible = "qcom,nord-adsp-pas";
[ ... ]
> +        glink-edge {
> +            interrupts-extended = <&ipcc IPCC_MPROC_ADSP0
> +                                         IPCC_MPROC_SIGNAL_GLINK_QMP
> +                                         IRQ_TYPE_EDGE_RISING>;
> +            mboxes = <&ipcc IPCC_MPROC_ADSP0 IPCC_MPROC_SIGNAL_GLINK_QMP>;
> +
> +            label = "adsp";
> +            qcom,remote-pid = <2>;
> +
> +            /* ... */
> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727074621.561661-1-shengchao.guo@oss.qualcomm.com?part=2