From: sashiko-bot@kernel.org
To: "Shawn Guo" <shengchao.guo@oss.qualcomm.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 3/3] remoteproc: qcom: pas: Add Nord ADSP and CDSP support
Date: Mon, 27 Jul 2026 07:59:48 +0000 [thread overview]
Message-ID: <20260727075948.99A861F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260727074621.561661-4-shengchao.guo@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Alphabetical ordering violation in the `qcom_pas_of_match` array.
--
--- Patch [3]: [PATCH v3 3/3] remoteproc: qcom: pas: Add Nord ADSP and CDSP support ---
commit 38f8e6846aa65fbee31c1b49214c5b633ba02fbb
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>
remoteproc: qcom: pas: Add Nord ADSP and CDSP support
This commit adds support for ADSP and 4 CDSPs found on the Nord SoC. It also
configures the ADSP for early boot rather than a cold boot sequence since it
is pre-booted by XBL.
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index 25599d7282083..6f3850a3fa9e8 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
[ ... ]
> @@ -1695,6 +1800,11 @@ static const struct of_device_id qcom_pas_of_match[] = {
> { .compatible = "qcom,milos-cdsp-pas", .data = &milos_cdsp_resource },
> { .compatible = "qcom,milos-mpss-pas", .data = &sm8450_mpss_resource },
> { .compatible = "qcom,milos-wpss-pas", .data = &sc7280_wpss_resource },
> + { .compatible = "qcom,nord-adsp-pas", .data = &nord_adsp_resource },
> + { .compatible = "qcom,nord-cdsp0-pas", .data = &nord_cdsp0_resource },
> + { .compatible = "qcom,nord-cdsp1-pas", .data = &nord_cdsp1_resource },
> + { .compatible = "qcom,nord-cdsp2-pas", .data = &nord_cdsp2_resource },
> + { .compatible = "qcom,nord-cdsp3-pas", .data = &nord_cdsp3_resource },
> { .compatible = "qcom,msm8226-adsp-pil", .data = &msm8996_adsp_resource },
> { .compatible = "qcom,msm8953-adsp-pil", .data = &msm8996_adsp_resource },
> { .compatible = "qcom,msm8974-adsp-pil", .data = &msm8996_adsp_resource },
[Severity: Low]
This isn't a bug, but does inserting "nord" before "msm" violate the
alphabetical ordering of the qcom_pas_of_match array? Because "m" comes
before "n" alphabetically, should the "nord" entries be placed after the
"msm" entries to maintain the list's sorted order and prevent merge
conflicts?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260727074621.561661-1-shengchao.guo@oss.qualcomm.com?part=3
next prev parent reply other threads:[~2026-07-27 7:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 7:46 [PATCH v3 0/3] Add ADSP and CDSP support for Nord SoC Shawn Guo
2026-07-27 7:46 ` [PATCH v3 1/3] dt-bindings: soc: qcom,aoss-qmp: Document Nord AOSS side channel Shawn Guo
2026-07-27 7:46 ` [PATCH v3 2/3] dt-bindings: remoteproc: qcom,nord-pas: Document Nord PAS Shawn Guo
2026-07-27 7:57 ` sashiko-bot
2026-07-27 7:46 ` [PATCH v3 3/3] remoteproc: qcom: pas: Add Nord ADSP and CDSP support Shawn Guo
2026-07-27 7:59 ` sashiko-bot [this message]
2026-07-27 8:05 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260727075948.99A861F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shengchao.guo@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.