Re: [PATCH v3 3/5] arm64: dts: qcom: Add Kalambo CRD

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch leaves an orphaned PMIC endpoint and thermal zone by failing to delete the `spmi_bus1` node for PMIC D (`pmcx0102_d_e1`) and its associated thermal zone (`pmcx0102-d1-thermal`).
--

--- Patch [3]: [PATCH v3 3/5] arm64: dts: qcom: Add Kalambo CRD ---
commit 827c0ef9079fd542521c1496e341a245697bd21d
Author: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>

arm64: dts: qcom: Add Kalambo CRD
    
Introduce support for the CRD based on the Qualcomm Kalambo SoC, which is
pin-to-pin compatible with the Glymur CRD. The board description reuses the
common CRD layout and drops PMIC nodes that are not present on this design.

> diff --git a/arch/arm64/boot/dts/qcom/kalambo-crd.dts b/arch/arm64/boot/dts/qcom/kalambo-crd.dts
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/kalambo-crd.dts

[ ... ]

> +/delete-node/ &pmcx0102_d_e0;
> +/delete-node/ &pmcx0102_d0_thermal;

[Severity: Medium]
Should this also delete the e1 endpoint and d1 thermal zone for PMIC D?

The commit message notes that absent PMIC nodes are dropped, and PMIC D
is absent here. Since PMIC D spans both spmi_bus0 (e0) and spmi_bus1 (e1),
deleting only the e0 endpoint leaves the e1 endpoint active.

Will the SPMI driver attempt to probe the non-existent pmcx0102_d_e1 node
and generate bus timeouts or errors during boot? It appears that the
associated pmcx0102-d1-thermal zone may also need to be deleted (perhaps by
its full path if it lacks a label) to fully remove PMIC D from the tree.

> +/delete-node/ &pmh0104_i_e0;
> +/delete-node/ &pmh0104_i0_thermal;
> +/delete-node/ &pmh0104_j_e0;
> +/delete-node/ &pmh0104_j0_thermal;
> +
> +/ {
> +	model = "Qualcomm Technologies, Inc. Kalambo CRD";
> +	compatible = "qcom,kalambo-crd", "qcom,kalambo";
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-b4-kalambo-crd-v3-0-25280faceece@oss.qualcomm.com?part=3