All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 0/5] arm64: dts: qcom: Add Kalambo SoC and CRD
@ 2026-07-27 12:51 Gopikrishna Garmidi
  2026-07-27 12:51 ` [PATCH v3 1/5] dt-bindings: arm: qcom: Document Kalambo SoC and board Gopikrishna Garmidi
                   ` (4 more replies)
  0 siblings, 5 replies; 11+ messages in thread
From: Gopikrishna Garmidi @ 2026-07-27 12:51 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Sibi Sankar, Pankaj Patil
  Cc: Rajendra Nayak, linux-arm-msm, devicetree, linux-kernel,
	Krzysztof Kozlowski, Gopikrishna Garmidi, Konrad Dybcio,
	Dmitry Baryshkov

Qualcomm Kalambo SoC is derived from Mahua SoC with CPU cluster 0 
removed,leaving only cluster 1 present.

This series documents the board compatibles and adds the SoC and
Compute Reference Device (CRD) device trees. It also adds the Kalambo
compatible to the UBWC configuration table and allowlists the Kalambo
CRD for QSEECOM to enable access to efivars.

---
Changes in v3:
- Delete and redefine the whole cpu-map via the /cpus label.
- pdp0_mbox: one reg entry per line and use '0x0' instead of '0'.
- Rebased on next-20260726.
- Picked up R-b tags.
- Link to v2: https://patch.msgid.link/20260722-b4-kalambo-crd-v2-0-32d4addc1ac9@oss.qualcomm.com

Changes in v2:
- Fix the cpu-map and SCMI perf domain for the single cluster.
- Give the SCP shared-memory window its own IMEM section.
- Rebased on next-20260721.
- Picked up R-b tags.
- Link to v1: https://patch.msgid.link/20260718-b4-kalambo-crd-v1-0-a1069b5a2757@oss.qualcomm.com

---
Gopikrishna Garmidi (5):
      dt-bindings: arm: qcom: Document Kalambo SoC and board
      arm64: dts: qcom: Add Kalambo SoC
      arm64: dts: qcom: Add Kalambo CRD
      firmware: qcom: scm: Allow QSEECOM on Kalambo CRD
      soc: qcom: ubwc: Add Kalambo UBWC config

 Documentation/devicetree/bindings/arm/qcom.yaml |  5 ++
 arch/arm64/boot/dts/qcom/Makefile               |  1 +
 arch/arm64/boot/dts/qcom/glymur.dtsi            |  4 +-
 arch/arm64/boot/dts/qcom/kalambo-crd.dts        | 21 ++++++
 arch/arm64/boot/dts/qcom/kalambo.dtsi           | 97 +++++++++++++++++++++++++
 drivers/firmware/qcom/qcom_scm.c                |  1 +
 drivers/soc/qcom/ubwc_config.c                  |  1 +
 7 files changed, 128 insertions(+), 2 deletions(-)
---
base-commit: c5e32e86ca02b003f86e095d379b38148999293d
change-id: 20260715-b4-kalambo-crd-86912a03bbd2

Best regards,
--  
Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH v3 1/5] dt-bindings: arm: qcom: Document Kalambo SoC and board
  2026-07-27 12:51 [PATCH v3 0/5] arm64: dts: qcom: Add Kalambo SoC and CRD Gopikrishna Garmidi
@ 2026-07-27 12:51 ` Gopikrishna Garmidi
  2026-07-27 12:51 ` [PATCH v3 2/5] arm64: dts: qcom: Add Kalambo SoC Gopikrishna Garmidi
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 11+ messages in thread
From: Gopikrishna Garmidi @ 2026-07-27 12:51 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Sibi Sankar, Pankaj Patil
  Cc: Rajendra Nayak, linux-arm-msm, devicetree, linux-kernel,
	Krzysztof Kozlowski, Gopikrishna Garmidi

Qualcomm Kalambo is a derivative of the Mahua SoC with CPU cluster 0
removed, leaving it with just cluster 1. Document the compatible strings
for the Kalambo SoC and the Compute Reference Device (CRD) board based
on it.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index c7c9a9279684..b0c07a57bda6 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -174,6 +174,11 @@ properties:
               - qcom,kaanapali-qrd
           - const: qcom,kaanapali
 
+      - items:
+          - enum:
+              - qcom,kalambo-crd
+          - const: qcom,kalambo
+
       - items:
           - enum:
               - qcom,mahua-crd

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v3 2/5] arm64: dts: qcom: Add Kalambo SoC
  2026-07-27 12:51 [PATCH v3 0/5] arm64: dts: qcom: Add Kalambo SoC and CRD Gopikrishna Garmidi
  2026-07-27 12:51 ` [PATCH v3 1/5] dt-bindings: arm: qcom: Document Kalambo SoC and board Gopikrishna Garmidi
@ 2026-07-27 12:51 ` Gopikrishna Garmidi
  2026-07-27 13:06   ` sashiko-bot
                     ` (2 more replies)
  2026-07-27 12:51 ` [PATCH v3 3/5] arm64: dts: qcom: Add Kalambo CRD Gopikrishna Garmidi
                   ` (2 subsequent siblings)
  4 siblings, 3 replies; 11+ messages in thread
From: Gopikrishna Garmidi @ 2026-07-27 12:51 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Sibi Sankar, Pankaj Patil
  Cc: Rajendra Nayak, linux-arm-msm, devicetree, linux-kernel,
	Gopikrishna Garmidi

Introduce support for the Qualcomm Kalambo SoC. It is derived from Mahua
with CPU cluster 0 removed, leaving it with just cluster 1 (cpu6-cpu11).

The surviving cluster is re-added to the cpu-map as cluster0, since the
kernel stops scanning at the first missing clusterN index. cpu6-cpu11
are reassigned to SCMI performance domain 0, as domain 1 is no longer
present.

Kalambo uses PDP1 whose tx shmem (lpri1) sits at offset 0x200 within
imem, vs 0x180 on Glymur (PDP0). This pushes the tx region end to
0x380, requiring an imem size override. The rx shmem (lpri0) stays at
offset 0x0. The PDP mailbox addresses are overridden to match the
Kalambo SCP firmware.

Add labels to the cpus and cpu-map nodes in Glymur to allow derived
SoCs to delete and redefine the cpu-map entirely.

Co-developed-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Signed-off-by: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/glymur.dtsi  |  4 +-
 arch/arm64/boot/dts/qcom/kalambo.dtsi | 97 +++++++++++++++++++++++++++++++++++
 2 files changed, 99 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
index f32af66a3f1c..6094e741ff34 100644
--- a/arch/arm64/boot/dts/qcom/glymur.dtsi
+++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
@@ -36,7 +36,7 @@ / {
 	#address-cells = <2>;
 	#size-cells = <2>;
 
-	cpus {
+	cpus: cpus {
 		#address-cells = <2>;
 		#size-cells = <0>;
 
@@ -274,7 +274,7 @@ cpu17: cpu@20500 {
 			#cooling-cells = <2>;
 		};
 
-		cpu-map {
+		cpu_map: cpu-map {
 			cluster0 {
 				core0 {
 					cpu = <&cpu0>;
diff --git a/arch/arm64/boot/dts/qcom/kalambo.dtsi b/arch/arm64/boot/dts/qcom/kalambo.dtsi
new file mode 100644
index 000000000000..4a68115a4286
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/kalambo.dtsi
@@ -0,0 +1,97 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+#include "mahua.dtsi"
+
+/delete-node/ &cluster0_pd;
+/delete-node/ &cpu_map;
+/delete-node/ &cpu0;
+/delete-node/ &cpu1;
+/delete-node/ &cpu2;
+/delete-node/ &cpu3;
+/delete-node/ &cpu4;
+/delete-node/ &cpu5;
+/delete-node/ &cpu_pd0;
+/delete-node/ &cpu_pd1;
+/delete-node/ &cpu_pd2;
+/delete-node/ &cpu_pd3;
+/delete-node/ &cpu_pd4;
+/delete-node/ &cpu_pd5;
+/delete-node/ &cpu_scp_lpri1;
+
+&cpu6 {
+	power-domains = <&cpu_pd6>, <&scmi_perf 0>;
+	power-domain-names = "psci", "perf";
+};
+
+&cpu7 {
+	power-domains = <&cpu_pd7>, <&scmi_perf 0>;
+	power-domain-names = "psci", "perf";
+};
+
+&cpu8 {
+	power-domains = <&cpu_pd8>, <&scmi_perf 0>;
+	power-domain-names = "psci", "perf";
+};
+
+&cpu9 {
+	power-domains = <&cpu_pd9>, <&scmi_perf 0>;
+	power-domain-names = "psci", "perf";
+};
+
+&cpu10 {
+	power-domains = <&cpu_pd10>, <&scmi_perf 0>;
+	power-domain-names = "psci", "perf";
+};
+
+&cpu11 {
+	power-domains = <&cpu_pd11>, <&scmi_perf 0>;
+	power-domain-names = "psci", "perf";
+};
+
+&cpus {
+	cpu-map {
+		cluster0 {
+			core0 {
+				cpu = <&cpu6>;
+			};
+
+			core1 {
+				cpu = <&cpu7>;
+			};
+
+			core2 {
+				cpu = <&cpu8>;
+			};
+
+			core3 {
+				cpu = <&cpu9>;
+			};
+
+			core4 {
+				cpu = <&cpu10>;
+			};
+
+			core5 {
+				cpu = <&cpu11>;
+			};
+		};
+	};
+};
+
+&imem {
+	reg = <0x0 0x81e08600 0x0 0x380>;
+	ranges = <0x0 0x0 0x81e08600 0x380>;
+
+	cpu_scp_lpri1: scp-sram-section@200 {
+		compatible = "arm,scmi-shmem";
+		reg = <0x200 0x180>;
+	};
+};
+
+&pdp0_mbox {
+	reg = <0x0 0x17610000 0x0 0x8000>,
+	      <0x0 0x1a980000 0x0 0x8000>;
+};

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v3 3/5] arm64: dts: qcom: Add Kalambo CRD
  2026-07-27 12:51 [PATCH v3 0/5] arm64: dts: qcom: Add Kalambo SoC and CRD Gopikrishna Garmidi
  2026-07-27 12:51 ` [PATCH v3 1/5] dt-bindings: arm: qcom: Document Kalambo SoC and board Gopikrishna Garmidi
  2026-07-27 12:51 ` [PATCH v3 2/5] arm64: dts: qcom: Add Kalambo SoC Gopikrishna Garmidi
@ 2026-07-27 12:51 ` Gopikrishna Garmidi
  2026-07-27 12:59   ` sashiko-bot
  2026-07-27 13:58   ` Abel Vesa
  2026-07-27 12:51 ` [PATCH v3 4/5] firmware: qcom: scm: Allow QSEECOM on " Gopikrishna Garmidi
  2026-07-27 12:51 ` [PATCH v3 5/5] soc: qcom: ubwc: Add Kalambo UBWC config Gopikrishna Garmidi
  4 siblings, 2 replies; 11+ messages in thread
From: Gopikrishna Garmidi @ 2026-07-27 12:51 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Sibi Sankar, Pankaj Patil
  Cc: Rajendra Nayak, linux-arm-msm, devicetree, linux-kernel,
	Konrad Dybcio, Dmitry Baryshkov, Gopikrishna Garmidi

Introduce support for the CRD based on the Qualcomm Kalambo SoC. Similar
to Mahua, it is pin-to-pin compatible with the Glymur CRD. It reuses the
common CRD board description and drops the PMIC nodes not present on this
design.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/Makefile        |  1 +
 arch/arm64/boot/dts/qcom/kalambo-crd.dts | 21 +++++++++++++++++++++
 2 files changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index e05414290d8e..0ea4d6696aee 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -43,6 +43,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= ipq9574-rdp454.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq9650-rdp488.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= kaanapali-mtp.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= kaanapali-qrd.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= kalambo-crd.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= lemans-evk.dtb
 
 lemans-evk-camera-csi1-imx577-dtbs	:= lemans-evk.dtb lemans-evk-camera-csi1-imx577.dtbo
diff --git a/arch/arm64/boot/dts/qcom/kalambo-crd.dts b/arch/arm64/boot/dts/qcom/kalambo-crd.dts
new file mode 100644
index 000000000000..b4441807f460
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/kalambo-crd.dts
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+/dts-v1/;
+
+#include "kalambo.dtsi"
+#include "glymur-crd.dtsi"
+
+/delete-node/ &pmcx0102_d_e0;
+/delete-node/ &pmcx0102_d0_thermal;
+/delete-node/ &pmh0104_i_e0;
+/delete-node/ &pmh0104_i0_thermal;
+/delete-node/ &pmh0104_j_e0;
+/delete-node/ &pmh0104_j0_thermal;
+
+/ {
+	model = "Qualcomm Technologies, Inc. Kalambo CRD";
+	compatible = "qcom,kalambo-crd", "qcom,kalambo";
+};

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v3 4/5] firmware: qcom: scm: Allow QSEECOM on Kalambo CRD
  2026-07-27 12:51 [PATCH v3 0/5] arm64: dts: qcom: Add Kalambo SoC and CRD Gopikrishna Garmidi
                   ` (2 preceding siblings ...)
  2026-07-27 12:51 ` [PATCH v3 3/5] arm64: dts: qcom: Add Kalambo CRD Gopikrishna Garmidi
@ 2026-07-27 12:51 ` Gopikrishna Garmidi
  2026-07-27 12:51 ` [PATCH v3 5/5] soc: qcom: ubwc: Add Kalambo UBWC config Gopikrishna Garmidi
  4 siblings, 0 replies; 11+ messages in thread
From: Gopikrishna Garmidi @ 2026-07-27 12:51 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Sibi Sankar, Pankaj Patil
  Cc: Rajendra Nayak, linux-arm-msm, devicetree, linux-kernel,
	Konrad Dybcio, Dmitry Baryshkov, Gopikrishna Garmidi

Add Kalambo CRD board to the QSEECOM allowlist for enabling access to
efivars.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
---
 drivers/firmware/qcom/qcom_scm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
index f35f2ee39130..d1cc6c908daa 100644
--- a/drivers/firmware/qcom/qcom_scm.c
+++ b/drivers/firmware/qcom/qcom_scm.c
@@ -2327,6 +2327,7 @@ static const struct of_device_id qcom_scm_qseecom_allowlist[] __maybe_unused = {
 	{ .compatible = "microsoft,romulus15", },
 	{ .compatible = "qcom,glymur-crd" },
 	{ .compatible = "qcom,hamoa-iot-evk" },
+	{ .compatible = "qcom,kalambo-crd" },
 	{ .compatible = "qcom,mahua-crd" },
 	{ .compatible = "qcom,purwa-iot-evk" },
 	{ .compatible = "qcom,sc8180x-primus" },

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v3 5/5] soc: qcom: ubwc: Add Kalambo UBWC config
  2026-07-27 12:51 [PATCH v3 0/5] arm64: dts: qcom: Add Kalambo SoC and CRD Gopikrishna Garmidi
                   ` (3 preceding siblings ...)
  2026-07-27 12:51 ` [PATCH v3 4/5] firmware: qcom: scm: Allow QSEECOM on " Gopikrishna Garmidi
@ 2026-07-27 12:51 ` Gopikrishna Garmidi
  4 siblings, 0 replies; 11+ messages in thread
From: Gopikrishna Garmidi @ 2026-07-27 12:51 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Sibi Sankar, Pankaj Patil
  Cc: Rajendra Nayak, linux-arm-msm, devicetree, linux-kernel,
	Konrad Dybcio, Dmitry Baryshkov, Gopikrishna Garmidi

Qualcomm Kalambo is a derivative of the Mahua SoC and shares the same
Universal Bandwidth Compression (UBWC) configuration. Add the Kalambo
compatible to the UBWC configuration table to enable support.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
---
 drivers/soc/qcom/ubwc_config.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/qcom/ubwc_config.c b/drivers/soc/qcom/ubwc_config.c
index 0209a02c390f..c5f79210ad52 100644
--- a/drivers/soc/qcom/ubwc_config.c
+++ b/drivers/soc/qcom/ubwc_config.c
@@ -112,6 +112,7 @@ static const struct of_device_id qcom_ubwc_configs[] __maybe_unused = {
 	{ .compatible = "qcom,eliza", .data = &ubwc_5_0_hbb15 },
 	{ .compatible = "qcom,glymur", .data = &glymur_data},
 	{ .compatible = "qcom,kaanapali", .data = &ubwc_6_0_hbb16 },
+	{ .compatible = "qcom,kalambo", .data = &glymur_data },
 	{ .compatible = "qcom,mahua", .data = &glymur_data },
 	{ .compatible = "qcom,milos", .data = &milos_data },
 	{ .compatible = "qcom,msm8226", .data = &no_ubwc_data },

-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH v3 3/5] arm64: dts: qcom: Add Kalambo CRD
  2026-07-27 12:51 ` [PATCH v3 3/5] arm64: dts: qcom: Add Kalambo CRD Gopikrishna Garmidi
@ 2026-07-27 12:59   ` sashiko-bot
  2026-07-27 13:58   ` Abel Vesa
  1 sibling, 0 replies; 11+ messages in thread
From: sashiko-bot @ 2026-07-27 12:59 UTC (permalink / raw)
  To: Gopikrishna Garmidi; +Cc: conor+dt, robh, devicetree

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch leaves an orphaned PMIC endpoint and thermal zone by failing to delete the `spmi_bus1` node for PMIC D (`pmcx0102_d_e1`) and its associated thermal zone (`pmcx0102-d1-thermal`).
--

--- Patch [3]: [PATCH v3 3/5] arm64: dts: qcom: Add Kalambo CRD ---
commit 827c0ef9079fd542521c1496e341a245697bd21d
Author: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>

arm64: dts: qcom: Add Kalambo CRD
    
Introduce support for the CRD based on the Qualcomm Kalambo SoC, which is
pin-to-pin compatible with the Glymur CRD. The board description reuses the
common CRD layout and drops PMIC nodes that are not present on this design.

> diff --git a/arch/arm64/boot/dts/qcom/kalambo-crd.dts b/arch/arm64/boot/dts/qcom/kalambo-crd.dts
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/kalambo-crd.dts

[ ... ]

> +/delete-node/ &pmcx0102_d_e0;
> +/delete-node/ &pmcx0102_d0_thermal;

[Severity: Medium]
Should this also delete the e1 endpoint and d1 thermal zone for PMIC D?

The commit message notes that absent PMIC nodes are dropped, and PMIC D
is absent here. Since PMIC D spans both spmi_bus0 (e0) and spmi_bus1 (e1),
deleting only the e0 endpoint leaves the e1 endpoint active.

Will the SPMI driver attempt to probe the non-existent pmcx0102_d_e1 node
and generate bus timeouts or errors during boot? It appears that the
associated pmcx0102-d1-thermal zone may also need to be deleted (perhaps by
its full path if it lacks a label) to fully remove PMIC D from the tree.

> +/delete-node/ &pmh0104_i_e0;
> +/delete-node/ &pmh0104_i0_thermal;
> +/delete-node/ &pmh0104_j_e0;
> +/delete-node/ &pmh0104_j0_thermal;
> +
> +/ {
> +	model = "Qualcomm Technologies, Inc. Kalambo CRD";
> +	compatible = "qcom,kalambo-crd", "qcom,kalambo";
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-b4-kalambo-crd-v3-0-25280faceece@oss.qualcomm.com?part=3

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3 2/5] arm64: dts: qcom: Add Kalambo SoC
  2026-07-27 12:51 ` [PATCH v3 2/5] arm64: dts: qcom: Add Kalambo SoC Gopikrishna Garmidi
@ 2026-07-27 13:06   ` sashiko-bot
  2026-07-27 13:40   ` Konrad Dybcio
  2026-07-27 13:58   ` Abel Vesa
  2 siblings, 0 replies; 11+ messages in thread
From: sashiko-bot @ 2026-07-27 13:06 UTC (permalink / raw)
  To: Gopikrishna Garmidi; +Cc: conor+dt, devicetree, robh

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing deletion of hardware blocks and thermal zones specific to the removed CPU cluster 0 (e.g., `bwmon_cluster0`, thermal zones), leading to a fatal SError and spurious thermal shutdowns.
--

--- Patch [2]: [PATCH v3 2/5] arm64: dts: qcom: Add Kalambo SoC ---
commit d6b5f610923793ce8197e8297bbc2ded9a915289
Author: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>

arm64: dts: qcom: Add Kalambo SoC

This commit introduces support for the Qualcomm Kalambo SoC, which is
derived from Mahua but has CPU cluster 0 removed. It reassigns the surviving
cluster as cluster0 in the cpu-map and overrides memory offsets for imem.

> diff --git a/arch/arm64/boot/dts/qcom/kalambo.dtsi b/arch/arm64/boot/dts/qcom/kalambo.dtsi
> new file mode 100644
> index 0000000000000..4a68115a4286a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/kalambo.dtsi
> @@ -0,0 +1,97 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +#include "mahua.dtsi"
> +
> +/delete-node/ &cluster0_pd;
> +/delete-node/ &cpu_map;
> +/delete-node/ &cpu0;

[Severity: High]
Does this also need to delete the associated bwmon_cluster0 node and the
cluster 0 thermal zones (like cpu-0-0-0-thermal and qmx-0-0-thermal)?

Because bwmon_cluster0 lacks a power domain dependency in the base device
tree, the icc-bwmon driver might unconditionally probe it. On Qualcomm SoCs,
attempting to map and access the MMIO registers of a physically removed
hardware block typically triggers a bus timeout and a fatal asynchronous
SError during boot.

Additionally, will leaving the cluster 0 thermal zones active cause them to
poll non-existent tsens sensors? If so, this could return garbage maximum
values and trigger an immediate emergency thermal shutdown.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-b4-kalambo-crd-v3-0-25280faceece@oss.qualcomm.com?part=2

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3 2/5] arm64: dts: qcom: Add Kalambo SoC
  2026-07-27 12:51 ` [PATCH v3 2/5] arm64: dts: qcom: Add Kalambo SoC Gopikrishna Garmidi
  2026-07-27 13:06   ` sashiko-bot
@ 2026-07-27 13:40   ` Konrad Dybcio
  2026-07-27 13:58   ` Abel Vesa
  2 siblings, 0 replies; 11+ messages in thread
From: Konrad Dybcio @ 2026-07-27 13:40 UTC (permalink / raw)
  To: Gopikrishna Garmidi, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Sibi Sankar, Pankaj Patil
  Cc: Rajendra Nayak, linux-arm-msm, devicetree, linux-kernel

On 7/27/26 2:51 PM, Gopikrishna Garmidi wrote:
> Introduce support for the Qualcomm Kalambo SoC. It is derived from Mahua
> with CPU cluster 0 removed, leaving it with just cluster 1 (cpu6-cpu11).
> 
> The surviving cluster is re-added to the cpu-map as cluster0, since the
> kernel stops scanning at the first missing clusterN index. cpu6-cpu11
> are reassigned to SCMI performance domain 0, as domain 1 is no longer
> present.
> 
> Kalambo uses PDP1 whose tx shmem (lpri1) sits at offset 0x200 within
> imem, vs 0x180 on Glymur (PDP0). This pushes the tx region end to
> 0x380, requiring an imem size override. The rx shmem (lpri0) stays at
> offset 0x0. The PDP mailbox addresses are overridden to match the
> Kalambo SCP firmware.
> 
> Add labels to the cpus and cpu-map nodes in Glymur to allow derived
> SoCs to delete and redefine the cpu-map entirely.
> 
> Co-developed-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
> Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
> Signed-off-by: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3 2/5] arm64: dts: qcom: Add Kalambo SoC
  2026-07-27 12:51 ` [PATCH v3 2/5] arm64: dts: qcom: Add Kalambo SoC Gopikrishna Garmidi
  2026-07-27 13:06   ` sashiko-bot
  2026-07-27 13:40   ` Konrad Dybcio
@ 2026-07-27 13:58   ` Abel Vesa
  2 siblings, 0 replies; 11+ messages in thread
From: Abel Vesa @ 2026-07-27 13:58 UTC (permalink / raw)
  To: Gopikrishna Garmidi
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Sibi Sankar, Pankaj Patil, Rajendra Nayak,
	linux-arm-msm, devicetree, linux-kernel

On 26-07-27 05:51:39, Gopikrishna Garmidi wrote:
> Introduce support for the Qualcomm Kalambo SoC. It is derived from Mahua
> with CPU cluster 0 removed, leaving it with just cluster 1 (cpu6-cpu11).
> 
> The surviving cluster is re-added to the cpu-map as cluster0, since the
> kernel stops scanning at the first missing clusterN index. cpu6-cpu11
> are reassigned to SCMI performance domain 0, as domain 1 is no longer
> present.
> 
> Kalambo uses PDP1 whose tx shmem (lpri1) sits at offset 0x200 within
> imem, vs 0x180 on Glymur (PDP0). This pushes the tx region end to
> 0x380, requiring an imem size override. The rx shmem (lpri0) stays at
> offset 0x0. The PDP mailbox addresses are overridden to match the
> Kalambo SCP firmware.
> 
> Add labels to the cpus and cpu-map nodes in Glymur to allow derived
> SoCs to delete and redefine the cpu-map entirely.
> 
> Co-developed-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
> Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
> Signed-off-by: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v3 3/5] arm64: dts: qcom: Add Kalambo CRD
  2026-07-27 12:51 ` [PATCH v3 3/5] arm64: dts: qcom: Add Kalambo CRD Gopikrishna Garmidi
  2026-07-27 12:59   ` sashiko-bot
@ 2026-07-27 13:58   ` Abel Vesa
  1 sibling, 0 replies; 11+ messages in thread
From: Abel Vesa @ 2026-07-27 13:58 UTC (permalink / raw)
  To: Gopikrishna Garmidi
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Sibi Sankar, Pankaj Patil, Rajendra Nayak,
	linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio,
	Dmitry Baryshkov

On 26-07-27 05:51:40, Gopikrishna Garmidi wrote:
> Introduce support for the CRD based on the Qualcomm Kalambo SoC. Similar
> to Mahua, it is pin-to-pin compatible with the Glymur CRD. It reuses the
> common CRD board description and drops the PMIC nodes not present on this
> design.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Signed-off-by: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2026-07-27 13:59 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-27 12:51 [PATCH v3 0/5] arm64: dts: qcom: Add Kalambo SoC and CRD Gopikrishna Garmidi
2026-07-27 12:51 ` [PATCH v3 1/5] dt-bindings: arm: qcom: Document Kalambo SoC and board Gopikrishna Garmidi
2026-07-27 12:51 ` [PATCH v3 2/5] arm64: dts: qcom: Add Kalambo SoC Gopikrishna Garmidi
2026-07-27 13:06   ` sashiko-bot
2026-07-27 13:40   ` Konrad Dybcio
2026-07-27 13:58   ` Abel Vesa
2026-07-27 12:51 ` [PATCH v3 3/5] arm64: dts: qcom: Add Kalambo CRD Gopikrishna Garmidi
2026-07-27 12:59   ` sashiko-bot
2026-07-27 13:58   ` Abel Vesa
2026-07-27 12:51 ` [PATCH v3 4/5] firmware: qcom: scm: Allow QSEECOM on " Gopikrishna Garmidi
2026-07-27 12:51 ` [PATCH v3 5/5] soc: qcom: ubwc: Add Kalambo UBWC config Gopikrishna Garmidi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.